[GitHub] [flink] zentol commented on a diff in pull request #19592: [FLINK-27427][rpc] Remove timeouts from RpcUtils#terminate*

[GitBox <gi...@apache.org>]

zentol commented on code in PR #19592:
URL: https://github.com/apache/flink/pull/19592#discussion_r860582562


##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java:
##########
@@ -76,64 +76,63 @@ public static Set<Class<? extends RpcGateway>> extractImplementedRpcGateways(Cla
      * Shuts the given {@link RpcEndpoint} down and awaits its termination.
      *
      * @param rpcEndpoint to terminate
-     * @param timeout for this operation
      * @throws ExecutionException if a problem occurred
      * @throws InterruptedException if the operation has been interrupted
      * @throws TimeoutException if a timeout occurred
      */
-    public static void terminateRpcEndpoint(RpcEndpoint rpcEndpoint, Time timeout)
+    @VisibleForTesting
+    public static void terminateRpcEndpoint(RpcEndpoint rpcEndpoint)

Review Comment:
   I had the same feeling



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org