[GitHub] [beam] guillaumecle commented on a diff in pull request #17274: BEAM-13468 allow non-lts jvm version

[GitBox <gi...@apache.org>]

guillaumecle commented on code in PR #17274:
URL: https://github.com/apache/beam/pull/17274#discussion_r842216206


##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java:
##########
@@ -117,8 +121,9 @@ public static JavaVersion forSpecification(String specification) {
           return ver;
         }
       }
-      throw new UnsupportedOperationException(
-          String.format("unsupported Java version: %s", specification));
+      JavaVersion fallback = java11;
+      LOG.warn("unsupported Java version: {}, falling back to: {}", specification, fallback.specification);

Review Comment:
   This logger might be a bit too chatty, I can reduce the log level if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org