You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/03/19 07:33:03 UTC
[GitHub] [druid] samarthjain commented on a change in pull request #11013: Fix regression introduced by #11008
samarthjain commented on a change in pull request #11013:
URL: https://github.com/apache/druid/pull/11013#discussion_r597458727
##########
File path: server/src/main/java/org/apache/druid/server/security/AuthorizationUtils.java
##########
@@ -263,10 +263,6 @@ public static Access authorizeAllResourceActions(
throw new ISE("No authorizer found with name: [%s].", authenticationResult.getAuthorizerName());
}
- if (authorizer instanceof AllowAllAuthorizer) {
- return resources;
- }
-
Review comment:
Good call, @suneet-s . I added a unit test in the new commit and in the process I found that we can still skip authorizing the resources when AllowAllAuthorizer is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org