[jira] [Commented] (IMPALA-8897) Fully qualify all paths on the webserver

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923791#comment-16923791 ] 

ASF subversion and git services commented on IMPALA-8897:
---------------------------------------------------------

Commit fdde66987b4c05aed1f0d848c6f408110a3fcdcc in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=fdde669 ]

IMPALA-8897 (part 2): Fix javascript to work with Knox integration

This patch qualifies all urls accessed via javascript in the webui
with the appropriate host:port in order to allow these urls to work
when the connection to the webui is being proxied through Apache Knox.

It accomplishes this with the function make_url(), which takes the
href of a link from the page, which may have been rewritten by Knox,
and appends a path to it.

This patch also fixes on issue on the /admissions page, where
resetting a pool's stats could fail due to the page being reloaded
before the reset is executed. Fixed by moving the call to reload to
the completion callback for the 'reset' endpoint.

Testing:
- Added a regex to test_knox_compatability that performs a rough check
  for places in the tmpl files where urls are used in javascript
  without calling make_url().

Change-Id: I3de9fd1bbb8bb38ce63b3160fcafd33eb0530581
Reviewed-on: http://gerrit.cloudera.org:8080/14173
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Fully qualify all paths on the webserver
> ----------------------------------------
>
>                 Key: IMPALA-8897
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8897
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 3.4.0
>            Reporter: Thomas Tauber-Marshall
>            Assignee: Thomas Tauber-Marshall
>            Priority: Critical
>
> In order to support Knox proxying of the debug webui, we should fully qualify all links on our debug web ui with the host:port.
> This will allow us to create rewrite rules that do the transform:
> <a href="host:port/path">...</a>
> =>
> <a href="<knox-host>/topology/impalaui/path?host=host&port=port>...</a>
> One complication is preventing regressions when future links are added, since this is a difficult thing to test for



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org