You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/15 19:07:38 UTC

[GitHub] [incubator-tvm] yidawang commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue

yidawang commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue
URL: https://github.com/apache/incubator-tvm/pull/4344#discussion_r346968947
 
 

 ##########
 File path: src/runtime/thread_pool.cc
 ##########
 @@ -370,11 +374,7 @@ class ThreadPool {
   // number of workers used (can be restricted with affinity pref)
   int num_workers_used_;
   // if excluding worker 0 and using master to run task 0
 
 Review comment:
   Let's also take the chance to revise this comment a bit, which even confused myself.
   
   Suggested revision: //if or not to exclude worker 0 and use master to run task 0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services