You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/07/27 08:19:38 UTC

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #319: add jmx interface for getting the active and pending tasks in FlushManager

jt2594838 commented on a change in pull request #319: add jmx interface for getting the active and pending tasks in FlushManager
URL: https://github.com/apache/incubator-iotdb/pull/319#discussion_r307957953
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/service/ServiceType.java
 ##########
 @@ -33,7 +33,9 @@
   SYNC_SERVICE("SYNC ServerService", ""),
   PERFORMANCE_STATISTIC_SERVICE("PERFORMANCE_STATISTIC_SERVICE","PERFORMANCE_STATISTIC_SERVICE"),
   TVLIST_ALLOCATOR_SERVICE("TVList Allocator", ""),
-  FLUSH_SERVICE("Flush ServerService", "");
+
+  FLUSH_SERVICE("Flush ServerService",
+      generateJmxName("org.apache.iotdb.db.engine.pool", "Flush Manager"));
 
 Review comment:
   How about renaming the JmxNames of other services that are registered in JMX too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services