[jira] [Commented] (CASSANDRA-5906) Avoid allocating over-large bloom filters

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851049#comment-13851049 ] 

Jonathan Ellis commented on CASSANDRA-5906:
-------------------------------------------

Most changes to CompactionTask are cosmetic -- split out to a separate commit?

Why would {{metadata.cardinalityEstimator}} be null if we've already checked {{newStatsFile}}?

Otherwise +1.

> Avoid allocating over-large bloom filters
> -----------------------------------------
>
>                 Key: CASSANDRA-5906
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5906
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Yuki Morishita
>             Fix For: 2.1
>
>         Attachments: 5906.txt
>
>
> We conservatively estimate the number of partitions post-compaction to be the total number of partitions pre-compaction.  That is, we assume the worst-case scenario of no partition overlap at all.
> This can result in substantial memory wasted in sstables resulting from highly overlapping compactions.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)