You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2021/07/09 12:54:35 UTC
[GitHub] [wicket] solomax opened a new pull request #475: no jira: javadoc:aggregate seems to work locally
solomax opened a new pull request #475:
URL: https://github.com/apache/wicket/pull/475
The only issue I'm observing so far: All links to JDK classes points to Java8 API .....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax commented on pull request #475: no jira: javadoc:aggregate seems to work locally
Posted by GitBox <gi...@apache.org>.
solomax commented on pull request #475:
URL: https://github.com/apache/wicket/pull/475#issuecomment-877217210
The result of `mvn clean deploy javadoc:aggregate-no-fork` can be checked here: https://ci-builds.apache.org/job/Wicket/job/wicket-9.x/javadoc/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #475: no jira: javadoc:aggregate seems to work locally
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r666932739
##########
File path: testing/wicket-threadtest/src/site/site.xml
##########
@@ -16,9 +16,4 @@
limitations under the License.
-->
<project name="Wicket Thread Test">
- <skin>
- <groupId>org.apache.wicket</groupId>
- <artifactId>wicket-site-skin</artifactId>
- <version>1.0-SNAPSHOT</version>
- </skin>
Review comment:
I have no idea what that is!
##########
File path: pom.xml
##########
@@ -1020,7 +1020,6 @@
<failOnError>true</failOnError>
<doclint>none</doclint>
<additionalJOption>${javadoc.additionalJOption}</additionalJOption>
- <sourcepath>${project.build.sourceDirectory}</sourcepath>
Review comment:
I should remove this from the jpms branch too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on pull request #475: no jira: javadoc:aggregate seems to work locally
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #475:
URL: https://github.com/apache/wicket/pull/475#issuecomment-877179810
If this fixes the javadoc issue then you could use WICKET-6884 in the title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #475: WICKET-6884: javadoc:aggregate seems to work locally
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r667522677
##########
File path: pom.xml
##########
@@ -1020,7 +1020,6 @@
<failOnError>true</failOnError>
<doclint>none</doclint>
<additionalJOption>${javadoc.additionalJOption}</additionalJOption>
- <sourcepath>${project.build.sourceDirectory}</sourcepath>
Review comment:
This is already done: https://github.com/apache/wicket/blob/d0c80aeb774414fcdf11129a98c930ce4f79f25c/pom.xml#L1017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax commented on a change in pull request #475: no jira: javadoc:aggregate seems to work locally
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r666934748
##########
File path: testing/wicket-threadtest/src/site/site.xml
##########
@@ -16,9 +16,4 @@
limitations under the License.
-->
<project name="Wicket Thread Test">
- <skin>
- <groupId>org.apache.wicket</groupId>
- <artifactId>wicket-site-skin</artifactId>
- <version>1.0-SNAPSHOT</version>
- </skin>
Review comment:
I guess long time ago the site was generated by maven .... :)))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax merged pull request #475: WICKET-6884: javadoc:aggregate seems to work locally
Posted by GitBox <gi...@apache.org>.
solomax merged pull request #475:
URL: https://github.com/apache/wicket/pull/475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax commented on a change in pull request #475: WICKET-6884: javadoc:aggregate seems to work locally
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r667267759
##########
File path: pom.xml
##########
@@ -1020,7 +1020,6 @@
<failOnError>true</failOnError>
<doclint>none</doclint>
<additionalJOption>${javadoc.additionalJOption}</additionalJOption>
- <sourcepath>${project.build.sourceDirectory}</sourcepath>
Review comment:
Maybe `<source>8</source>` can be safely removed for jpms branch :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org