You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/11/17 21:35:35 UTC
Review Request 40400: Quota: Added registry tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40400/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3165
https://issues.apache.org/jira/browse/MESOS-3165
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/registrar_tests.cpp f4ed01e9f37f8291921b67f7fb2f54839812c8b1
Diff: https://reviews.apache.org/r/40400/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40400: Quota: Added registry tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 22, 2015, 6:07 p.m., Joris Van Remoortere wrote:
> > src/tests/registrar_tests.cpp, line 687
> > <https://reviews.apache.org/r/40400/diff/2/?file=1128834#file1128834line687>
> >
> > Let's use full words. `Alternate`, or we could enumerate them.
The reason why I didin't want to enumerate is to avoid potential confusion, because there are `quota1` and `quota2`, which are not directly tighed to `quotaResources1` and `quotaResources2`.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40400/#review107510
-----------------------------------------------------------
On Nov. 22, 2015, 5:02 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40400/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2015, 5:02 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3165
> https://issues.apache.org/jira/browse/MESOS-3165
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow up of https://reviews.apache.org/r/39983
>
>
> Diffs
> -----
>
> src/tests/registrar_tests.cpp f4ed01e9f37f8291921b67f7fb2f54839812c8b1
>
> Diff: https://reviews.apache.org/r/40400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40400: Quota: Added registry tests.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40400/#review107510
-----------------------------------------------------------
Ship it!
src/tests/registrar_tests.cpp (line 685)
<https://reviews.apache.org/r/40400/#comment166659>
I don't think the `once` is necessary.
src/tests/registrar_tests.cpp (line 687)
<https://reviews.apache.org/r/40400/#comment166661>
Let's use full words. `Alternate`, or we could enumerate them.
src/tests/registrar_tests.cpp (lines 691 - 693)
<https://reviews.apache.org/r/40400/#comment166667>
Since `Resources` has this as an implicit conversion, why do you need the explicit static cast here? (and below)
src/tests/registrar_tests.cpp (lines 722 - 723)
<https://reviews.apache.org/r/40400/#comment166670>
I think there is an implicit constructor that takes a repeated resource proto.
src/tests/registrar_tests.cpp (line 745)
<https://reviews.apache.org/r/40400/#comment166672>
We can just reference the `guarantee` here for the implicit constructor.
- Joris Van Remoortere
On Nov. 22, 2015, 5:02 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40400/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2015, 5:02 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3165
> https://issues.apache.org/jira/browse/MESOS-3165
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow up of https://reviews.apache.org/r/39983
>
>
> Diffs
> -----
>
> src/tests/registrar_tests.cpp f4ed01e9f37f8291921b67f7fb2f54839812c8b1
>
> Diff: https://reviews.apache.org/r/40400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40400: Quota: Added registry tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40400/
-----------------------------------------------------------
(Updated Nov. 22, 2015, 5:02 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3165
https://issues.apache.org/jira/browse/MESOS-3165
Repository: mesos
Description (updated)
-------
Follow up of https://reviews.apache.org/r/39983
Diffs
-----
src/tests/registrar_tests.cpp f4ed01e9f37f8291921b67f7fb2f54839812c8b1
Diff: https://reviews.apache.org/r/40400/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40400: Quota: Added registry tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40400/
-----------------------------------------------------------
(Updated Nov. 17, 2015, 8:54 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3165
https://issues.apache.org/jira/browse/MESOS-3165
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/registrar_tests.cpp f4ed01e9f37f8291921b67f7fb2f54839812c8b1
Diff: https://reviews.apache.org/r/40400/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40400: Quota: Added registry tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40400/
-----------------------------------------------------------
(Updated Nov. 17, 2015, 8:52 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3165
https://issues.apache.org/jira/browse/MESOS-3165
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/registrar_tests.cpp f4ed01e9f37f8291921b67f7fb2f54839812c8b1
Diff: https://reviews.apache.org/r/40400/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov