You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/05 02:34:29 UTC
[GitHub] [pulsar] leizhiyuan commented on pull request #13564: feat: add lua wireshark for pulsar
leizhiyuan commented on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1005331239
> > Missing header in: /Users/runner/work/pulsar/pulsar/wireshark/pulsar.lua
>
> The license is still missed. I think LUA is not commented by `/* ... */`. See https://en.wikibooks.org/wiki/Lua_Programming/comment. Before pushing your commit, you can run `mvn -B clean install -DskipTests` in your local env to ensure the license has been added correctly.

it seems lua comment can not be recognized, could I ignore .lua in config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org