You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/10 02:22:19 UTC
[GitHub] [incubator-dolphinscheduler] khadgarmage commented on a change in
pull request #1921: add stringutils ut
khadgarmage commented on a change in pull request #1921: add stringutils ut
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1921#discussion_r376845495
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
##########
@@ -451,17 +452,17 @@ public Result batchDeleteProcessDefinitionByIds(@ApiIgnore @RequestAttribute(val
try {
Map<String, Object> deleteResult = processDefinitionService.deleteProcessDefinitionById(loginUser, projectName, processDefinitionId);
if(!Status.SUCCESS.equals(deleteResult.get(Constants.STATUS))){
- deleteFailedIdList.add(processDefinitionId);
+ deleteFailedIdList.add(strProcessDefinitionId);
logger.error((String)deleteResult.get(Constants.MSG));
}
} catch (Exception e) {
- deleteFailedIdList.add(processDefinitionId);
+ deleteFailedIdList.add(strProcessDefinitionId);
}
}
}
if(!deleteFailedIdList.isEmpty()){
- putMsg(result, Status.BATCH_DELETE_PROCESS_DEFINE_BY_IDS_ERROR,StringUtils.join(deleteFailedIdList,","));
+ putMsg(result, Status.BATCH_DELETE_PROCESS_DEFINE_BY_IDS_ERROR, Strings.join(deleteFailedIdList,","));
}else{
Review comment:
Sorrym, i am very little coding in java, I wrote it in the way of golang ￣□￣｜｜
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services