You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by tolbertam <gi...@git.apache.org> on 2017/04/26 17:58:48 UTC
[GitHub] tinkerpop pull request #604: TINKERPOP-1670 Maintain Traversal type informat...
GitHub user tolbertam opened a pull request:
https://github.com/apache/tinkerpop/pull/604
TINKERPOP-1670 Maintain Traversal type information in promise()
For [TINKERPOP-1670](https://issues.apache.org/jira/browse/TINKERPOP-1670).
Adds start and end step generic type information in the Traversal type
that is input to the Function given to Traversal.promise().
Also updates test to use full type information to ensure this change
maintains the type information.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tolbertam/tinkerpop TINKERPOP-1670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #604
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #604: TINKERPOP-1670 Maintain Traversal type information in ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/604
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #604: TINKERPOP-1670 Maintain Traversal type information in ...
Posted by mpollmeier <gi...@git.apache.org>.
Github user mpollmeier commented on the issue:
https://github.com/apache/tinkerpop/pull/604
VOTE +1
related: https://github.com/mpollmeier/gremlin-scala/issues/203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #604: TINKERPOP-1670 Maintain Traversal type information in ...
Posted by tolbertam <gi...@git.apache.org>.
Github user tolbertam commented on the issue:
https://github.com/apache/tinkerpop/pull/604
> i assume this doesn't introduce a breaking change anywhere.
\U0001f44d , agreed.
> if so, could you re-target your pull request at the tp32 branch?
ah, my mistake! I updated the base to tp32.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #604: TINKERPOP-1670 Maintain Traversal type informat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #604: TINKERPOP-1670 Maintain Traversal type information in ...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/604
LGTM.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #604: TINKERPOP-1670 Maintain Traversal type information in ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/604
@tolbertam i assume this doesn't introduce a breaking change anywhere. if so, could you re-target your pull request at the tp32 branch? that way the change gets into 3.2.5. btw, the docker build is all good, so i'm good for a positive vote once you re-target.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---