You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Arik Kfir (JIRA)" <ji...@apache.org> on 2011/03/21 21:17:06 UTC

[jira] [Commented] (FELIX-2763) [FileInstall] disableConfigSave actually enables configuration save

    [ https://issues.apache.org/jira/browse/FELIX-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009348#comment-13009348 ] 

Arik Kfir commented on FELIX-2763:
----------------------------------

I'm usually rooting to change incorrect behavior, but to keep backward compabilitiy, I think this property should be deprecated and a new one should be introduced which enforces the correct behavior (overriding this property if both are specified).

> [FileInstall] disableConfigSave actually enables configuration save
> -------------------------------------------------------------------
>
>                 Key: FELIX-2763
>                 URL: https://issues.apache.org/jira/browse/FELIX-2763
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>            Reporter: Filippo Diotalevi
>
> Following FELIX-2699 a configuration option called
> felix.fileinstall.disableConfigSave
> has been introduces to prevent fileinstall to write back configuration changes in the original file.
> However the implementation skip this write-back if the value of the parameter is FALSE. Logically, it should be TRUE.
> Fix is pretty easy ConfigInstaller.java:109, I'm just not sure whether to introduce it or not, since it'll likely break all the applications using this feature.
> I documented anyway the current behaviour in the wiki a https://cwiki.apache.org/confluence/display/FELIX/Apache+Felix+File+Install

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira