You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/09/14 07:09:01 UTC
Review Request 38343: mesos: Fixed punctuation in log message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
Repository: mesos
Description
-------
Per style guide, log messages should not end in a period.
Diffs
-----
src/authentication/cram_md5/authenticator.cpp f751ee15a8e8fa47b645d4add0ebe457fa5b49fb
Diff: https://reviews.apache.org/r/38343/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 38343: mesos: Fixed punctuation in log message.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/#review98815
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38343]
All tests passed.
- Mesos ReviewBot
On Sept. 14, 2015, 5:09 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38343/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 5:09 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per style guide, log messages should not end in a period.
>
>
> Diffs
> -----
>
> src/authentication/cram_md5/authenticator.cpp f751ee15a8e8fa47b645d4add0ebe457fa5b49fb
>
> Diff: https://reviews.apache.org/r/38343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38343: mesos: Fixed punctuation in log message.
Posted by Klaus Ma <kl...@cguru.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/#review98813
-----------------------------------------------------------
Ship it!
Ship It!
- Klaus Ma
On Sept. 14, 2015, 5:09 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38343/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 5:09 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per style guide, log messages should not end in a period.
>
>
> Diffs
> -----
>
> src/authentication/cram_md5/authenticator.cpp f751ee15a8e8fa47b645d4add0ebe457fa5b49fb
>
> Diff: https://reviews.apache.org/r/38343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38343: mesos: Fixed punctuation in log message.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/#review98878
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Sept. 13, 2015, 10:09 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38343/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 10:09 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per style guide, log messages should not end in a period.
>
>
> Diffs
> -----
>
> src/authentication/cram_md5/authenticator.cpp f751ee15a8e8fa47b645d4add0ebe457fa5b49fb
>
> Diff: https://reviews.apache.org/r/38343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>