You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2012/08/14 19:20:37 UTC
[jira] [Created] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Jun Rao created KAFKA-461:
-----------------------------
Summary: remove support for format for magic byte 0 in 0.8
Key: KAFKA-461
URL: https://issues.apache.org/jira/browse/KAFKA-461
Project: Kafka
Issue Type: Bug
Components: core
Affects Versions: 0.8
Reporter: Jun Rao
Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Koshy updated KAFKA-461:
-----------------------------
Labels: bugs (was: )
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: bugs
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike reassigned KAFKA-461:
-----------------------------------
Assignee: Swapnil Ghike
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: bugs
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437245#comment-13437245 ]
Jun Rao commented on KAFKA-461:
-------------------------------
Thanks for the patch. A couple of comments:
1. Message: Let's remove the following comment:
* If magic byte is 1
2. We need to remove the test resource core/src/test/resources/test-kafka-logs
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: backward-incompatible, bugs
> Fix For: 0.8
>
> Attachments: kafka-461.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436886#comment-13436886 ]
Jun Rao commented on KAFKA-461:
-------------------------------
You can remove the backward compatibility tests as part of the patch.
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: bugs
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434592#comment-13434592 ]
Jay Kreps commented on KAFKA-461:
---------------------------------
I think the message format hasn't changed. Technically what we should do is change the request ids, but I think we decided not just to kind of "start fresh". Basically I don't think this would help since an old client can't make requests it won't be able to get any messages anyway.
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: bugs
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-461:
--------------------------------
Attachment: kafka-461-v2.patch
Made the above changes and rebased.
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: backward-incompatible, bugs
> Fix For: 0.8
>
> Attachments: kafka-461.patch, kafka-461-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435231#comment-13435231 ]
Jay Kreps commented on KAFKA-461:
---------------------------------
OIC, those were already there. Yes, that makes sense.
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: bugs
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-461:
--------------------------------
Attachment: kafka-461.patch
Done.
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: backward-incompatible, bugs
> Fix For: 0.8
>
> Attachments: kafka-461.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-461:
--------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for patch v2. Committed to 0.8
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: backward-incompatible, bugs
> Fix For: 0.8
>
> Attachments: kafka-461.patch, kafka-461-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-461:
--------------------------------
Fix Version/s: 0.8
Labels: backward-incompatible bugs (was: bugs)
Status: Patch Available (was: In Progress)
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: bugs, backward-incompatible
> Fix For: 0.8
>
> Attachments: kafka-461.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435150#comment-13435150 ]
Jun Rao commented on KAFKA-461:
-------------------------------
No, the message format hasn't changed. It's just that if we drop the support for magic byte 0, the code in 0.8 will be simpler since we can get rid of all the switch statements.
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: bugs
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao closed KAFKA-461.
-------------------------
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: backward-incompatible, bugs
> Fix For: 0.8
>
> Attachments: kafka-461.patch, kafka-461-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-461) remove support for format for magic
byte 0 in 0.8
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436876#comment-13436876 ]
Swapnil Ghike commented on KAFKA-461:
-------------------------------------
Can test the change once the backward compatibility tests are removed from 0.8.
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: bugs
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KAFKA-461) remove support for format for
magic byte 0 in 0.8
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KAFKA-461 started by Swapnil Ghike.
> remove support for format for magic byte 0 in 0.8
> -------------------------------------------------
>
> Key: KAFKA-461
> URL: https://issues.apache.org/jira/browse/KAFKA-461
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: bugs
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since 0.8 is a non-backward compatible release, should we remove the support for magic byte 0 in Message and support only magic byte 1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira