You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Matteo Merli <mm...@yahoo-inc.com> on 2016/01/31 20:54:17 UTC
Re: Review Request 33061: BOOKKEEPER-841: Bookie should calculate
ledgers map writing a new entry log file
> On May 19, 2015, 7:33 a.m., Sijie Guo wrote:
> > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java, line 49
> > <https://reviews.apache.org/r/33061/diff/4/?file=930852#file930852line49>
> >
> > why change here? the checkpointSource passed to super would be null
I think this was to fix unit tests (and currently addressed in BOOKKEEPER-854)
- Matteo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33061/#review84274
-----------------------------------------------------------
On April 15, 2015, 5:37 p.m., Matteo Merli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33061/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 5:37 p.m.)
>
>
> Review request for bookkeeper.
>
>
> Bugs: BOOKKEEPER-841
> https://issues.apache.org/jira/browse/BOOKKEEPER-841
>
>
> Repository: bookkeeper-git
>
>
> Description
> -------
>
> Bookie should calculate ledgers map when writing a new entry log file. so the bookie doesn't need to scan that entry log file again, which it would improve garbage collection efficiency
>
>
> Diffs
> -----
>
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogMetadata.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 0e052b5
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 299fb3e
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java 0a3884c
> bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java 488f4bf
>
> Diff: https://reviews.apache.org/r/33061/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matteo Merli
>
>