You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/03 22:29:24 UTC
[GitHub] [pinot] Jackie-Jiang opened a new pull request #8291: During rebalance, re-calculate the instance partitions to avoid race condition between 2 rebalances
Jackie-Jiang opened a new pull request #8291:
URL: https://github.com/apache/pinot/pull/8291
In no-downtime mode, when the ideal state is changed (potentially by another rebalance request), re-calculate the instance partitions before re-calculating the target assignment.
Currently we don't re-calculate the instance partitions, which can cause race condition between 2 rebalances (described in #8281). The rebalance algorithm is deterministic given the same input, so if instance partitions are re-calculated, multiple rebalances should give the same result, thus prevent the race condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #8291: During rebalance, re-calculate the instance partitions to avoid race condition between 2 rebalances
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #8291:
URL: https://github.com/apache/pinot/pull/8291#issuecomment-1059563088
@jackjlli It's slightly hard to add a test to guard this scenario because it requires a long running rebalance task, then interrupted with another rebalance task with downtime. Currently we don't have tests for long running rebalance tasks. We can add one as a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #8291: During rebalance, re-calculate the instance partitions to avoid race condition between 2 rebalances
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #8291:
URL: https://github.com/apache/pinot/pull/8291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org