You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hubgeter (via GitHub)" <gi...@apache.org> on 2026/03/16 16:28:21 UTC
[PR] Support iceberg v3 row lineage [doris]
hubgeter opened a new pull request, #61398:
URL: https://github.com/apache/doris/pull/61398
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4142048921
<details>
<summary>TPC-H: <b>Total hot run time: 26348 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 34b071b133fdfa89a067848b0e4774fd523d2cba, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17610 4531 4270 4270
q2 q3 10640 810 542 542
q4 4686 354 245 245
q5 7568 1201 1030 1030
q6 173 172 147 147
q7 773 867 656 656
q8 9308 1500 1355 1355
q9 4982 4721 4717 4717
q10 6255 1919 1658 1658
q11 459 246 252 246
q12 692 574 456 456
q13 18035 2716 1899 1899
q14 224 228 211 211
q15 q16 715 735 669 669
q17 738 816 480 480
q18 5875 5386 5124 5124
q19 1105 993 607 607
q20 538 513 378 378
q21 4189 1832 1411 1411
q22 334 289 247 247
Total cold run time: 94899 ms
Total hot run time: 26348 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4948 4730 4590 4590
q2 q3 3870 4355 3828 3828
q4 897 1209 789 789
q5 4072 4387 4372 4372
q6 203 177 143 143
q7 1764 1660 1532 1532
q8 2498 2777 2525 2525
q9 7618 7408 7413 7408
q10 3801 3963 3631 3631
q11 514 420 415 415
q12 492 620 456 456
q13 2548 3063 2089 2089
q14 291 294 275 275
q15 q16 720 743 717 717
q17 1139 1351 1318 1318
q18 7205 6690 6693 6690
q19 926 932 941 932
q20 2079 2172 2001 2001
q21 4029 3520 3316 3316
q22 506 442 370 370
Total cold run time: 50120 ms
Total hot run time: 47397 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4147328974
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61398_c7653223cc9ce26ef0ab46b4743228b8a577bbf1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61398_c7653223cc9ce26ef0ab46b4743228b8a577bbf1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.48% (27143/36939) |
| Line Coverage | 57.03% (291955/511976) |
| Region Coverage | 54.23% (242951/447989) |
| Branch Coverage | 55.97% (105469/188438) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4147637046
<details>
<summary>TPC-H: <b>Total hot run time: 26673 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2c4034f5c60782aef64c1bb6116f0ffb72c36c81, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17471 4584 4352 4352
q2 q3 10527 769 523 523
q4 4673 348 252 252
q5 7553 1208 1028 1028
q6 182 173 146 146
q7 773 879 685 685
q8 9296 1479 1310 1310
q9 4829 4745 4786 4745
q10 6305 1914 1638 1638
q11 478 240 230 230
q12 710 581 462 462
q13 18055 2781 1965 1965
q14 228 226 204 204
q15 q16 733 733 658 658
q17 745 802 492 492
q18 6127 5306 5291 5291
q19 1214 980 608 608
q20 546 500 361 361
q21 4460 1834 1425 1425
q22 339 298 368 298
Total cold run time: 95244 ms
Total hot run time: 26673 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4837 4669 4593 4593
q2 q3 3926 4555 3842 3842
q4 907 1232 808 808
q5 4134 4386 4351 4351
q6 190 178 137 137
q7 1752 1629 1532 1532
q8 2518 2738 2596 2596
q9 7745 7378 7492 7378
q10 3799 3991 3705 3705
q11 535 455 445 445
q12 521 602 452 452
q13 2506 3427 2109 2109
q14 296 317 301 301
q15 q16 726 770 709 709
q17 1161 1373 1367 1367
q18 7277 6724 6734 6724
q19 939 910 939 910
q20 2108 2185 2035 2035
q21 3976 3464 3338 3338
q22 488 420 372 372
Total cold run time: 50341 ms
Total hot run time: 47704 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4144317632
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/8146b07dbf367e0f583dd41df1ac525f3b27e491_8146b07dbf367e0f583dd41df1ac525f3b27e491_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/8146b07dbf367e0f583dd41df1ac525f3b27e491_8146b07dbf367e0f583dd41df1ac525f3b27e491_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.67% (1796/2283) |
| Line Coverage | 64.42% (32291/50128) |
| Region Coverage | 65.31% (16171/24761) |
| Branch Coverage | 55.77% (8618/15454) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4147569691
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #61398:
URL: https://github.com/apache/doris/pull/61398#discussion_r3003488593
##########
be/src/format/orc/vorc_reader.cpp:
##########
@@ -1249,6 +1261,10 @@ Status OrcReader::set_fill_columns(
_lazy_read_ctx.predicate_orc_columns.emplace_back(
_table_info_node_ptr->children_file_column_name(iter->first));
+ if (check_iceberg_row_lineage_column_idx(read_table_col) != -1) {
+ // Todo : enable lazy mat where filter iceberg row lineage column.
+ _enable_lazy_mat = false;
Review Comment:
**[Medium] Same issue as in Parquet: `_last_updated_sequence_number` fill incorrectly gated behind `need_row_ids()` and `first_row_id >= 0`**
See comment on `vparquet_group_reader.cpp` for detailed explanation. The guard condition should not require `first_row_id >= 0` or `need_row_ids()` for filling the `last_updated_sequence_number` column.
##########
be/src/exec/sink/viceberg_delete_sink.cpp:
##########
@@ -475,6 +568,160 @@ std::string VIcebergDeleteSink::_get_file_extension() const {
return fmt::format("{}{}", compress_name, file_format_name);
}
+Status VIcebergDeleteSink::_write_deletion_vector_files(
+ const std::map<std::string, IcebergFileDeletion>& file_deletions) {
+ std::vector<DeletionVectorBlob> blobs;
+ for (const auto& [data_file_path, deletion] : file_deletions) {
+ if (deletion.rows_to_delete.isEmpty()) {
+ continue;
+ }
+ roaring::Roaring64Map merged_rows = deletion.rows_to_delete;
+ DeletionVectorBlob blob;
+ blob.delete_count = static_cast<int64_t>(merged_rows.cardinality());
+ auto previous_delete_it = _rewritable_delete_files.find(data_file_path);
+ if (previous_delete_it != _rewritable_delete_files.end()) {
+ roaring::Roaring64Map previous_rows;
+ RETURN_IF_ERROR(load_rewritable_delete_rows(
+ _state, _state->runtime_profile(), data_file_path, previous_delete_it->second,
+ _hadoop_conf, _file_type, _broker_addresses, &previous_rows));
+ merged_rows |= previous_rows;
+ }
+
+ size_t bitmap_size = merged_rows.getSizeInBytes();
+ blob.referenced_data_file = data_file_path;
+ blob.partition_spec_id = deletion.partition_spec_id;
+ blob.partition_data_json = deletion.partition_data_json;
+ blob.merged_count = static_cast<int64_t>(merged_rows.cardinality());
+ blob.content_size_in_bytes = static_cast<int64_t>(4 + 4 + bitmap_size + 4);
+ blob.blob_data.resize(static_cast<size_t>(blob.content_size_in_bytes));
+ merged_rows.write(blob.blob_data.data() + 8);
+
+ uint32_t total_length = static_cast<uint32_t>(4 + bitmap_size);
+ BigEndian::Store32(blob.blob_data.data(), total_length);
+
+ constexpr char DV_MAGIC[] = {'\xD1', '\xD3', '\x39', '\x64'};
+ memcpy(blob.blob_data.data() + 4, DV_MAGIC, 4);
+
+ uint32_t crc = static_cast<uint32_t>(
+ ::crc32(0, reinterpret_cast<const Bytef*>(blob.blob_data.data() + 4),
+ 4 + (uInt)bitmap_size));
+ BigEndian::Store32(blob.blob_data.data() + 8 + bitmap_size, crc);
+ blobs.emplace_back(std::move(blob));
+ }
+
+ if (blobs.empty()) {
+ return Status::OK();
+ }
+
+ std::string puffin_path = _generate_puffin_file_path();
+ int64_t puffin_file_size = 0;
+ RETURN_IF_ERROR(_write_puffin_file(puffin_path, &blobs, &puffin_file_size));
+
+ for (const auto& blob : blobs) {
+ TIcebergCommitData commit_data;
+ commit_data.__set_file_path(puffin_path);
+ commit_data.__set_row_count(blob.delete_count);
+ commit_data.__set_file_size(puffin_file_size);
+ commit_data.__set_file_content(TFileContent::DELETION_VECTOR);
+ commit_data.__set_content_offset(blob.content_offset);
+ commit_data.__set_content_size_in_bytes(blob.content_size_in_bytes);
+ commit_data.__set_referenced_data_file_path(blob.referenced_data_file);
+ if (blob.partition_spec_id != 0 || !blob.partition_data_json.empty()) {
+ commit_data.__set_partition_spec_id(blob.partition_spec_id);
+ commit_data.__set_partition_data_json(blob.partition_data_json);
+ }
+
+ _commit_data_list.push_back(commit_data);
+ _delete_file_count++;
+ }
+ return Status::OK();
+}
+
+Status VIcebergDeleteSink::_write_puffin_file(const std::string& puffin_path,
+ std::vector<DeletionVectorBlob>* blobs,
+ int64_t* out_file_size) {
+ DCHECK(blobs != nullptr);
+ DCHECK(!blobs->empty());
+
+ io::FSPropertiesRef fs_properties(_file_type);
+ fs_properties.properties = &_hadoop_conf;
+ if (!_broker_addresses.empty()) {
+ fs_properties.broker_addresses = &_broker_addresses;
+ }
+ io::FileDescription file_description = {.path = puffin_path, .fs_name {}};
+ auto fs = DORIS_TRY(FileFactory::create_fs(fs_properties, file_description));
+ io::FileWriterOptions file_writer_options = {.used_by_s3_committer = false};
+ io::FileWriterPtr file_writer;
+ RETURN_IF_ERROR(fs->create_file(file_description.path, &file_writer, &file_writer_options));
+
+ constexpr char PUFFIN_MAGIC[] = {'\x50', '\x46', '\x41', '\x31'};
+ RETURN_IF_ERROR(file_writer->append(Slice(reinterpret_cast<const uint8_t*>(PUFFIN_MAGIC), 4)));
+ int64_t current_offset = 4;
+ for (auto& blob : *blobs) {
+ blob.content_offset = current_offset;
+ RETURN_IF_ERROR(file_writer->append(Slice(
+ reinterpret_cast<const uint8_t*>(blob.blob_data.data()), blob.blob_data.size())));
+ current_offset += static_cast<int64_t>(blob.blob_data.size());
+ }
+ RETURN_IF_ERROR(file_writer->append(Slice(reinterpret_cast<const uint8_t*>(PUFFIN_MAGIC), 4)));
+
+ std::string footer_json = _build_puffin_footer_json(*blobs);
+ RETURN_IF_ERROR(file_writer->append(
+ Slice(reinterpret_cast<const uint8_t*>(footer_json.data()), footer_json.size())));
+
+ char footer_size_buf[4];
+ LittleEndian::Store32(footer_size_buf, static_cast<uint32_t>(footer_json.size()));
+ RETURN_IF_ERROR(file_writer->append(
+ Slice(reinterpret_cast<const uint8_t*>(footer_size_buf), sizeof(footer_size_buf))));
+
+ char flags[4] = {0, 0, 0, 0};
+ RETURN_IF_ERROR(
+ file_writer->append(Slice(reinterpret_cast<const uint8_t*>(flags), sizeof(flags))));
+ RETURN_IF_ERROR(file_writer->append(Slice(reinterpret_cast<const uint8_t*>(PUFFIN_MAGIC), 4)));
+ RETURN_IF_ERROR(file_writer->close());
+
+ *out_file_size = current_offset + 4 + static_cast<int64_t>(footer_json.size()) + 4 + 4 + 4;
+ return Status::OK();
+}
+
+std::string VIcebergDeleteSink::_build_puffin_footer_json(
+ const std::vector<DeletionVectorBlob>& blobs) {
+ rapidjson::StringBuffer buffer;
+ rapidjson::Writer<rapidjson::StringBuffer> writer(buffer);
+ writer.StartObject();
+ writer.Key("blobs");
+ writer.StartArray();
+ for (const auto& blob : blobs) {
+ writer.StartObject();
+ writer.Key("type");
+ writer.String("deletion-vector-v1");
+ writer.Key("fields");
+ writer.StartArray();
+ writer.EndArray();
+ writer.Key("snapshot-id");
+ writer.Int64(-1);
+ writer.Key("sequence-number");
+ writer.Int64(-1);
+ writer.Key("offset");
+ writer.Int64(blob.content_offset);
+ writer.Key("length");
+ writer.Int64(blob.content_size_in_bytes);
+ writer.Key("properties");
+ writer.StartObject();
+ writer.Key("referenced-data-file");
+ writer.String(blob.referenced_data_file.c_str(),
+ static_cast<rapidjson::SizeType>(blob.referenced_data_file.size()));
+ std::string cardinality = std::to_string(blob.merged_count);
+ writer.Key("cardinality");
+ writer.String(cardinality.c_str(), static_cast<rapidjson::SizeType>(cardinality.size()));
+ writer.EndObject();
+ writer.EndObject();
+ }
+ writer.EndArray();
+ writer.EndObject();
+ return {buffer.GetString(), buffer.GetSize()};
+}
Review Comment:
**[Medium] Puffin footer JSON missing top-level `"properties"` field**
The Puffin spec v1 defines the footer payload as:
```json
{
"blobs": [ ... ],
"properties": { }
}
```
The current code only emits `"blobs"` at the top level. While some implementations tolerate its absence, strict Puffin readers (e.g., Spark, Trino) could reject the file.
**Fix:** Add before the top-level `EndObject()`:
```cpp
writer.Key("properties");
writer.StartObject();
writer.EndObject();
```
##########
be/src/format/parquet/vparquet_group_reader.cpp:
##########
@@ -1067,16 +1075,55 @@ Status RowGroupReader::_get_current_batch_row_id(size_t read_rows) {
Status RowGroupReader::_fill_row_id_columns(Block* block, size_t read_rows,
bool is_current_row_ids) {
+ const bool need_row_ids =
+ _row_id_column_iterator_pair.first != nullptr ||
+ (_row_lineage_columns != nullptr && _row_lineage_columns->need_row_ids());
+ if (need_row_ids && !is_current_row_ids) {
+ RETURN_IF_ERROR(_get_current_batch_row_id(read_rows));
+ }
if (_row_id_column_iterator_pair.first != nullptr) {
- if (!is_current_row_ids) {
- RETURN_IF_ERROR(_get_current_batch_row_id(read_rows));
- }
auto col = block->get_by_position(_row_id_column_iterator_pair.second)
.column->assume_mutable();
RETURN_IF_ERROR(_row_id_column_iterator_pair.first->read_by_rowids(
Review Comment:
**[Medium] `_last_updated_sequence_number` fill incorrectly gated behind `need_row_ids()` and `first_row_id >= 0`**
`last_updated_sequence_number` is a per-file constant (the sequence number of the operation that last wrote this file). It has no logical dependency on `_row_id` or whether row IDs are being computed.
If a query selects only `_last_updated_sequence_number` without `_row_id`, then `need_row_ids()` returns false (since `row_id_column_idx` would be -1), and the sequence number column would incorrectly remain null.
The same issue exists in the ORC reader at `vorc_reader.cpp:1576-1579`.
**Fix:** The guard for `_last_updated_sequence_number` should only check:
```cpp
if (_row_lineage_columns != nullptr &&
_row_lineage_columns->has_last_updated_sequence_number_column() &&
_row_lineage_columns->last_updated_sequence_number >= 0) {
```
Remove the `first_row_id >= 0` and `need_row_ids()` conditions.
##########
be/src/exec/sink/viceberg_delete_sink.cpp:
##########
@@ -30,14 +33,79 @@
#include "core/data_type/data_type_number.h"
#include "core/data_type/data_type_string.h"
#include "core/data_type/data_type_struct.h"
+#include "exec/common/endian.h"
#include "exprs/vexpr.h"
+#include "format/table/iceberg_delete_file_reader_helper.h"
#include "format/transformer/vfile_format_transformer.h"
+#include "io/file_factory.h"
#include "runtime/runtime_state.h"
+#include "util/slice.h"
#include "util/string_util.h"
#include "util/uid_util.h"
namespace doris {
+namespace {
+
+class RewriteBitmapVisitor final : public IcebergPositionDeleteVisitor {
+public:
+ RewriteBitmapVisitor(const std::string& referenced_data_file_path,
+ roaring::Roaring64Map* rows_to_delete)
Review Comment:
**[Critical] `row_count` uses pre-merge `delete_count` instead of post-merge `merged_count`**
`blob.delete_count` is assigned at line 580 **before** the merge with old deletion vectors (line 587: `merged_rows |= previous_rows`). The DV blob physically written to disk contains the **merged** bitmap, but `row_count` reports only the new deletes.
This creates an inconsistency:
- Puffin footer JSON correctly uses `merged_count` (line 714: `std::to_string(blob.merged_count)`)
- But the thrift commit data claims a smaller count
In FE, `IcebergWriterHelper.convertToDeleteFiles()` uses `getRowCount()` as the manifest `recordCount` for the `DeleteFile` (line 218: `withRecordCount(recordCount)`). The Iceberg manifest will thus contain an incorrect record count for the DV, which can cause issues with Iceberg readers (Spark, Trino, etc.) that validate or use this count.
Also, `IcebergTransaction.getUpdateCnt()` (line 569) accumulates `getRowCount()` for delete rows — this would undercount affected rows.
**Fix:**
```cpp
commit_data.__set_row_count(blob.merged_count);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4146460104
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c7653223cc9ce26ef0ab46b4743228b8a577bbf1_c7653223cc9ce26ef0ab46b4743228b8a577bbf1_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c7653223cc9ce26ef0ab46b4743228b8a577bbf1_c7653223cc9ce26ef0ab46b4743228b8a577bbf1_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.67% (1796/2283) |
| Line Coverage | 64.47% (32316/50128) |
| Region Coverage | 65.36% (16183/24761) |
| Branch Coverage | 55.83% (8628/15454) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4147785962
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61398_2c4034f5c60782aef64c1bb6116f0ffb72c36c81_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61398_2c4034f5c60782aef64c1bb6116f0ffb72c36c81_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.52% (27156/36939) |
| Line Coverage | 57.02% (291948/511982) |
| Region Coverage | 54.35% (243489/447992) |
| Branch Coverage | 56.05% (105621/188442) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4142157274
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/34b071b133fdfa89a067848b0e4774fd523d2cba_34b071b133fdfa89a067848b0e4774fd523d2cba_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/34b071b133fdfa89a067848b0e4774fd523d2cba_34b071b133fdfa89a067848b0e4774fd523d2cba_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.67% (1796/2283) |
| Line Coverage | 64.41% (32285/50128) |
| Region Coverage | 65.30% (16168/24761) |
| Branch Coverage | 55.72% (8611/15454) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4149477345
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4147648180
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2c4034f5c60782aef64c1bb6116f0ffb72c36c81_2c4034f5c60782aef64c1bb6116f0ffb72c36c81_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2c4034f5c60782aef64c1bb6116f0ffb72c36c81_2c4034f5c60782aef64c1bb6116f0ffb72c36c81_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.67% (1796/2283) |
| Line Coverage | 64.36% (32263/50128) |
| Region Coverage | 65.27% (16161/24761) |
| Branch Coverage | 55.71% (8610/15454) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4140410718
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4144433826
<details>
<summary>TPC-DS: <b>Total hot run time: 168799 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8146b07dbf367e0f583dd41df1ac525f3b27e491, data reload: false
query5 4328 643 502 502
query6 342 240 205 205
query7 4200 459 254 254
query8 345 237 224 224
query9 8750 2697 2684 2684
query10 509 385 324 324
query11 6919 5087 4858 4858
query12 176 127 123 123
query13 1296 459 349 349
query14 5809 3786 3474 3474
query14_1 2914 2865 2856 2856
query15 208 198 178 178
query16 973 472 395 395
query17 914 688 600 600
query18 2428 438 345 345
query19 210 208 182 182
query20 130 126 125 125
query21 219 132 108 108
query22 13205 14020 15048 14020
query23 16609 16287 16102 16102
query23_1 16203 15838 15662 15662
query24 7276 1620 1225 1225
query24_1 1220 1258 1212 1212
query25 542 451 390 390
query26 1242 263 149 149
query27 2789 481 288 288
query28 4488 1828 1843 1828
query29 848 549 474 474
query30 297 224 187 187
query31 1008 947 858 858
query32 87 69 70 69
query33 502 330 285 285
query34 872 896 529 529
query35 629 679 603 603
query36 1112 1124 978 978
query37 135 94 84 84
query38 2963 2915 2892 2892
query39 858 838 818 818
query39_1 797 787 779 779
query40 226 150 134 134
query41 63 93 58 58
query42 264 259 256 256
query43 243 245 227 227
query44
query45 196 189 178 178
query46 879 986 609 609
query47 2895 2123 2045 2045
query48 311 317 218 218
query49 637 488 382 382
query50 673 275 216 216
query51 4007 4010 3982 3982
query52 261 272 254 254
query53 295 334 283 283
query54 299 281 267 267
query55 86 92 87 87
query56 331 315 331 315
query57 1923 1887 1751 1751
query58 280 267 261 261
query59 2798 2929 2725 2725
query60 327 328 324 324
query61 155 152 174 152
query62 628 581 508 508
query63 314 279 273 273
query64 5074 1280 1005 1005
query65
query66 1466 473 384 384
query67 24448 24342 24269 24269
query68
query69 414 318 295 295
query70 953 987 861 861
query71 338 317 299 299
query72 3195 2846 2701 2701
query73 538 555 316 316
query74 9580 9578 9387 9387
query75 2897 2776 2471 2471
query76 2284 1031 695 695
query77 364 403 297 297
query78 10814 11009 10487 10487
query79 3087 763 578 578
query80 1747 612 537 537
query81 576 253 227 227
query82 1016 148 120 120
query83 333 265 243 243
query84 301 117 97 97
query85 920 486 455 455
query86 481 314 316 314
query87 3148 3113 2972 2972
query88 3534 2642 2626 2626
query89 412 371 351 351
query90 1892 179 164 164
query91 181 168 139 139
query92 82 73 71 71
query93 1479 837 502 502
query94 652 328 303 303
query95 590 406 326 326
query96 646 506 232 232
query97 2453 2488 2414 2414
query98 237 221 238 221
query99 998 966 871 871
Total cold run time: 254123 ms
Total hot run time: 168799 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4135811553
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4142327736
# FE UT Coverage Report
Increment line coverage ` 37.50% (144/384)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61398_34b071b133fdfa89a067848b0e4774fd523d2cba/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61398_34b071b133fdfa89a067848b0e4774fd523d2cba/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4140235745
<details>
<summary>TPC-DS: <b>Total hot run time: 168453 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 80b69a374fe5e7cda0d9b1b407e00bd2c16dc564, data reload: false
query5 4321 630 492 492
query6 337 220 202 202
query7 4220 468 263 263
query8 330 240 227 227
query9 8712 2694 2685 2685
query10 532 384 338 338
query11 6998 5099 4868 4868
query12 184 129 121 121
query13 1283 479 331 331
query14 5766 3632 3401 3401
query14_1 2822 2794 2815 2794
query15 209 194 173 173
query16 963 468 449 449
query17 865 699 629 629
query18 2421 445 341 341
query19 222 201 175 175
query20 136 124 131 124
query21 230 136 111 111
query22 13256 13895 14637 13895
query23 16583 16236 16046 16046
query23_1 16343 16026 15665 15665
query24 7190 1626 1223 1223
query24_1 1248 1213 1246 1213
query25 582 483 441 441
query26 1234 267 155 155
query27 2781 485 305 305
query28 4495 1867 1828 1828
query29 856 591 510 510
query30 301 228 192 192
query31 1017 949 880 880
query32 86 77 71 71
query33 521 352 310 310
query34 902 881 512 512
query35 655 696 618 618
query36 1144 1090 986 986
query37 140 98 84 84
query38 2953 2915 2874 2874
query39 859 828 812 812
query39_1 794 793 793 793
query40 243 154 141 141
query41 68 68 64 64
query42 267 262 257 257
query43 241 263 213 213
query44
query45 201 189 185 185
query46 892 986 601 601
query47 2145 2146 2056 2056
query48 311 322 225 225
query49 631 447 377 377
query50 685 273 230 230
query51 4159 4092 4014 4014
query52 258 263 265 263
query53 297 332 276 276
query54 293 268 268 268
query55 94 91 81 81
query56 299 324 309 309
query57 1846 1881 1770 1770
query58 280 266 265 265
query59 2799 2949 2756 2756
query60 327 333 324 324
query61 149 149 148 148
query62 631 593 532 532
query63 305 275 277 275
query64 5026 1308 1002 1002
query65
query66 1455 459 350 350
query67 24323 24537 24211 24211
query68
query69 398 300 282 282
query70 925 877 956 877
query71 330 312 292 292
query72 2803 2841 2445 2445
query73 536 541 312 312
query74 9613 9595 9318 9318
query75 2833 2734 2447 2447
query76 2275 1025 663 663
query77 372 369 309 309
query78 10945 11130 10476 10476
query79 1117 764 578 578
query80 689 607 533 533
query81 479 260 226 226
query82 1308 164 122 122
query83 365 258 242 242
query84 299 124 98 98
query85 868 505 442 442
query86 389 310 297 297
query87 3211 3123 3049 3049
query88 3519 2643 2634 2634
query89 416 363 353 353
query90 1972 182 184 182
query91 177 171 139 139
query92 83 72 75 72
query93 915 865 495 495
query94 470 322 300 300
query95 595 404 315 315
query96 654 522 230 230
query97 2455 2502 2395 2395
query98 232 224 230 224
query99 999 993 913 913
Total cold run time: 248974 ms
Total hot run time: 168453 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4144971085
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61398_8146b07dbf367e0f583dd41df1ac525f3b27e491_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61398_8146b07dbf367e0f583dd41df1ac525f3b27e491_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.83% (26534/36939) |
| Line Coverage | 54.70% (280040/511970) |
| Region Coverage | 51.91% (232534/447997) |
| Branch Coverage | 53.32% (100486/188446) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4144538867
# FE UT Coverage Report
Increment line coverage ` 44.70% (177/396)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61398_8146b07dbf367e0f583dd41df1ac525f3b27e491/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61398_8146b07dbf367e0f583dd41df1ac525f3b27e491/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4146869017
<details>
<summary>TPC-DS: <b>Total hot run time: 168722 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c7653223cc9ce26ef0ab46b4743228b8a577bbf1, data reload: false
query5 4331 632 509 509
query6 332 221 196 196
query7 4211 473 261 261
query8 342 254 233 233
query9 8740 2723 2730 2723
query10 495 427 340 340
query11 7014 5102 4879 4879
query12 173 129 125 125
query13 1287 466 353 353
query14 5782 3751 3454 3454
query14_1 2873 2865 2853 2853
query15 207 198 174 174
query16 1004 492 453 453
query17 1137 735 634 634
query18 2451 455 357 357
query19 221 216 188 188
query20 135 127 127 127
query21 214 133 112 112
query22 13226 14106 14636 14106
query23 16874 16272 16005 16005
query23_1 16168 16011 15575 15575
query24 7256 1608 1204 1204
query24_1 1247 1212 1228 1212
query25 543 493 408 408
query26 1242 260 148 148
query27 2783 478 300 300
query28 4463 1858 1824 1824
query29 871 558 482 482
query30 289 228 188 188
query31 1001 946 874 874
query32 84 69 71 69
query33 504 336 299 299
query34 884 877 510 510
query35 629 681 594 594
query36 1064 1174 1024 1024
query37 132 94 85 85
query38 2992 2849 2890 2849
query39 847 830 796 796
query39_1 794 793 813 793
query40 246 188 134 134
query41 61 61 60 60
query42 264 265 265 265
query43 239 250 220 220
query44
query45 190 186 180 180
query46 881 986 607 607
query47 2097 2113 2068 2068
query48 308 317 227 227
query49 632 454 385 385
query50 688 281 214 214
query51 4083 4081 3986 3986
query52 261 265 250 250
query53 293 334 284 284
query54 312 270 263 263
query55 90 86 88 86
query56 310 323 317 317
query57 1922 1648 1632 1632
query58 284 272 294 272
query59 2791 2926 2720 2720
query60 346 323 315 315
query61 149 148 153 148
query62 629 593 524 524
query63 308 277 276 276
query64 5147 1299 983 983
query65
query66 1470 453 357 357
query67 24193 24221 24253 24221
query68
query69 412 316 289 289
query70 980 946 902 902
query71 342 322 301 301
query72 2771 2671 2424 2424
query73 551 545 309 309
query74 9629 9536 9409 9409
query75 2869 2769 2479 2479
query76 2300 1064 688 688
query77 358 380 322 322
query78 10904 11123 10447 10447
query79 1101 780 565 565
query80 834 631 588 588
query81 509 257 230 230
query82 1318 165 129 129
query83 355 273 254 254
query84 255 119 106 106
query85 964 568 532 532
query86 393 306 325 306
query87 3184 3171 3028 3028
query88 3526 2657 2697 2657
query89 432 372 345 345
query90 1894 184 171 171
query91 179 218 150 150
query92 82 77 71 71
query93 919 850 512 512
query94 508 318 303 303
query95 578 345 386 345
query96 644 519 222 222
query97 2438 2497 2401 2401
query98 261 223 225 223
query99 980 980 876 876
Total cold run time: 249967 ms
Total hot run time: 168722 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4147317000
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c7653223cc9ce26ef0ab46b4743228b8a577bbf1_c7653223cc9ce26ef0ab46b4743228b8a577bbf1/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c7653223cc9ce26ef0ab46b4743228b8a577bbf1_c7653223cc9ce26ef0ab46b4743228b8a577bbf1/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.88% (19947/37719) |
| Line Coverage | 36.42% (187038/513533) |
| Region Coverage | 32.66% (144950/443869) |
| Branch Coverage | 33.85% (63600/187872) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4140186591
<details>
<summary>TPC-H: <b>Total hot run time: 26996 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 80b69a374fe5e7cda0d9b1b407e00bd2c16dc564, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17644 4517 4380 4380
q2 q3 10741 810 537 537
q4 4721 363 250 250
q5 8198 1218 1027 1027
q6 244 172 146 146
q7 828 847 678 678
q8 10692 1495 1379 1379
q9 6932 4786 4794 4786
q10 6318 1957 1642 1642
q11 466 257 239 239
q12 720 588 454 454
q13 18073 2777 1969 1969
q14 228 237 211 211
q15 q16 730 745 686 686
q17 728 838 458 458
q18 5930 5524 5312 5312
q19 1105 985 648 648
q20 537 487 375 375
q21 4706 2050 1546 1546
q22 407 327 273 273
Total cold run time: 99948 ms
Total hot run time: 26996 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4757 4691 4596 4596
q2 q3 3864 4384 3869 3869
q4 919 1201 780 780
q5 4092 4433 4351 4351
q6 181 178 144 144
q7 1772 1681 1572 1572
q8 2557 2725 2600 2600
q9 7571 7443 7602 7443
q10 3773 4027 3568 3568
q11 496 438 416 416
q12 479 588 485 485
q13 2763 2936 2122 2122
q14 282 323 296 296
q15 q16 754 764 735 735
q17 1196 1406 1338 1338
q18 7208 6829 6670 6670
q19 906 915 957 915
q20 2079 2181 2034 2034
q21 3947 3486 3313 3313
q22 448 510 439 439
Total cold run time: 50044 ms
Total hot run time: 47686 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4147652925
<details>
<summary>TPC-DS: <b>Total hot run time: 168696 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2c4034f5c60782aef64c1bb6116f0ffb72c36c81, data reload: false
query5 4336 640 507 507
query6 335 225 201 201
query7 4241 486 262 262
query8 363 268 232 232
query9 8705 2693 2699 2693
query10 539 418 353 353
query11 6959 5109 4862 4862
query12 184 142 127 127
query13 1272 455 357 357
query14 5752 3689 3436 3436
query14_1 2863 2823 2775 2775
query15 202 193 176 176
query16 1021 452 479 452
query17 1135 721 652 652
query18 2470 456 359 359
query19 217 221 185 185
query20 133 125 125 125
query21 216 135 110 110
query22 13206 14062 14573 14062
query23 16591 16220 16130 16130
query23_1 16229 15658 15773 15658
query24 7240 1598 1210 1210
query24_1 1221 1235 1233 1233
query25 572 458 402 402
query26 1254 265 160 160
query27 2756 473 293 293
query28 4448 1817 1855 1817
query29 820 568 477 477
query30 299 227 191 191
query31 1005 958 874 874
query32 85 69 71 69
query33 515 339 283 283
query34 874 874 524 524
query35 645 670 582 582
query36 1049 1126 926 926
query37 141 102 82 82
query38 3038 2918 2870 2870
query39 844 809 823 809
query39_1 806 801 807 801
query40 228 150 130 130
query41 61 60 72 60
query42 263 254 253 253
query43 234 248 220 220
query44
query45 195 190 179 179
query46 883 982 596 596
query47 2137 2158 2076 2076
query48 311 312 234 234
query49 618 458 388 388
query50 703 269 218 218
query51 4231 3963 4093 3963
query52 266 266 248 248
query53 288 329 279 279
query54 306 282 262 262
query55 89 87 83 83
query56 320 309 297 297
query57 1938 1725 1679 1679
query58 287 277 264 264
query59 2793 2939 2731 2731
query60 338 355 332 332
query61 156 159 157 157
query62 635 586 549 549
query63 307 277 272 272
query64 5060 1293 1019 1019
query65
query66 1453 451 364 364
query67 24250 24251 24097 24097
query68
query69 404 323 278 278
query70 974 978 941 941
query71 331 316 278 278
query72 2866 2645 2469 2469
query73 554 552 312 312
query74 9604 9551 9408 9408
query75 2860 2788 2453 2453
query76 2229 1025 680 680
query77 367 369 301 301
query78 10924 11073 10467 10467
query79 1176 764 570 570
query80 1349 669 615 615
query81 546 268 225 225
query82 994 157 126 126
query83 342 275 256 256
query84 261 133 110 110
query85 998 580 529 529
query86 417 294 331 294
query87 3119 3099 3019 3019
query88 3571 2706 2654 2654
query89 422 377 340 340
query90 1950 190 180 180
query91 168 164 143 143
query92 74 72 73 72
query93 1015 854 498 498
query94 644 311 275 275
query95 593 332 322 322
query96 657 511 231 231
query97 2443 2503 2426 2426
query98 233 219 226 219
query99 1001 994 923 923
Total cold run time: 250471 ms
Total hot run time: 168696 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4149477392
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4139574980
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4142109491
<details>
<summary>TPC-DS: <b>Total hot run time: 168285 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 34b071b133fdfa89a067848b0e4774fd523d2cba, data reload: false
query5 4329 622 495 495
query6 336 233 206 206
query7 4215 473 270 270
query8 333 238 217 217
query9 8744 2724 2688 2688
query10 530 389 339 339
query11 6969 5123 4863 4863
query12 190 131 125 125
query13 1301 467 349 349
query14 5666 3662 3460 3460
query14_1 2844 2864 2882 2864
query15 212 200 177 177
query16 971 468 472 468
query17 1028 745 621 621
query18 2465 455 361 361
query19 225 215 189 189
query20 136 126 125 125
query21 216 143 117 117
query22 13151 13520 13136 13136
query23 16147 15910 16268 15910
query23_1 16280 16395 15952 15952
query24 7817 1769 1291 1291
query24_1 1277 1269 1292 1269
query25 534 454 405 405
query26 1243 260 146 146
query27 2791 483 298 298
query28 4525 1832 1806 1806
query29 824 555 473 473
query30 304 230 188 188
query31 1011 944 882 882
query32 81 70 75 70
query33 520 337 288 288
query34 889 869 526 526
query35 639 690 594 594
query36 1059 1154 987 987
query37 133 98 84 84
query38 2947 2892 2858 2858
query39 855 875 800 800
query39_1 791 802 785 785
query40 240 155 137 137
query41 68 59 62 59
query42 260 255 257 255
query43 240 249 224 224
query44
query45 197 189 180 180
query46 885 971 613 613
query47 2131 2137 2042 2042
query48 300 326 223 223
query49 639 464 389 389
query50 708 277 220 220
query51 4065 4060 4017 4017
query52 261 270 254 254
query53 291 339 291 291
query54 303 280 266 266
query55 100 88 84 84
query56 316 330 313 313
query57 1913 1798 1767 1767
query58 285 271 272 271
query59 2800 2966 2770 2770
query60 342 324 326 324
query61 161 155 147 147
query62 638 596 536 536
query63 305 285 283 283
query64 4999 1276 1010 1010
query65
query66 1456 481 363 363
query67 24220 24285 24166 24166
query68
query69 408 310 287 287
query70 904 972 903 903
query71 345 308 296 296
query72 2846 2663 2481 2481
query73 543 540 316 316
query74 9681 9584 9413 9413
query75 2854 2786 2450 2450
query76 2346 1047 680 680
query77 367 387 313 313
query78 11067 11188 10486 10486
query79 1115 767 571 571
query80 1364 621 551 551
query81 553 263 218 218
query82 1031 151 119 119
query83 373 263 249 249
query84 271 118 96 96
query85 1055 500 452 452
query86 420 320 302 302
query87 3127 3106 3026 3026
query88 3619 2672 2656 2656
query89 428 377 344 344
query90 1911 183 183 183
query91 175 164 140 140
query92 82 79 74 74
query93 950 876 507 507
query94 657 342 312 312
query95 607 350 325 325
query96 655 519 230 230
query97 2460 2495 2405 2405
query98 236 220 217 217
query99 1007 996 926 926
Total cold run time: 250526 ms
Total hot run time: 168285 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4140803563
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/775cdf64483456de9136370f326fb091c7c261cb_775cdf64483456de9136370f326fb091c7c261cb_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/775cdf64483456de9136370f326fb091c7c261cb_775cdf64483456de9136370f326fb091c7c261cb_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.67% (1796/2283) |
| Line Coverage | 64.42% (32291/50128) |
| Region Coverage | 65.28% (16163/24761) |
| Branch Coverage | 55.73% (8612/15454) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4144515392
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/8146b07dbf367e0f583dd41df1ac525f3b27e491_8146b07dbf367e0f583dd41df1ac525f3b27e491/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/8146b07dbf367e0f583dd41df1ac525f3b27e491_8146b07dbf367e0f583dd41df1ac525f3b27e491/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.88% (19947/37719) |
| Line Coverage | 36.41% (186979/513527) |
| Region Coverage | 32.65% (144909/443877) |
| Branch Coverage | 33.84% (63579/187880) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4144126580
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4140652067
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4141013198
<details>
<summary>TPC-DS: <b>Total hot run time: 169177 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 775cdf64483456de9136370f326fb091c7c261cb, data reload: false
query5 4337 648 515 515
query6 334 231 204 204
query7 4222 474 268 268
query8 338 240 240 240
query9 8751 2739 2760 2739
query10 502 399 348 348
query11 7062 5116 4875 4875
query12 185 130 125 125
query13 1289 462 363 363
query14 5776 3665 3530 3530
query14_1 2854 2856 2840 2840
query15 206 197 176 176
query16 1028 489 461 461
query17 1113 735 632 632
query18 2466 472 360 360
query19 217 222 191 191
query20 134 128 128 128
query21 211 143 113 113
query22 13266 14173 14623 14173
query23 16592 16295 15947 15947
query23_1 16137 15689 15683 15683
query24 7146 1621 1230 1230
query24_1 1251 1250 1304 1250
query25 549 461 406 406
query26 1237 263 146 146
query27 2794 476 292 292
query28 4492 1858 1851 1851
query29 841 576 491 491
query30 307 227 193 193
query31 1021 960 870 870
query32 84 75 70 70
query33 505 336 291 291
query34 924 872 542 542
query35 634 681 606 606
query36 1110 1121 924 924
query37 143 100 84 84
query38 2911 2874 2949 2874
query39 858 825 796 796
query39_1 796 785 806 785
query40 228 155 135 135
query41 63 60 60 60
query42 259 250 251 250
query43 240 251 216 216
query44
query45 198 189 186 186
query46 888 983 619 619
query47 2124 2113 2484 2113
query48 336 325 240 240
query49 634 474 383 383
query50 719 293 217 217
query51 4079 4073 4003 4003
query52 260 266 255 255
query53 299 343 286 286
query54 305 266 273 266
query55 89 91 83 83
query56 328 347 316 316
query57 1940 1791 1686 1686
query58 284 276 276 276
query59 2790 2928 2786 2786
query60 338 347 328 328
query61 154 155 154 154
query62 647 592 540 540
query63 317 284 279 279
query64 5063 1282 1014 1014
query65
query66 1473 463 354 354
query67 24193 24283 24233 24233
query68
query69 394 317 284 284
query70 959 913 938 913
query71 347 309 297 297
query72 2713 2608 2454 2454
query73 541 548 321 321
query74 9587 9526 9402 9402
query75 2865 2789 2484 2484
query76 2273 1034 672 672
query77 353 375 307 307
query78 11002 11185 10439 10439
query79 1160 755 587 587
query80 1331 637 583 583
query81 555 262 226 226
query82 1289 161 123 123
query83 331 266 246 246
query84 252 115 96 96
query85 896 511 441 441
query86 422 312 283 283
query87 3159 3085 2981 2981
query88 3585 2666 2667 2666
query89 433 373 360 360
query90 2012 180 180 180
query91 173 169 131 131
query92 80 76 73 73
query93 935 859 513 513
query94 649 325 304 304
query95 589 348 315 315
query96 653 521 230 230
query97 2447 2488 2391 2391
query98 243 223 228 223
query99 1014 987 925 925
Total cold run time: 250719 ms
Total hot run time: 169177 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #61398:
URL: https://github.com/apache/doris/pull/61398#discussion_r2998644467
##########
be/src/exec/scan/file_scanner.cpp:
##########
@@ -1697,6 +1716,14 @@ Status FileScanner::_init_expr_ctxes() {
continue;
}
+ if (it->second->col_name().starts_with(IcebergTableReader::ROW_LINEAGE_ROW_ID)) {
+ _row_lineage_columns.row_id_column_idx = _default_val_row_desc->get_column_id(slot_id);
+ }
+
+ if (it->second->col_name().starts_with(IcebergTableReader::ROW_LINEAGE_LAST_UPDATED_SEQ_NUMBER)) {
Review Comment:
**[Minor]** `starts_with(IcebergTableReader::ROW_LINEAGE_ROW_ID)` should be an exact match (`==`) instead. The constant is `"_row_id"`, and `starts_with` would incorrectly match any column name that begins with `_row_id` (e.g., `_row_id_backup`). The adjacent code uses exact match for `BeConsts::ICEBERG_ROWID_COL`; this should be consistent.
Same applies to the `starts_with(IcebergTableReader::ROW_LINEAGE_LAST_UPDATED_SEQ_NUMBER)` check 4 lines below.
```cpp
if (it->second->col_name() == IcebergTableReader::ROW_LINEAGE_ROW_ID) {
_row_lineage_columns.row_id_column_idx = _default_val_row_desc->get_column_id(slot_id);
}
if (it->second->col_name() == IcebergTableReader::ROW_LINEAGE_LAST_UPDATED_SEQ_NUMBER) {
_row_lineage_columns.last_updated_sequence_number_column_idx = ...
}
```
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/helper/IcebergRewritableDeletePlanner.java:
##########
@@ -0,0 +1,86 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.datasource.iceberg.helper;
+
+import org.apache.doris.common.UserException;
+import org.apache.doris.datasource.iceberg.IcebergExternalTable;
+import org.apache.doris.datasource.iceberg.IcebergUtils;
+import org.apache.doris.datasource.iceberg.source.IcebergScanNode;
+import org.apache.doris.nereids.NereidsPlanner;
+import org.apache.doris.planner.ScanNode;
+import org.apache.doris.thrift.TIcebergRewritableDeleteFileSet;
+
+import org.apache.iceberg.DeleteFile;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+public final class IcebergRewritableDeletePlanner {
+ private static final int ICEBERG_DELETION_VECTOR_MIN_VERSION = 3;
+
+ private IcebergRewritableDeletePlanner() {
+ }
+
+ public static IcebergRewritableDeletePlan collectForDelete(
+ IcebergExternalTable table, NereidsPlanner planner) throws UserException {
+ return collect(table, planner);
+ }
+
+ public static IcebergRewritableDeletePlan collectForMerge(
+ IcebergExternalTable table, NereidsPlanner planner) throws UserException {
+ return collect(table, planner);
+ }
+
+ private static IcebergRewritableDeletePlan collect(
+ IcebergExternalTable table, NereidsPlanner planner) {
+ if (table == null
+ || planner == null
+ || IcebergUtils.getFormatVersion(table.getIcebergTable()) < ICEBERG_DELETION_VECTOR_MIN_VERSION) {
+ return IcebergRewritableDeletePlan.empty();
+ }
+
+ List<TIcebergRewritableDeleteFileSet> thriftDeleteFileSets = new ArrayList<>();
+ Map<String, List<DeleteFile>> deleteFilesByReferencedDataFile = new LinkedHashMap<>();
+
+ for (ScanNode scanNode : planner.getScanNodes()) {
+ if (!(scanNode instanceof IcebergScanNode)) {
+ continue;
+ }
+ IcebergScanNode icebergScanNode = (IcebergScanNode) scanNode;
+
+ deleteFilesByReferencedDataFile.putAll(icebergScanNode.deleteFilesByReferencedDataFile);
+ icebergScanNode.deleteFilesDescByReferencedDataFile.forEach(
+ (key, value) -> {
+ TIcebergRewritableDeleteFileSet deleteFileSet = new TIcebergRewritableDeleteFileSet();
+ deleteFileSet.setReferencedDataFilePath(key);
+ thriftDeleteFileSets.add(deleteFileSet);
Review Comment:
**[Critical Bug]** `setDeleteFiles(value)` is never called on `deleteFileSet`. The lambda captures `(key, value)` from `deleteFilesDescByReferencedDataFile` but only uses `key` — `value` (the `List<TIcebergDeleteFileDesc>`) is silently discarded.
On the BE side (`viceberg_delete_sink.cpp:174`), the code skips entries where `!delete_file_set.__isset.delete_files`, so all rewritable entries are effectively no-ops. This means when a second DELETE hits a data file that already has deletion vectors, the previous deletes are **not merged** into the new DV, causing those previously deleted rows to reappear.
Fix:
```java
icebergScanNode.deleteFilesDescByReferencedDataFile.forEach(
(key, value) -> {
TIcebergRewritableDeleteFileSet deleteFileSet = new TIcebergRewritableDeleteFileSet();
deleteFileSet.setReferencedDataFilePath(key);
deleteFileSet.setDeleteFiles(value); // <-- missing line
thriftDeleteFileSets.add(deleteFileSet);
}
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4139887984
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/80b69a374fe5e7cda0d9b1b407e00bd2c16dc564_80b69a374fe5e7cda0d9b1b407e00bd2c16dc564_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/80b69a374fe5e7cda0d9b1b407e00bd2c16dc564_80b69a374fe5e7cda0d9b1b407e00bd2c16dc564_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.67% (1796/2283) |
| Line Coverage | 64.40% (32283/50128) |
| Region Coverage | 65.28% (16165/24761) |
| Branch Coverage | 55.71% (8610/15454) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4146360599
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4146812382
<details>
<summary>TPC-H: <b>Total hot run time: 26990 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c7653223cc9ce26ef0ab46b4743228b8a577bbf1, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17621 4555 4536 4536
q2 q3 10731 812 526 526
q4 4766 363 254 254
q5 8126 1231 1016 1016
q6 222 176 145 145
q7 796 874 663 663
q8 10486 1543 1339 1339
q9 6698 4727 4747 4727
q10 6317 1990 1685 1685
q11 460 253 253 253
q12 752 579 466 466
q13 18028 2713 1939 1939
q14 230 238 213 213
q15 q16 743 737 665 665
q17 741 858 448 448
q18 5965 5418 5279 5279
q19 1107 996 623 623
q20 536 483 384 384
q21 4438 2151 1512 1512
q22 362 361 317 317
Total cold run time: 99125 ms
Total hot run time: 26990 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4752 4511 4585 4511
q2 q3 3925 4399 3863 3863
q4 879 1292 817 817
q5 4123 4461 4356 4356
q6 195 190 145 145
q7 1782 1719 1535 1535
q8 2471 2695 2604 2604
q9 7580 7466 7424 7424
q10 3809 4006 3866 3866
q11 528 441 418 418
q12 472 583 445 445
q13 2553 2921 2085 2085
q14 291 339 279 279
q15 q16 717 769 712 712
q17 1208 1379 1379 1379
q18 7191 6834 6624 6624
q19 938 907 935 907
q20 2082 2135 1988 1988
q21 3955 3525 3437 3437
q22 492 423 398 398
Total cold run time: 49943 ms
Total hot run time: 47793 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4148126875
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61398_2c4034f5c60782aef64c1bb6116f0ffb72c36c81_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61398_2c4034f5c60782aef64c1bb6116f0ffb72c36c81_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.52% (27156/36939) |
| Line Coverage | 57.02% (291948/511982) |
| Region Coverage | 54.35% (243489/447992) |
| Branch Coverage | 56.05% (105621/188442) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4140444465
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4140965834
<details>
<summary>TPC-H: <b>Total hot run time: 26857 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 775cdf64483456de9136370f326fb091c7c261cb, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17631 4496 4307 4307
q2 q3 10711 772 532 532
q4 4713 358 253 253
q5 8002 1228 1011 1011
q6 224 173 151 151
q7 840 860 682 682
q8 10729 1485 1337 1337
q9 6283 4786 4757 4757
q10 6419 1917 1659 1659
q11 458 239 255 239
q12 754 582 471 471
q13 18040 2821 1934 1934
q14 231 234 205 205
q15 q16 753 736 656 656
q17 749 841 447 447
q18 6300 5341 5336 5336
q19 1117 987 630 630
q20 536 497 385 385
q21 4572 2109 1600 1600
q22 367 313 265 265
Total cold run time: 99429 ms
Total hot run time: 26857 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4702 4599 4567 4567
q2 q3 3863 4312 3831 3831
q4 893 1211 825 825
q5 4086 4398 4411 4398
q6 196 180 153 153
q7 1812 1697 1533 1533
q8 2460 2904 2632 2632
q9 7649 7426 7519 7426
q10 3758 4049 3673 3673
q11 522 449 412 412
q12 479 593 454 454
q13 2494 2902 2020 2020
q14 367 422 339 339
q15 q16 722 761 704 704
q17 1191 1387 1417 1387
q18 7203 6834 6614 6614
q19 917 983 917 917
q20 2188 2150 2015 2015
q21 3997 3635 3401 3401
q22 443 417 387 387
Total cold run time: 49942 ms
Total hot run time: 47688 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4136373742
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/8f69d4298de67940a0a0acc8b9b3226deaedb97a_8f69d4298de67940a0a0acc8b9b3226deaedb97a_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/8f69d4298de67940a0a0acc8b9b3226deaedb97a_8f69d4298de67940a0a0acc8b9b3226deaedb97a_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.67% (1796/2283) |
| Line Coverage | 64.41% (32288/50128) |
| Region Coverage | 65.27% (16161/24761) |
| Branch Coverage | 55.75% (8616/15454) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4144375471
<details>
<summary>TPC-H: <b>Total hot run time: 26445 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8146b07dbf367e0f583dd41df1ac525f3b27e491, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17427 4519 4310 4310
q2 q3 10526 795 527 527
q4 4675 351 244 244
q5 7563 1189 1018 1018
q6 173 172 146 146
q7 778 852 675 675
q8 9308 1489 1310 1310
q9 4811 4719 4620 4620
q10 6304 1913 1663 1663
q11 481 272 249 249
q12 707 573 461 461
q13 18031 2704 1921 1921
q14 230 239 216 216
q15 q16 744 736 678 678
q17 746 837 467 467
q18 5788 5321 5271 5271
q19 1125 976 620 620
q20 539 500 384 384
q21 4704 1828 1416 1416
q22 341 296 249 249
Total cold run time: 95001 ms
Total hot run time: 26445 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4954 4686 4610 4610
q2 q3 3840 4335 3793 3793
q4 873 1206 824 824
q5 4065 4396 4302 4302
q6 191 175 142 142
q7 1746 1674 1586 1586
q8 2572 2730 2572 2572
q9 7570 7309 7590 7309
q10 3781 3941 3711 3711
q11 529 462 426 426
q12 512 599 446 446
q13 2460 2872 2001 2001
q14 489 294 283 283
q15 q16 724 776 737 737
q17 1181 1383 1357 1357
q18 7056 6751 6642 6642
q19 930 901 913 901
q20 2090 2141 1990 1990
q21 3954 3443 3354 3354
q22 475 428 375 375
Total cold run time: 49992 ms
Total hot run time: 47361 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4135858898
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4141935414
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4140577828
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/85ccf8bb505863ed87378c3145d99106ff3786e6_85ccf8bb505863ed87378c3145d99106ff3786e6_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/85ccf8bb505863ed87378c3145d99106ff3786e6_85ccf8bb505863ed87378c3145d99106ff3786e6_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.67% (1796/2283) |
| Line Coverage | 64.39% (32276/50128) |
| Region Coverage | 65.26% (16159/24761) |
| Branch Coverage | 55.73% (8613/15454) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4139753439
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Support iceberg v3 row lineage [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4145606905
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4146579944
# FE UT Coverage Report
Increment line coverage ` 44.17% (178/403)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61398_c7653223cc9ce26ef0ab46b4743228b8a577bbf1/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61398_c7653223cc9ce26ef0ab46b4743228b8a577bbf1/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61398:
URL: https://github.com/apache/doris/pull/61398#issuecomment-4147698929
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2c4034f5c60782aef64c1bb6116f0ffb72c36c81_2c4034f5c60782aef64c1bb6116f0ffb72c36c81/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2c4034f5c60782aef64c1bb6116f0ffb72c36c81_2c4034f5c60782aef64c1bb6116f0ffb72c36c81/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.88% (19947/37719) |
| Line Coverage | 36.42% (187023/513539) |
| Region Coverage | 32.63% (144856/443872) |
| Branch Coverage | 33.85% (63592/187876) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](iceberg) Support iceberg v3 row lineage [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #61398:
URL: https://github.com/apache/doris/pull/61398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org