You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/23 19:14:35 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.

Ouss4 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396694958
 
 

 ##########
 File path: tools/sethost.sh
 ##########
 @@ -211,4 +211,9 @@ fi
 sed -i -e "/CONFIG_HOST_OTHER/d" $nuttx/.config
 
 echo "  Refreshing..."
-make olddefconfig $* || { echo "ERROR: failed to refresh"; exit 1; }
+
+if [ ! -z $* ]; then
 
 Review comment:
   To only keep V=1? No other option is useful?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services