You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/12 20:21:08 UTC

[GitHub] [trafficserver] jrushford opened a new issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

jrushford opened a new issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824


   A user inadvertently created an invalid host definition in the strategies.yaml.  When configuring the **scheme** section of a **host** the user added the **port** element as an array field.  The parser allowed this but at runtime, the next hop lookup failed to get the proper port number which caused a runtime assertion failure.
   
   Incorrect YAML:
   `
        protocol:
           - scheme: http
           - port:  80
   `
   
   Correct YAML:
   `
        protocol:
           - scheme: http
              port
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford edited a comment on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford edited a comment on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-840578147


   @ywkaras After parsing the YAML, I think a check for all required settings should catch this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
ywkaras commented on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-880078683


   It seems like we should have seen this note in diags.log:
   
   https://github.com/apache/trafficserver/blob/8a948afc6caafdbd4d28e63b377610f66ee8ea5b/proxy/http/remap/NextHopSelectionStrategy.cc#L76
   
   Seems like we should either default the scheme to NH_SCHEME_HTTP, or call Emergency() rather than Note(), so TS doesn't continue running in unpredictable ways.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford removed a comment on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford removed a comment on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-1084530007






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford commented on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-1084529466


   Fixed with PR #8742 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford commented on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-1084530007


   fixed, PR #8742 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford commented on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-1084531624


   Fixed by PR #8742 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford commented on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-840578147


   After parsing the YAML, I think a check for all required settings should catch this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford commented on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-1084531007


   Fixed by PR #87442


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford removed a comment on issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford removed a comment on issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824#issuecomment-1084531007


   Fixed by PR #87442


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] jrushford closed issue #7824: The strategies.yaml parser can incorrectly interpret the YAML elements in the host protocol.

Posted by GitBox <gi...@apache.org>.
jrushford closed issue #7824:
URL: https://github.com/apache/trafficserver/issues/7824


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org