You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/05 00:35:54 UTC

[GitHub] [mynewt-core] benmccrea opened a new pull request #2471: charge-control: Fix to allow usage of an alternate event queue.

benmccrea opened a new pull request #2471:
URL: https://github.com/apache/mynewt-core/pull/2471


   An alternate event queue can specified for `charger-control` by setting `CHARGE_CONTROL_MGR_EVQ`, but this was resulting in an undeclared identifier compiler error. 
   
   This PR fixes the error by declaring the queue specified by `CHARGE_CONTROL_MGR_EVQ` as `extern struct os_eventq`. 
   
   Note: This fix uses the same approach already used by `hw/sensor` to resolve an externally defined queue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] benmccrea merged pull request #2471: charge-control: Fix to allow usage of an alternate event queue.

Posted by GitBox <gi...@apache.org>.
benmccrea merged pull request #2471:
URL: https://github.com/apache/mynewt-core/pull/2471


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2471: charge-control: Fix to allow usage of an alternate event queue.

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2471:
URL: https://github.com/apache/mynewt-core/pull/2471#issuecomment-773698727


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2471: charge-control: Fix to allow usage of an alternate event queue.

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2471:
URL: https://github.com/apache/mynewt-core/pull/2471#issuecomment-773698727


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org