[jira] [Commented] (NIFI-5535) DataDogReportingTask is not tagging metrics properly

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591575#comment-16591575 ] 

ASF GitHub Bot commented on NIFI-5535:
--------------------------------------

GitHub user snagafritz opened a pull request:

    https://github.com/apache/nifi/pull/2962

    NIFI-5535: fix metric tagging in DataDogReportingTask

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Snagajob/nifi NIFI-5535

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2962
    
----
commit 8b0a9d39fb3f6c75b47c1511329e617cd1467135
Author: Corey Fritz <co...@...>
Date:   2018-08-24T11:34:56Z

    NIFI-5535: Fixed metric tagging in DataDogReportingTask

----


> DataDogReportingTask is not tagging metrics properly
> ----------------------------------------------------
>
>                 Key: NIFI-5535
>                 URL: https://issues.apache.org/jira/browse/NIFI-5535
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.7.1
>            Reporter: Corey Fritz
>            Priority: Major
>         Attachments: Screen Shot 2018-08-19 at 12.33.58 AM.png
>
>
> The current (and looks like original) implementation of the DataDogReportingTask is not applying metric tags correctly, and as a result, the "Environment" configuration property on that task does not work. This means that you're not going to be able to use tags to differentiate the metric values coming from different environments.
> Currently, every metric reported by this task gets the same set of tags applied:
> {code:java}
> connection-destination-id
> connection-destination-name
> connection-group-id
> connection-id
> connection-name
> connection-source-id
> connection-source-name
> dataflow_id
> env
> port-group-id
> port-id
> port-name{code}
> This list is defined here: [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/metrics/MetricsService.java#L111-L126]
> I've attached a screenshot from Datadog demonstrating a JVM metric with all of these tags applied.
> Each of these tags should include a value, i.e. "env:dev" instead of just "env".
> Other observations:
>  * it doesn't make sense to attach the _connection-_ and _port-_ tags to JVM metrics
>  * I'm not sure I see any value in the _dataflow_id_ tag
> I was hoping for a quick fix when I noticed the environment tagging wasn't working, but after reviewing the code I think a not insignificant refactoring will be required. I'll try to tackle this if/when time allows.
> See here for more context on Datadog tagging: [https://docs.datadoghq.com/tagging]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)