You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/11 13:10:30 UTC
[GitHub] [airflow] EricGao888 opened a new pull request, #28858: Fix incorrect comments in worker-kedaautoscaler.yaml
EricGao888 opened a new pull request, #28858:
URL: https://github.com/apache/airflow/pull/28858
Currently, some comments in `worker-kedaautoscaler.yaml` are inconsistent with corresponding default values in `values.yaml`. This PR corrects those comments.
https://github.com/apache/airflow/blob/493b433ad57088a5f5cabc466c949445e500b4c1/chart/templates/workers/worker-kedaautoscaler.yaml#L40-L43
https://github.com/apache/airflow/blob/493b433ad57088a5f5cabc466c949445e500b4c1/chart/values.yaml#L498-L513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #28858: Fix incorrect comments in worker-kedaautoscaler.yaml
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #28858:
URL: https://github.com/apache/airflow/pull/28858#discussion_r1067437956
##########
chart/templates/workers/worker-kedaautoscaler.yaml:
##########
@@ -37,10 +37,10 @@ spec:
scaleTargetRef:
kind: {{ ternary "StatefulSet" "Deployment" .Values.workers.persistence.enabled }}
name: {{ .Release.Name }}-worker
- pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 30 seconds
- cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 300 seconds
+ pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 5 seconds
+ cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 30 seconds
Review Comment:
```suggestion
pollingInterval: {{ .Values.workers.keda.pollingInterval }}
cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }}
```
Let's actually just remove it completely - we don't really do this elsewhere and they are just asking to become out of sync.
##########
chart/templates/workers/worker-kedaautoscaler.yaml:
##########
@@ -37,10 +37,10 @@ spec:
scaleTargetRef:
kind: {{ ternary "StatefulSet" "Deployment" .Values.workers.persistence.enabled }}
name: {{ .Release.Name }}-worker
- pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 30 seconds
- cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 300 seconds
+ pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 5 seconds
+ cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 30 seconds
minReplicaCount: {{ .Values.workers.keda.minReplicaCount }} # Optional. Default: 0
- maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }} # Optional. Default: 100
+ maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }} # Optional. Default: 10
Review Comment:
```suggestion
maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #28858: Fix incorrect comments in worker-kedaautoscaler.yaml
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #28858:
URL: https://github.com/apache/airflow/pull/28858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] EricGao888 commented on a diff in pull request #28858: Fix incorrect comments in worker-kedaautoscaler.yaml
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #28858:
URL: https://github.com/apache/airflow/pull/28858#discussion_r1067672767
##########
chart/templates/workers/worker-kedaautoscaler.yaml:
##########
@@ -37,10 +37,10 @@ spec:
scaleTargetRef:
kind: {{ ternary "StatefulSet" "Deployment" .Values.workers.persistence.enabled }}
name: {{ .Release.Name }}-worker
- pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 30 seconds
- cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 300 seconds
+ pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 5 seconds
+ cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 30 seconds
Review Comment:
Done, thanks for the suggestions : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] EricGao888 closed pull request #28858: Fix incorrect comments in worker-kedaautoscaler.yaml
Posted by GitBox <gi...@apache.org>.
EricGao888 closed pull request #28858: Fix incorrect comments in worker-kedaautoscaler.yaml
URL: https://github.com/apache/airflow/pull/28858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org