[GitHub] [beam] jrmccluskey commented on a diff in pull request #27696: Vertex AI Model Handler Private Endpoint Support

["jrmccluskey (via GitHub)" <gi...@apache.org>]

jrmccluskey commented on code in PR #27696:
URL: https://github.com/apache/beam/pull/27696#discussion_r1276735796


##########
sdks/python/apache_beam/examples/inference/vertex_ai_image_classification.py:
##########
@@ -74,11 +74,24 @@ def parse_known_args(argv):
       type=str,
       required=True,
       help='GCP location for the Endpoint')
+  parser.add_argument(
+      '--endpoint_network',
+      dest='vpc_network',
+      type=str,
+      required=False,
+      help='GCP network the endpoint is peered to')
   parser.add_argument(
       '--experiment',
       dest='experiment',
+      type=str,
       required=False,
       help='GCP experiment to pass to init')

Review Comment:
   I believe the experiment is passing a string to enable this feature - https://cloud.google.com/vertex-ai/docs/experiments/intro-vertex-ai-experiments
   
   I can add the context link here, or I can drop it into the model handler itself. Or both, depending on preference. It's not wholly necessary for the example though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org