You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/11 03:27:28 UTC
[GitHub] [inlong] e-mhui opened a new pull request, #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector
e-mhui opened a new pull request, #6508:
URL: https://github.com/apache/inlong/pull/6508
### Prepare a Pull Request
[INLONG-6507][Sort] Convert date to timestamp in oracle connector
- Fixes #6507
### Motivation
In debezium, the oracle date type will be read as the int64 type, but the oracle date type mapping is the debezium timestamp type, and the debezium timestamp type is the string format of date-time. So, we need to convert the int64 to the string format of date-time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui commented on a diff in pull request #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector
Posted by GitBox <gi...@apache.org>.
e-mhui commented on code in PR #6508:
URL: https://github.com/apache/inlong/pull/6508#discussion_r1021043373
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/debezium/table/RowDataDebeziumDeserializeSchema.java:
##########
@@ -760,33 +760,18 @@ public Object convert(Object dbzObj, Schema schema, TableChange tableSchema) thr
* @return the extracted data with schema
*/
private Object getValueWithSchema(Object fieldValue, String schemaName) {
- if (fieldValue == null) {
- return null;
- }
- // Remove shaded pattern prefix of package name
- schemaName = schemaName.replace(shadedPatternPrefix, "");
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6508:
URL: https://github.com/apache/inlong/pull/6508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector
Posted by GitBox <gi...@apache.org>.
gong commented on PR #6508:
URL: https://github.com/apache/inlong/pull/6508#issuecomment-1311207904
Maybe, PR description is not consistent with modification of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #6508:
URL: https://github.com/apache/inlong/pull/6508#discussion_r1020675510
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/debezium/table/RowDataDebeziumDeserializeSchema.java:
##########
@@ -760,33 +760,18 @@ public Object convert(Object dbzObj, Schema schema, TableChange tableSchema) thr
* @return the extracted data with schema
*/
private Object getValueWithSchema(Object fieldValue, String schemaName) {
- if (fieldValue == null) {
- return null;
- }
- // Remove shaded pattern prefix of package name
- schemaName = schemaName.replace(shadedPatternPrefix, "");
Review Comment:
```java
private static final String shadedPatternPrefix = "org.apache.inlong.sort.cdc.oracle.shaded.";
```
It is not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui commented on pull request #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector
Posted by GitBox <gi...@apache.org>.
e-mhui commented on PR #6508:
URL: https://github.com/apache/inlong/pull/6508#issuecomment-1312336323
> Please check the mysql connector for the date and timestamp data.
Yes, the oracle connector handles date and timestamp data like the mysql connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui commented on pull request #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector
Posted by GitBox <gi...@apache.org>.
e-mhui commented on PR #6508:
URL: https://github.com/apache/inlong/pull/6508#issuecomment-1312353160
> Maybe, PR description is not consistent with modification of code
More details have been added to the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector
Posted by GitBox <gi...@apache.org>.
gong commented on PR #6508:
URL: https://github.com/apache/inlong/pull/6508#issuecomment-1312365664
> > Maybe, PR description is not consistent with modification of code
>
> More details have been added to the PR description.
@e-mhui good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org