You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/30 11:33:16 UTC
Review Request 68568: Added '/roles' to the set of batched master
endpoints.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-9194
https://issues.apache.org/jira/browse/MESOS-9194
Repository: mesos
Description
-------
For improved consistency, the '/roles' endpoint on the
master is now marked as read-only and uses the batching
mechanism shared by the other read-only endpoints.
Diffs
-----
src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
Diff: https://reviews.apache.org/r/68568/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/#review208129
-----------------------------------------------------------
PASS: Mesos patch 68568 was successfully built and tested.
Reviews applied: `['68567', '68568']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2264/mesos-review-68568
- Mesos Reviewbot Windows
On Aug. 30, 2018, 11:33 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 11:33 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9194
> https://issues.apache.org/jira/browse/MESOS-9194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For improved consistency, the '/roles' endpoint on the
> master is now marked as read-only and uses the batching
> mechanism shared by the other read-only endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
> src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
>
>
> Diff: https://reviews.apache.org/r/68568/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/#review208406
-----------------------------------------------------------
Fix it, then Ship it!
src/master/http.cpp
Line 2605 (original), 2562 (patched)
<https://reviews.apache.org/r/68568/#comment292310>
I'll move it to `master.cpp`.
src/master/master.hpp
Lines 1614 (patched)
<https://reviews.apache.org/r/68568/#comment292311>
I think this can be removed now.
- Alexander Rukletsov
On Sept. 5, 2018, 12:18 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2018, 12:18 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9194
> https://issues.apache.org/jira/browse/MESOS-9194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For improved consistency, the '/roles' endpoint on the
> master is now marked as read-only and uses the batching
> mechanism shared by the other read-only endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
> src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
>
>
> Diff: https://reviews.apache.org/r/68568/diff/2/
>
>
> Testing
> -------
>
> Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
>
> For rev. 2, internal CI run #4340.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/#review208355
-----------------------------------------------------------
PASS: Mesos patch 68568 was successfully built and tested.
Reviews applied: `['68567', '68568']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2295/mesos-review-68568
- Mesos Reviewbot Windows
On Sept. 5, 2018, 12:18 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2018, 12:18 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9194
> https://issues.apache.org/jira/browse/MESOS-9194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For improved consistency, the '/roles' endpoint on the
> master is now marked as read-only and uses the batching
> mechanism shared by the other read-only endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
> src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
>
>
> Diff: https://reviews.apache.org/r/68568/diff/2/
>
>
> Testing
> -------
>
> Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
>
> For rev. 2, internal CI run #4340.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/
-----------------------------------------------------------
(Updated Sept. 5, 2018, 12:18 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-9194
https://issues.apache.org/jira/browse/MESOS-9194
Repository: mesos
Description (updated)
-------
For improved consistency, the '/roles' endpoint on the
master is now marked as read-only and uses the batching
mechanism shared by the other read-only endpoints.
Diffs (updated)
-----
src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
Diff: https://reviews.apache.org/r/68568/diff/2/
Changes: https://reviews.apache.org/r/68568/diff/1-2/
Testing
-------
Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
Thanks,
Benno Evers
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/#review208299
-----------------------------------------------------------
src/master/master.hpp
Lines 1611 (patched)
<https://reviews.apache.org/r/68568/#comment292039>
What about moving `_filterRoles` directly to the master? We already have helpers there for roles:
```
bool isWhitelistedRole(const std::string& name) const;
```
and using approvers:
```
process::Future<bool> authorizeLogAccess(
const Option<process::http::authentication::Principal>& principal);
```
src/master/readonly_handler.cpp
Lines 745 (patched)
<https://reviews.apache.org/r/68568/#comment292038>
const
- Alexander Rukletsov
On Sept. 4, 2018, 9:39 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2018, 9:39 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9194
> https://issues.apache.org/jira/browse/MESOS-9194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To improve consistency, the '/roles' endpoint on the
> master is now marked as read-only and uses the batching
> mechanism shared by the other read-only endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
> src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
>
>
> Diff: https://reviews.apache.org/r/68568/diff/1/
>
>
> Testing
> -------
>
> Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/
-----------------------------------------------------------
(Updated Sept. 4, 2018, 9:39 a.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-9194
https://issues.apache.org/jira/browse/MESOS-9194
Repository: mesos
Description (updated)
-------
To improve consistency, the '/roles' endpoint on the
master is now marked as read-only and uses the batching
mechanism shared by the other read-only endpoints.
Diffs
-----
src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
Diff: https://reviews.apache.org/r/68568/diff/1/
Testing
-------
Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
Thanks,
Benno Evers
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/#review208223
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68567, 68568]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 31, 2018, 8:08 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 8:08 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9194
> https://issues.apache.org/jira/browse/MESOS-9194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For improved consistency, the '/roles' endpoint on the
> master is now marked as read-only and uses the batching
> mechanism shared by the other read-only endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
> src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
>
>
> Diff: https://reviews.apache.org/r/68568/diff/1/
>
>
> Testing
> -------
>
> Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/
-----------------------------------------------------------
(Updated Aug. 31, 2018, 3:08 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-9194
https://issues.apache.org/jira/browse/MESOS-9194
Repository: mesos
Description
-------
For improved consistency, the '/roles' endpoint on the
master is now marked as read-only and uses the batching
mechanism shared by the other read-only endpoints.
Diffs
-----
src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
Diff: https://reviews.apache.org/r/68568/diff/1/
Testing (updated)
-------
Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
Thanks,
Benno Evers
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Aug. 30, 2018, 11:34 a.m., Benno Evers wrote:
> > src/master/readonly_handler.cpp
> > Lines 753 (patched)
> > <https://reviews.apache.org/r/68568/diff/1/?file=2079016#file2079016line753>
> >
> > Note that this line had to be changed from `weights[name]` to `weights.at(name)` during copying to make this compile as a const member function.
Thanks for calling this out!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/#review208125
-----------------------------------------------------------
On Sept. 4, 2018, 9:39 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2018, 9:39 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9194
> https://issues.apache.org/jira/browse/MESOS-9194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To improve consistency, the '/roles' endpoint on the
> master is now marked as read-only and uses the batching
> mechanism shared by the other read-only endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
> src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
>
>
> Diff: https://reviews.apache.org/r/68568/diff/1/
>
>
> Testing
> -------
>
> Successful internal CI run executing `make check` on several platforms. (Jenkins id #4290)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68568: Added '/roles' to the set of batched master
endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68568/#review208125
-----------------------------------------------------------
src/master/readonly_handler.cpp
Lines 753 (patched)
<https://reviews.apache.org/r/68568/#comment291898>
Note that this line had to be changed from `weights[name]` to `weights.at(name)` during copying to make this compile as a const member function.
- Benno Evers
On Aug. 30, 2018, 11:33 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 11:33 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9194
> https://issues.apache.org/jira/browse/MESOS-9194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For improved consistency, the '/roles' endpoint on the
> master is now marked as read-only and uses the batching
> mechanism shared by the other read-only endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
> src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069
>
>
> Diff: https://reviews.apache.org/r/68568/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>