You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by trkurc <gi...@git.apache.org> on 2016/02/14 04:38:02 UTC
[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/221
NIFI-1513: fixed some easy to fix errors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc/nifi NIFI-1513
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #221
----
commit 17a3ba56a9e6a5a611e5ee0282dec4c01baa4fde
Author: Tony Kurc <tr...@gmail.com>
Date: 2016-02-14T03:37:10Z
NIFI-1513: fixed some easy to fix errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/221#issuecomment-188962296
I additionally addressed some whitespaces at the end of lines causing contrib-check to fail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/221#issuecomment-188847619
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/221#discussion_r52837465
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java ---
@@ -426,60 +423,65 @@ public void onTrigger(final ProcessContext context, final ProcessSessionFactory
if (accept != null) {
get.addHeader(HEADER_ACCEPT, accept);
}
+ // create the http client
+ try ( final CloseableHttpClient client = clientBuilder.build() ) {
+ // NOTE: including this inner try in order to swallow exceptions on close
+ try {
--- End diff --
Holy smokes, this got butchered, it should just be an indentation of that try block
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/221#discussion_r54095802
--- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/bin/Bin.java ---
@@ -121,8 +125,9 @@ public boolean offer(final FlowFile flowFile, final ProcessSession session) {
final String countValue = flowFile.getAttribute(fileCountAttribute);
final Integer count = toInteger(countValue);
if (count != null) {
- this.maximumEntries = Math.min(count, this.maximumEntries);
- this.minimumEntries = this.maximumEntries;
+ int currentMaxEntries = this.maximumEntries;
+ this.maximumEntries = Math.min(count, currentMaxEntries);
+ this.minimumEntries = currentMaxEntries;
--- End diff --
Not sure why it was necessary (other then style), but overall PR looks good.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---