[GitHub] [flink] fpompermaier commented on a change in pull request #12036: [FLINK-17537][connectors / jdbc] Refactor flink-jdbc connector structure

[GitBox <gi...@apache.org>]

fpompermaier commented on a change in pull request #12036:
URL: https://github.com/apache/flink/pull/12036#discussion_r422124179



##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialects.java
##########
@@ -39,27 +39,27 @@
 /**
  * Default JDBC dialects.
  */
-public final class JDBCDialects {
+public class JdbcDialects {

Review comment:
       And what about moving each dialect in its own class (instead of having all the implementation insidide this class)? Or better: why don't load them via SPI (so we could support more dialects just adding external jars to Flink lib directory without requiring to have them in the official jdbc connector code)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org