You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/22 18:15:15 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #11835: [microTVM][CMSIS] Add CMSIS libraries/sources to Zephyr CMake file
mehrdadh opened a new pull request, #11835:
URL: https://github.com/apache/tvm/pull/11835
cc @gromero @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11835: [microTVM][CMSIS] Add CMSIS libraries/sources to Zephyr CMake file
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11835:
URL: https://github.com/apache/tvm/pull/11835#discussion_r904260094
##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -508,18 +521,18 @@ def generate_project(self, model_library_format_path, standalone_crt_dir, projec
cmake_f.write(f"target_compile_definitions(app PUBLIC {item})\n")
# Include CMSIS libraries if required.
- if self._cmsis_required(extract_path):
- cmsis_path = get_cmsis_path(options)
- cmake_f.write("\n")
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "DSP" / "Include")})\n'
- )
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "DSP" / "Include" / "dsp")})\n'
- )
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "NN" / "Include")})\n'
- )
+ # if self._cmsis_required(extract_path):
Review Comment:
shoot, that's my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11835: [microTVM][CMSIS] Add CMSIS libraries/sources to Zephyr CMake file
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11835:
URL: https://github.com/apache/tvm/pull/11835#discussion_r904232425
##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -508,18 +521,18 @@ def generate_project(self, model_library_format_path, standalone_crt_dir, projec
cmake_f.write(f"target_compile_definitions(app PUBLIC {item})\n")
# Include CMSIS libraries if required.
- if self._cmsis_required(extract_path):
- cmsis_path = get_cmsis_path(options)
- cmake_f.write("\n")
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "DSP" / "Include")})\n'
- )
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "DSP" / "Include" / "dsp")})\n'
- )
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "NN" / "Include")})\n'
- )
+ # if self._cmsis_required(extract_path):
Review Comment:
how come we comment vs rm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #11835: [microTVM][CMSIS] Add CMSIS libraries/sources to Zephyr CMake file
Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #11835:
URL: https://github.com/apache/tvm/pull/11835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11835: [microTVM][CMSIS] Add CMSIS libraries/sources to Zephyr CMake file
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11835:
URL: https://github.com/apache/tvm/pull/11835#discussion_r904267410
##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -508,18 +521,18 @@ def generate_project(self, model_library_format_path, standalone_crt_dir, projec
cmake_f.write(f"target_compile_definitions(app PUBLIC {item})\n")
# Include CMSIS libraries if required.
- if self._cmsis_required(extract_path):
- cmsis_path = get_cmsis_path(options)
- cmake_f.write("\n")
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "DSP" / "Include")})\n'
- )
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "DSP" / "Include" / "dsp")})\n'
- )
- cmake_f.write(
- f'target_include_directories(tvm_model PRIVATE {str(cmsis_path / "CMSIS" / "NN" / "Include")})\n'
- )
+ # if self._cmsis_required(extract_path):
Review Comment:
removed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org