You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/20 14:02:26 UTC
[GitHub] [inlong] Oneal65 opened a new pull request, #5966: [INLONG-5943][Sort] Add metric state for JDBC
Oneal65 opened a new pull request, #5966:
URL: https://github.com/apache/inlong/pull/5966
- Fixes #5943
### Motivation
Add metric state for JDBC
### Modifications
JDBC connector
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #5966: [INLONG-5943][Sort] Add metric state for JDBC
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5966:
URL: https://github.com/apache/inlong/pull/5966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5966: [INLONG-5943][Sort] Add metric state for JDBC
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5966:
URL: https://github.com/apache/inlong/pull/5966#discussion_r975973458
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/AbstractJdbcOutputFormat.java:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.jdbc.internal;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.api.common.io.RichOutputFormat;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.jdbc.internal.connection.JdbcConnectionProvider;
+import org.apache.flink.runtime.state.FunctionInitializationContext;
+import org.apache.flink.runtime.state.FunctionSnapshotContext;
+import org.apache.flink.util.Preconditions;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Flushable;
+import java.io.IOException;
+import java.sql.Connection;
+
+/** Base jdbc outputFormat. */
+public abstract class AbstractJdbcOutputFormat<T> extends RichOutputFormat<T> implements Flushable {
+
+ private static final long serialVersionUID = 1L;
+ public static final int DEFAULT_FLUSH_MAX_SIZE = 5000;
+ public static final long DEFAULT_FLUSH_INTERVAL_MILLS = 0L;
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ org.apache.flink.connector.jdbc.internal.AbstractJdbcOutputFormat.class);
+ protected final JdbcConnectionProvider connectionProvider;
+
+ public AbstractJdbcOutputFormat(JdbcConnectionProvider connectionProvider) {
+ this.connectionProvider = Preconditions.checkNotNull(connectionProvider);
+ }
+
+ @Override
+ public void configure(Configuration parameters) {
+
+ }
+
+ @Override
+ public void open(int taskNumber, int numTasks) throws IOException {
+ try {
+ connectionProvider.getOrEstablishConnection();
+ } catch (Exception e) {
+ throw new IOException("unable to open JDBC writer", e);
+ }
+ }
+
+ @Override
+ public void close() {
+ connectionProvider.closeConnection();
+ }
+
+ @Override
+ public void flush() throws IOException {
+
+ }
+
+ @VisibleForTesting
+ public Connection getConnection() {
+ return connectionProvider.getConnection();
+ }
+
+ public void snapshotState(FunctionSnapshotContext context) throws Exception {
Review Comment:
Does it need to be declared as abstract method?
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/AbstractJdbcOutputFormat.java:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.jdbc.internal;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.api.common.io.RichOutputFormat;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.jdbc.internal.connection.JdbcConnectionProvider;
+import org.apache.flink.runtime.state.FunctionInitializationContext;
+import org.apache.flink.runtime.state.FunctionSnapshotContext;
+import org.apache.flink.util.Preconditions;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Flushable;
+import java.io.IOException;
+import java.sql.Connection;
+
+/** Base jdbc outputFormat. */
+public abstract class AbstractJdbcOutputFormat<T> extends RichOutputFormat<T> implements Flushable {
+
+ private static final long serialVersionUID = 1L;
+ public static final int DEFAULT_FLUSH_MAX_SIZE = 5000;
+ public static final long DEFAULT_FLUSH_INTERVAL_MILLS = 0L;
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ org.apache.flink.connector.jdbc.internal.AbstractJdbcOutputFormat.class);
+ protected final JdbcConnectionProvider connectionProvider;
+
+ public AbstractJdbcOutputFormat(JdbcConnectionProvider connectionProvider) {
+ this.connectionProvider = Preconditions.checkNotNull(connectionProvider);
+ }
+
+ @Override
+ public void configure(Configuration parameters) {
+
+ }
+
+ @Override
+ public void open(int taskNumber, int numTasks) throws IOException {
+ try {
+ connectionProvider.getOrEstablishConnection();
+ } catch (Exception e) {
+ throw new IOException("unable to open JDBC writer", e);
+ }
+ }
+
+ @Override
+ public void close() {
+ connectionProvider.closeConnection();
+ }
+
+ @Override
+ public void flush() throws IOException {
+
+ }
+
+ @VisibleForTesting
+ public Connection getConnection() {
+ return connectionProvider.getConnection();
+ }
+
+ public void snapshotState(FunctionSnapshotContext context) throws Exception {
Review Comment:
Does it need to be declared as an abstract method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Oneal65 commented on a diff in pull request #5966: [INLONG-5943][Sort] Add metric state for JDBC
Posted by GitBox <gi...@apache.org>.
Oneal65 commented on code in PR #5966:
URL: https://github.com/apache/inlong/pull/5966#discussion_r975992045
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/AbstractJdbcOutputFormat.java:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.jdbc.internal;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.api.common.io.RichOutputFormat;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.jdbc.internal.connection.JdbcConnectionProvider;
+import org.apache.flink.runtime.state.FunctionInitializationContext;
+import org.apache.flink.runtime.state.FunctionSnapshotContext;
+import org.apache.flink.util.Preconditions;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Flushable;
+import java.io.IOException;
+import java.sql.Connection;
+
+/** Base jdbc outputFormat. */
+public abstract class AbstractJdbcOutputFormat<T> extends RichOutputFormat<T> implements Flushable {
+
+ private static final long serialVersionUID = 1L;
+ public static final int DEFAULT_FLUSH_MAX_SIZE = 5000;
+ public static final long DEFAULT_FLUSH_INTERVAL_MILLS = 0L;
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ org.apache.flink.connector.jdbc.internal.AbstractJdbcOutputFormat.class);
+ protected final JdbcConnectionProvider connectionProvider;
+
+ public AbstractJdbcOutputFormat(JdbcConnectionProvider connectionProvider) {
+ this.connectionProvider = Preconditions.checkNotNull(connectionProvider);
+ }
+
+ @Override
+ public void configure(Configuration parameters) {
+
+ }
+
+ @Override
+ public void open(int taskNumber, int numTasks) throws IOException {
+ try {
+ connectionProvider.getOrEstablishConnection();
+ } catch (Exception e) {
+ throw new IOException("unable to open JDBC writer", e);
+ }
+ }
+
+ @Override
+ public void close() {
+ connectionProvider.closeConnection();
+ }
+
+ @Override
+ public void flush() throws IOException {
+
+ }
+
+ @VisibleForTesting
+ public Connection getConnection() {
+ return connectionProvider.getConnection();
+ }
+
+ public void snapshotState(FunctionSnapshotContext context) throws Exception {
Review Comment:
just declared like other methods in this class, keep it the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org