You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Sylvie-Wxr (via GitHub)" <gi...@apache.org> on 2024/03/16 07:09:21 UTC

[PR] Add Measure IndexRule and IndexRuleBinding to Measure Page [skywalking-banyandb]

Sylvie-Wxr opened a new pull request, #418:
URL: https://github.com/apache/skywalking-banyandb/pull/418

   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [x] If it's UI related, attach the screenshots below.
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking #11979.
   - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
   
   
   ### Feature demo 
   1. Read  IndexRule and IndexRuleBinding  
   
   https://github.com/apache/skywalking-banyandb/assets/129717259/46603870-cfa1-4048-903e-63ae848852ce
   
   2. Create IndexRule and IndexRuleBinding  
   
   https://github.com/apache/skywalking-banyandb/assets/129717259/718d20b6-de9a-417a-aba1-eab9fbcb58a5
   
   3. Edit IndexRule and IndexRuleBinding  
   
   https://github.com/apache/skywalking-banyandb/assets/129717259/e27ddcbd-b1da-4647-869a-8a47cc815a57
   
   4. Delete IndexRule and IndexRuleBinding  
   
   https://github.com/apache/skywalking-banyandb/assets/129717259/eb6932e6-a2aa-49bf-83c9-ed8a99a378c6
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Measure IndexRule and IndexRuleBinding to Measure Page [skywalking-banyandb]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #418:
URL: https://github.com/apache/skywalking-banyandb/pull/418#issuecomment-2001884405

   Please link to the original issue, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Measure IndexRule and IndexRuleBinding to Measure Page [skywalking-banyandb]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #418:
URL: https://github.com/apache/skywalking-banyandb/pull/418#issuecomment-2001887019

   ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/418?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 47.69%. Comparing base [(`618d872`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/618d87232b67128ea38c3fce44a9a9017a549ced?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`cc90526`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/418?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main     #418      +/-   ##
   ==========================================
   - Coverage   48.14%   47.69%   -0.45%     
   ==========================================
     Files         173      173              
     Lines       21586    21586              
   ==========================================
   - Hits        10392    10296      -96     
   - Misses      10303    10413     +110     
   + Partials      891      877      -14     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/418?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Measure IndexRule and IndexRuleBinding to Measure Page [skywalking-banyandb]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #418:
URL: https://github.com/apache/skywalking-banyandb/pull/418


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org