You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/17 03:55:12 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39619: [SPARK-42089][CONNECT][PYTHON] Fix variable name issues in nested lambda functions
zhengruifeng opened a new pull request, #39619:
URL: https://github.com/apache/spark/pull/39619
### What changes were proposed in this pull request?
1, https://github.com/apache/spark/pull/39068 reused the `UnresolvedAttribute` for the `UnresolvedNamedLambdaVariable`, but then `Column('x')` and `UnresolvedNamedLambdaVariable('x')` are mixed in `lambda x: x + cdf.x` (since we use `x/y/z` as augment names); this PR adds the `UnresolvedNamedLambdaVariable` back to distinguish between `Column('x')` and `UnresolvedNamedLambdaVariable('x')`;
2, the `refreshVarName` logic in PySpark was added in https://github.com/apache/spark/pull/32523 to address similar issue in PySpark's Lambda Function, this PR adds a similar function in the Python Client to avoid rewriting the function expression in the server side, which is unnecessary and prone to error .
### Why are the changes needed?
before this PR, the nested lambda function doesn't work properly
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
enabled UT and added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39619: [SPARK-42089][CONNECT][PYTHON] Fix variable name issues in nested lambda functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39619:
URL: https://github.com/apache/spark/pull/39619#issuecomment-1384805109
cc @HyukjinKwon @cloud-fan @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39619: [SPARK-42089][CONNECT][PYTHON] Fix variable name issues in nested lambda functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39619: [SPARK-42089][CONNECT][PYTHON] Fix variable name issues in nested lambda functions
URL: https://github.com/apache/spark/pull/39619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39619: [SPARK-42089][CONNECT][PYTHON] Fix variable name issues in nested lambda functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39619:
URL: https://github.com/apache/spark/pull/39619#issuecomment-1384838474
thanks for the reviews, merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org