[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #218: Test pr

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118091813


##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
         # contexts are the names of checks that must pass
         contexts:
           - Code is formatted
+    temp:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Check headers

Review Comment:
   I understand the sentiment behind the concern but I am not exactly sure how its going to be a technical problem. If any supposed improvements to the header checks cause the check to fail then such a PR wouldn't get merged anyways unless we are going to tell people to ignore the now failing header check, and if so in such a case we would temporarily disable the entire header pipeline along with the check in a separate PR.
   
   The alternative situation is that the header check just doesn't pick up everything (which is the current case, i.e. sbt-header is not picking headers from sbt project files in `project/`) in which case its not going to block anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org