[GitHub] [flink] godfreyhe commented on a change in pull request #14644: [FLINK-20840][table-planner] Properly transpose projection to join

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #14644:
URL: https://github.com/apache/flink/pull/14644#discussion_r559196666



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -308,6 +308,14 @@
     // ------------------------------------------------------------------------
     //  Other Exec Options
     // ------------------------------------------------------------------------
+    @Documentation.TableOption(execMode = Documentation.ExecMode.BATCH_STREAMING)

Review comment:
       why we need to introduce this ?

##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
##########
@@ -160,6 +160,14 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
           case TimestampKind.ROWTIME => createRowtimeIndicatorType(true)
           case TimestampKind.REGULAR => createSqlType(TIMESTAMP, timestampType.getPrecision)
         }
+      case LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE =>

Review comment:
       ditto

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -18,41 +18,19 @@
 
 package org.apache.flink.table.planner.functions.sql;
 
-import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
-import org.apache.flink.table.planner.functions.sql.internal.SqlAuxiliaryGroupAggFunction;
-import org.apache.flink.table.planner.plan.type.FlinkReturnTypes;
-import org.apache.flink.table.planner.plan.type.NumericExceptFirstOperandChecker;
-
-import org.apache.calcite.sql.SqlAggFunction;
-import org.apache.calcite.sql.SqlFunction;
-import org.apache.calcite.sql.SqlFunctionCategory;
-import org.apache.calcite.sql.SqlGroupedWindowFunction;
-import org.apache.calcite.sql.SqlIdentifier;
-import org.apache.calcite.sql.SqlKind;
-import org.apache.calcite.sql.SqlOperator;
-import org.apache.calcite.sql.SqlOperatorBinding;
-import org.apache.calcite.sql.SqlPostfixOperator;
-import org.apache.calcite.sql.SqlSyntax;
-import org.apache.calcite.sql.fun.SqlStdOperatorTable;
-import org.apache.calcite.sql.type.InferTypes;
-import org.apache.calcite.sql.type.OperandTypes;
-import org.apache.calcite.sql.type.ReturnTypes;
-import org.apache.calcite.sql.type.SqlOperandCountRanges;
-import org.apache.calcite.sql.type.SqlReturnTypeInference;
-import org.apache.calcite.sql.type.SqlTypeFamily;
-import org.apache.calcite.sql.type.SqlTypeName;
-import org.apache.calcite.sql.type.SqlTypeTransforms;
-import org.apache.calcite.sql.util.ReflectiveSqlOperatorTable;
-import org.apache.calcite.sql.validate.SqlMonotonicity;
-import org.apache.calcite.sql.validate.SqlNameMatcher;
-import org.apache.calcite.sql.validate.SqlNameMatchers;
-
-import java.util.Arrays;
-import java.util.List;
-
-import static org.apache.flink.table.planner.plan.type.FlinkReturnTypes.ARG0_VARCHAR_FORCE_NULLABLE;
-import static org.apache.flink.table.planner.plan.type.FlinkReturnTypes.STR_MAP_NULLABLE;
-import static org.apache.flink.table.planner.plan.type.FlinkReturnTypes.VARCHAR_2000_NULLABLE;
+import org.apache.flink.table.planner.calcite.*;
+import org.apache.flink.table.planner.functions.sql.internal.*;
+import org.apache.flink.table.planner.plan.type.*;
+
+import org.apache.calcite.sql.*;
+import org.apache.calcite.sql.fun.*;
+import org.apache.calcite.sql.type.*;
+import org.apache.calcite.sql.util.*;
+import org.apache.calcite.sql.validate.*;
+
+import java.util.*;
+
+import static org.apache.flink.table.planner.plan.type.FlinkReturnTypes.*;

Review comment:
       ditto ?

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/delegation/PlannerContext.java
##########
@@ -83,8 +83,8 @@
 @Internal
 public class PlannerContext {
 
-    private final RelDataTypeSystem typeSystem = new FlinkTypeSystem();
-    private final FlinkTypeFactory typeFactory = new FlinkTypeFactory(typeSystem);
+    private final RelDataTypeSystem typeSystem;

Review comment:
       does this really need to change ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org