You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by marschall <gi...@git.apache.org> on 2016/05/15 14:31:00 UTC

[GitHub] commons-lang pull request: LANG-1229 Performance regression in Has...

GitHub user marschall opened a pull request:

    https://github.com/apache/commons-lang/pull/142

    LANG-1229 Performance regression in HashCodeBuilder

    Revert HashCodeBuilder#append(Object,Object) to the version of 3.4 and
    restore performance. This reopens LANG-456.
    
    Issue: LANG-1229
    https://issues.apache.org/jira/browse/LANG-1229

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marschall/commons-lang LANG-1229

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit 38c76759fbdabf0d8df29a621387b75eaf0c3803
Author: Philippe Marschall <ph...@gmail.com>
Date:   2016-05-15T14:28:48Z

    LANG-1229 Performance regression in HashCodeBuilder
    
    Revert HashCodeBuilder#append(Object,Object) to the version of 3.4 and
    restore performance. This reopens LANG-456.
    
    Issue: LANG-1229
    https://issues.apache.org/jira/browse/LANG-1229

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #142: LANG-1229 Performance regression in HashCodeBuilder

Posted by PascalSchumacher <gi...@git.apache.org>.

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/142
  
    To keep the code clean the pull request should also undo the other additions to `HashCodeBuilderTest` done with https://github.com/apache/commons-lang/commit/b5749b4f54b30c0c2050e456c12cfcf516434f13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #142: LANG-1229 Performance regression in HashCodeBuilder

Posted by PascalSchumacher <gi...@git.apache.org>.

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/142
  
    Thanks! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #142: LANG-1229 Performance regression in HashCode...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/142


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---