[GitHub] [iceberg] nastra commented on a diff in pull request #7587: Spark: Fix Parquet read benchmarks for Spark 3.3 + 3.4

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7587:
URL: https://github.com/apache/iceberg/pull/7587#discussion_r1191939627


##########
spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersFlatDataBenchmark.java:
##########
@@ -214,6 +216,8 @@ public void readWithProjectionUsingSparkReader(Blackhole blackhole) throws IOExc
             .set("spark.sql.parquet.binaryAsString", "false")
             .set("spark.sql.parquet.int96AsTimestamp", "false")
             .set("spark.sql.caseSensitive", "false")
+            .set("spark.sql.parquet.inferTimestampNTZ.enabled", "false")
+            .set("spark.sql.legacy.parquet.nanosAsLong", "false")

Review Comment:
   I've included a fix for the Spark 3.3 benchmarks in this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org