[GitHub] [pinot] ankitsultana commented on pull request #10108: [multistage] Fix Leak in MailboxService

[GitBox <gi...@apache.org>]

ankitsultana commented on PR #10108:
URL: https://github.com/apache/pinot/pull/10108#issuecomment-1379741311

   > In addition to leaking the mailbox object. do we also need to worry about closing the resource internal to Mailbox ?
   
   Yes ideally we shouldn't need to use a Cache to work around a design issue, and the OpChains should gracefully close and handle these scenarios. The intention was not to fix the long term design issue with this PR but only make the main usable. Added details on the other comment thread ^


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org