You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by deepti dohare <de...@citrix.com> on 2012/07/02 16:58:38 UTC
Re: Review Request: Fix for CS-15300 Limits on domain admin accounts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5573/
-----------------------------------------------------------
(Updated July 2, 2012, 2:58 p.m.)
Review request for cloudstack.
Changes
-------
Thanks Nitin for the review. I have fixed the change.
Description
-------
Domain Admin accounts now respect the limits imposed on the domain just as a regular account.
This addresses bug CS-15300.
Diffs (updated)
-----
server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 797d9f0
Diff: https://reviews.apache.org/r/5573/diff/
Testing
-------
verified that we can impose limits on domain admin accounts.
Steps to verify:
============
Example: sa1 is sub-domain admin account
url: http://localhost:8080/client/api?command=updateResourceLimit&resourcetype=0&max=1&account=sa1&domainid=4&apikey=3SeISbzeq0V304jxlfGaQgnLvGRcbgQnOzgiEnpsm-gL2qUgYsEw3CQYAlEn2Z9N3AOuZs_uAFywI8s87r5ZDQ&signature=Wc336kdIFT33FWwdJUVwr2h1vH8%3d
response:
<updateresourcelimitresponse cloud-stack-version="3.0.3.2012-06-26T06:03:07Z">
<resourcelimit>
<account>sa1</account>
<domainid>179a496a-d157-4851-a4ec-a29e84e7b32f</domainid>
<domain>SD1</domain>
<resourcetype>0</resourcetype>
<max>1</max>
</resourcelimit>
</updateresourcelimitresponse>
Thanks,
deepti dohare
Re: Review Request: Fix for CS-15300 Limits on domain admin accounts
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5573/#review8802
-----------------------------------------------------------
Ship it!
Ship It!
- Rajesh Battala
On July 2, 2012, 2:58 p.m., deepti dohare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5573/
> -----------------------------------------------------------
>
> (Updated July 2, 2012, 2:58 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Domain Admin accounts now respect the limits imposed on the domain just as a regular account.
>
>
> This addresses bug CS-15300.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 797d9f0
>
> Diff: https://reviews.apache.org/r/5573/diff/
>
>
> Testing
> -------
>
> verified that we can impose limits on domain admin accounts.
>
> Steps to verify:
> ============
>
> Example: sa1 is sub-domain admin account
> url: http://localhost:8080/client/api?command=updateResourceLimit&resourcetype=0&max=1&account=sa1&domainid=4&apikey=3SeISbzeq0V304jxlfGaQgnLvGRcbgQnOzgiEnpsm-gL2qUgYsEw3CQYAlEn2Z9N3AOuZs_uAFywI8s87r5ZDQ&signature=Wc336kdIFT33FWwdJUVwr2h1vH8%3d
>
> response:
> <updateresourcelimitresponse cloud-stack-version="3.0.3.2012-06-26T06:03:07Z">
> <resourcelimit>
> <account>sa1</account>
> <domainid>179a496a-d157-4851-a4ec-a29e84e7b32f</domainid>
> <domain>SD1</domain>
> <resourcetype>0</resourcetype>
> <max>1</max>
> </resourcelimit>
> </updateresourcelimitresponse>
>
>
> Thanks,
>
> deepti dohare
>
>
Re: Review Request: Fix for CS-15300 Limits on domain admin accounts
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5573/#review8798
-----------------------------------------------------------
Ship it!
- Nitin Mehta
On July 2, 2012, 2:58 p.m., deepti dohare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5573/
> -----------------------------------------------------------
>
> (Updated July 2, 2012, 2:58 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Domain Admin accounts now respect the limits imposed on the domain just as a regular account.
>
>
> This addresses bug CS-15300.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 797d9f0
>
> Diff: https://reviews.apache.org/r/5573/diff/
>
>
> Testing
> -------
>
> verified that we can impose limits on domain admin accounts.
>
> Steps to verify:
> ============
>
> Example: sa1 is sub-domain admin account
> url: http://localhost:8080/client/api?command=updateResourceLimit&resourcetype=0&max=1&account=sa1&domainid=4&apikey=3SeISbzeq0V304jxlfGaQgnLvGRcbgQnOzgiEnpsm-gL2qUgYsEw3CQYAlEn2Z9N3AOuZs_uAFywI8s87r5ZDQ&signature=Wc336kdIFT33FWwdJUVwr2h1vH8%3d
>
> response:
> <updateresourcelimitresponse cloud-stack-version="3.0.3.2012-06-26T06:03:07Z">
> <resourcelimit>
> <account>sa1</account>
> <domainid>179a496a-d157-4851-a4ec-a29e84e7b32f</domainid>
> <domain>SD1</domain>
> <resourcetype>0</resourcetype>
> <max>1</max>
> </resourcelimit>
> </updateresourcelimitresponse>
>
>
> Thanks,
>
> deepti dohare
>
>