You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/29 17:56:24 UTC

[GitHub] [pinot] weixiangsun opened a new issue #7835: support is null or is not null checking inside case condition

weixiangsun opened a new issue #7835:
URL: https://github.com/apache/pinot/issues/7835


   Currently, null checking is only supported inside filtering. I want to support the following use case:
   select case 
      when timeStamp IS NULL then  now() 
      else timestamp
   end 
   from meetupRsvp


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] weixiangsun edited a comment on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
weixiangsun edited a comment on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982291784


   Does the index here mean IndexSegment? @atris 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982211557


   The ask itself is different, but in order to solve the issue, we need to access the index within the case transform function. We should try to solve these 2 issues together by allowing using index to filter within the case transform function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] weixiangsun commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982291784


   Does the index here mean IndexSegment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982128869


   Same as #7691 where we need to access the null vector index within case statement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] weixiangsun commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982207016


   They are different. Please reference to https://github.com/apache/pinot/issues/7691#issuecomment-982199086


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982220389


   Understood. In order to solve `IS NULL` and `IS NOT NULL`, we need to access the `NullValueVector` index. Currently case transform function does not support accessing index, so I'm suggesting adding general index access support to case transform function when we try to resolve this issue instead of specialize the null index.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] weixiangsun commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982277821


   What @atris is working on is to implement filter clause instead of case when clause. His work item does not add general index access support to case transform function.
   
   @atris can you confirm it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982273185


   I believe @atris is working on that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] weixiangsun edited a comment on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
weixiangsun edited a comment on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982207016


   They are different. Please reference to https://github.com/apache/pinot/issues/7691#issuecomment-982199086
   @Jackie-Jiang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] atris commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
atris commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982820667


   @weixiangsun I am not sure I understand, but yes, the ability to use an index (Startree, inverted) to solve a specific sub predicate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] weixiangsun commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982217470


   Is Null, Is Not Null checking are not only for case transform function. It might be for If function even though it is not supported by pinot yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] weixiangsun commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982233908


    adding general index access support to case transform function via BlockValSet or some other way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] atris commented on issue #7835: support is null or is not null checking inside case condition

Posted by GitBox <gi...@apache.org>.
atris commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982279802


   Well, I am working on adding multiple predicate evaluation within a single query, where each predicate can be evaluated using an index.
   
   CASE can be modified to use this mechanism


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org