You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/13 05:45:59 UTC
[GitHub] [skywalking] elk-g opened a new pull request #6194: Collect Log with java agent (#6127)
elk-g opened a new pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `3.58%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.58% 49.00% -3.59%
+ Complexity 3740 3424 -316
============================================
Files 1718 944 -774
Lines 36447 23304 -13143
Branches 4035 2289 -1746
============================================
- Hits 19164 11419 -7745
+ Misses 16336 10901 -5435
- Partials 947 984 +37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-16.13%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <0.00%> (-21.15%)` | `23.00 <0.00> (-2.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `51.33%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 0.00% -51.34%
============================================
Files 1700 182 -1518
Lines 35972 4389 -31583
Branches 3975 513 -3462
============================================
- Hits 18465 0 -18465
+ Misses 16562 4389 -12173
+ Partials 945 0 -945
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1631 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `26.94%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 25.52% -26.95%
+ Complexity 3739 1760 -1979
=============================================
Files 1721 932 -789
Lines 36530 22738 -13792
Branches 4029 2202 -1827
=============================================
- Hits 19168 5804 -13364
- Misses 16414 16518 +104
+ Partials 948 416 -532
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5e27cbd) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `14.67%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 37.90% -14.68%
+ Complexity 3740 2509 -1231
=============================================
Files 1718 919 -799
Lines 36447 22762 -13685
Branches 4035 2199 -1836
=============================================
- Hits 19164 8628 -10536
+ Misses 16336 13477 -2859
+ Partials 947 657 -290
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `9.96%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 41.23% -9.97%
+ Complexity 3544 2987 -557
============================================
Files 943 941 -2
Lines 23398 23243 -155
Branches 2270 2261 -9
============================================
- Hits 11980 9585 -2395
- Misses 10405 12803 +2398
+ Partials 1013 855 -158
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [208 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `0.86%`.
> The diff coverage is `3.46%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 50.33% -0.87%
- Complexity 3544 3566 +22
============================================
Files 943 1735 +792
Lines 23398 36790 +13392
Branches 2270 4060 +1790
============================================
+ Hits 11980 18517 +6537
- Misses 10405 17319 +6914
+ Partials 1013 954 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...logging/common/log/GRPCLogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9sb2dnaW5nL2NvbW1vbi9sb2cvR1JQQ0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `0.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 51.93% -0.54%
+ Complexity 3739 3697 -42
============================================
Files 1721 1720 -1
Lines 36530 36463 -67
Branches 4029 4041 +12
============================================
- Hits 19169 18937 -232
- Misses 16413 16575 +162
- Partials 948 951 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-82.61%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-76.48%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-3.00%)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `5.82% <0.00%> (-67.97%)` | `1.00% <0.00%> (-8.00%)` | |
| [.../analyzer/provider/log/LogAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...provider/log/listener/TrafficAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvVHJhZmZpY0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `22.85% <0.00%> (-62.86%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.42% <0.00%> (-53.58%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `1.51%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.58% 51.06% -1.52%
+ Complexity 3740 3522 -218
============================================
Files 1718 944 -774
Lines 36447 23321 -13126
Branches 4035 2290 -1745
============================================
- Hits 19164 11908 -7256
+ Misses 16336 10395 -5941
- Partials 947 1018 +71
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-16.13%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <0.00%> (-21.15%)` | `23.00 <0.00> (-2.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1223 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (d44a1cf) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `11.47%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.20% 39.72% -11.48%
+ Complexity 3544 2787 -757
=============================================
Files 943 914 -29
Lines 23398 22537 -861
Branches 2270 2203 -67
=============================================
- Hits 11980 8952 -3028
- Misses 10405 12801 +2396
+ Partials 1013 784 -229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [215 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **increase** coverage by `1.46%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.20% 52.66% +1.46%
+ Complexity 3544 750 -2794
============================================
Files 943 172 -771
Lines 23398 4185 -19213
Branches 2270 483 -1787
============================================
- Hits 11980 2204 -9776
+ Misses 10405 1702 -8703
+ Partials 1013 279 -734
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `53.57% <0.00%> (-7.15%)` | `5.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...lking/oap/server/library/module/ModuleManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL01vZHVsZU1hbmFnZXIuamF2YQ==) | | | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | | | |
| [...r/parser/performance/BrowserPerfDataDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9Ccm93c2VyUGVyZkRhdGFEZWNvcmF0b3IuamF2YQ==) | | | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | | | |
| [...rver/library/util/yaml/ClassFilterConstructor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwveWFtbC9DbGFzc0ZpbHRlckNvbnN0cnVjdG9yLmphdmE=) | | | |
| ... and [775 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `6.09%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 45.10% -6.10%
+ Complexity 3544 3189 -355
============================================
Files 943 942 -1
Lines 23398 23254 -144
Branches 2270 2261 -9
============================================
- Hits 11980 10489 -1491
- Misses 10405 11850 +1445
+ Partials 1013 915 -98
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [155 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (44a6ef8) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `10.38%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
+ Coverage 42.57% 52.96% +10.38%
- Complexity 3012 3659 +647
=============================================
Files 944 950 +6
Lines 23262 23529 +267
Branches 2256 2311 +55
=============================================
+ Hits 9903 12461 +2558
+ Misses 12493 9991 -2502
- Partials 866 1077 +211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-87.21%)` | `1.00% <0.00%> (-8.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `3.50% <0.00%> (-40.36%)` | `1.00% <0.00%> (-2.00%)` | |
| [...rver/core/profile/ProfileThreadSnapshotRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGhyZWFkU25hcHNob3RSZWNvcmQuamF2YQ==) | `47.82% <0.00%> (-34.79%)` | `2.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/TimeSeriesUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lU2VyaWVzVXRpbHMuamF2YQ==) | `38.00% <0.00%> (-24.00%)` | `11.00% <0.00%> (-6.00%)` | |
| ... and [201 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (986f606) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 198 -1523
Lines 36530 4669 -31861
Branches 4029 546 -3483
============================================
- Hits 19168 0 -19168
+ Misses 16414 4669 -11745
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1692 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...986f606](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (f9d4c6e) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `5.21%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 47.25% -5.22%
+ Complexity 3739 3253 -486
============================================
Files 1721 947 -774
Lines 36530 23114 -13416
Branches 4029 2274 -1755
============================================
- Hits 19168 10923 -8245
+ Misses 16414 11255 -5159
+ Partials 948 936 -12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1254 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `15.13%`.
> The diff coverage is `46.80%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 36.19% -15.14%
+ Complexity 3535 2498 -1037
=============================================
Files 1700 944 -756
Lines 35972 23299 -12673
Branches 3975 2277 -1698
=============================================
- Hits 18465 8433 -10032
+ Misses 16562 14215 -2347
+ Partials 945 651 -294
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| ... and [1357 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `15.11%`.
> The diff coverage is `46.80%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 36.21% -15.12%
+ Complexity 3535 2498 -1037
=============================================
Files 1700 942 -758
Lines 35972 23288 -12684
Branches 3975 2277 -1698
=============================================
- Hits 18465 8433 -10032
+ Misses 16562 14204 -2358
+ Partials 945 651 -294
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| ... and [1357 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **increase** coverage by `0.91%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.20% 52.11% +0.91%
- Complexity 3544 3566 +22
============================================
Files 943 943
Lines 23398 23424 +26
Branches 2270 2300 +30
============================================
+ Hits 11980 12207 +227
+ Misses 10405 10176 -229
- Partials 1013 1041 +28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...nual/errorlog/BrowserErrorLogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvZXJyb3Jsb2cvQnJvd3NlckVycm9yTG9nUmVjb3JkRGlzcGF0Y2hlci5qYXZh) | `7.69% <0.00%> (-92.31%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ser/provider/parser/errorlog/ErrorLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9FcnJvckxvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ance/BrowserAppSingleVersionTrafficDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvaW5zdGFuY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25UcmFmZmljRGlzcGF0Y2hlci5qYXZh) | `12.50% <0.00%> (-87.50%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [122 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `13.49%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 39.08% -13.50%
+ Complexity 3740 2765 -975
=============================================
Files 1718 925 -793
Lines 36447 22678 -13769
Branches 4035 2225 -1810
=============================================
- Hits 19164 8863 -10301
+ Misses 16336 13044 -3292
+ Partials 947 771 -176
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-16.13%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <0.00%> (-21.15%)` | `23.00 <0.00> (-2.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `51.33%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 0.00% -51.34%
============================================
Files 1700 180 -1520
Lines 35972 4383 -31589
Branches 3975 513 -3462
============================================
- Hits 18465 0 -18465
+ Misses 16562 4383 -12179
+ Partials 945 0 -945
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1631 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.66%`.
> The diff coverage is `23.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 38.66% -12.67%
+ Complexity 3535 2746 -789
=============================================
Files 1700 926 -774
Lines 35972 22801 -13171
Branches 3975 2216 -1759
=============================================
- Hits 18465 8817 -9648
+ Misses 16562 13206 -3356
+ Partials 945 778 -167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `20.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **increase** coverage by `2.17%`.
> The diff coverage is `52.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.33% 53.50% +2.17%
- Complexity 3535 3623 +88
============================================
Files 1700 946 -754
Lines 35972 23457 -12515
Branches 3975 2301 -1674
============================================
- Hits 18465 12551 -5914
+ Misses 16562 9865 -6697
- Partials 945 1041 +96
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `2.63% <0.00%> (-1.54%)` | `1.00 <0.00> (ø)` | |
| ... and [1263 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **increase** coverage by `1.57%`.
> The diff coverage is `52.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.33% 52.90% +1.57%
- Complexity 3535 3600 +65
============================================
Files 1700 946 -754
Lines 35972 23457 -12515
Branches 3975 2301 -1674
============================================
- Hits 18465 12411 -6054
+ Misses 16562 10004 -6558
- Partials 945 1042 +97
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `2.63% <0.00%> (-1.54%)` | `1.00 <0.00> (ø)` | |
| ... and [1265 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (f9d4c6e) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `1.07%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 51.39% -1.08%
+ Complexity 3739 3546 -193
============================================
Files 1721 964 -757
Lines 36530 23654 -12876
Branches 4029 2331 -1698
============================================
- Hits 19168 12157 -7011
+ Misses 16414 10481 -5933
- Partials 948 1016 +68
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1225 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r558854203
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logback-1.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/logback/v1/x/log/GRPCLogAppenderInterceptor.java
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.logback.v1.x.log;
+
+import java.lang.reflect.Method;
+import java.util.Objects;
+
+import org.apache.skywalking.apm.agent.core.boot.ServiceManager;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.remote.LogReportServiceClient;
+import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogDataBody;
+import org.apache.skywalking.apm.network.logging.v3.LogTags;
+import org.apache.skywalking.apm.network.logging.v3.TextLog;
+import org.apache.skywalking.apm.network.logging.v3.TraceContext;
+
+import ch.qos.logback.classic.spi.ILoggingEvent;
+
+public class GRPCLogAppenderInterceptor implements InstanceMethodsAroundInterceptor {
+
+ private LogReportServiceClient client;
+
+ @Override
+ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+ if (Objects.isNull(client)) {
+ client = ServiceManager.INSTANCE.findService(LogReportServiceClient.class);
+ if (Objects.isNull(client)) {
+ return;
+ }
+ }
+ ILoggingEvent event = (ILoggingEvent) allArguments[0];
+ if (Objects.nonNull(event)) {
+ client.produce(transform(event));
+ }
+ }
+
+ @Override
+ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ Object ret) throws Throwable {
+ return ret;
+ }
+
+ @Override
+ public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments,
+ Class<?>[] argumentsTypes, Throwable t) {
+
+ }
+
+ private LogData transform(ILoggingEvent event) {
+ return LogData.newBuilder()
+ .setTimestamp(event.getTimeStamp())
+ .setService(Config.Agent.SERVICE_NAME)
+ .setServiceInstance(Config.Agent.INSTANCE_NAME)
+ .setTraceContext(TraceContext.newBuilder()
+ .setTraceId(ContextManager.getGlobalTraceId())
+ .setSpanId(ContextManager.getSpanId())
+ .setTraceSegmentId(ContextManager.getSegmentId())
Review comment:
when no tracing context, the traceId maybe `N/A` rather than an empty string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (017fff5) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `21.22%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.19% 29.96% -21.23%
+ Complexity 2900 2034 -866
=============================================
Files 1700 909 -791
Lines 35973 22404 -13569
Branches 4141 2175 -1966
=============================================
- Hits 18417 6714 -11703
+ Misses 16605 15176 -1429
+ Partials 951 514 -437
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1316 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.28%`.
> The diff coverage is `26.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 39.04% -12.29%
+ Complexity 3535 2813 -722
=============================================
Files 1700 947 -753
Lines 35972 23215 -12757
Branches 3975 2285 -1690
=============================================
- Hits 18465 9064 -9401
+ Misses 16562 13366 -3196
+ Partials 945 785 -160
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `3.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 49.38% -3.09%
+ Complexity 3739 3432 -307
============================================
Files 1721 1720 -1
Lines 36530 36448 -82
Branches 4029 4041 +12
============================================
- Hits 19168 18000 -1168
- Misses 16414 17493 +1079
- Partials 948 955 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [100 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `16.35%`.
> The diff coverage is `22.74%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 34.97% -16.36%
+ Complexity 3535 2024 -1511
=============================================
Files 1700 768 -932
Lines 35972 19095 -16877
Branches 3975 1795 -2180
=============================================
- Hits 18465 6679 -11786
+ Misses 16562 11902 -4660
+ Partials 945 514 -431
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `20.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [1397 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `17.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 55.07% 37.62% -17.46%
+ Complexity 3739 2701 -1038
=============================================
Files 944 910 -34
Lines 23462 22365 -1097
Branches 2307 2177 -130
=============================================
- Hits 12922 8414 -4508
- Misses 9433 13201 +3768
+ Partials 1107 750 -357
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [298 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (986f606) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 189 -1532
Lines 36530 4472 -32058
Branches 4029 530 -3499
============================================
- Hits 19168 0 -19168
+ Misses 16414 4472 -11942
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1698 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...986f606](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `1.86%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 49.33% -1.87%
+ Complexity 3544 3485 -59
============================================
Files 943 968 +25
Lines 23398 23820 +422
Branches 2270 2343 +73
============================================
- Hits 11980 11752 -228
- Misses 10405 11053 +648
- Partials 1013 1015 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `2.03%`.
> The diff coverage is `51.11%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 49.29% -2.04%
+ Complexity 3535 3414 -121
============================================
Files 1700 946 -754
Lines 35972 23409 -12563
Branches 3975 2295 -1680
============================================
- Hits 18465 11540 -6925
+ Misses 16562 10875 -5687
- Partials 945 994 +49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559120298
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logging-common/pom.xml
##########
@@ -0,0 +1,100 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>apm-toolkit-activation</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.4.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>apm-toolkit-logging-common</artifactId>
+
+ <properties>
+ <shade.com.google.source>com.google</shade.com.google.source>
+ <shade.com.google.target>${shade.package}.${shade.com.google.source}</shade.com.google.target>
+ <shade.io.grpc.source>io.grpc</shade.io.grpc.source>
+ <shade.io.grpc.target>${shade.package}.${shade.io.grpc.source}</shade.io.grpc.target>
+ <shade.io.netty.source>io.netty</shade.io.netty.source>
+ <shade.io.netty.target>${shade.package}.${shade.io.netty.source}</shade.io.netty.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>apm-network</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <artifactSet>
+ <excludes>
+ <exclude>com.google.errorprone:error_prone_annotations:jar:</exclude>
+ <exclude>com.google.code.findbugs:jsr305:jar:</exclude>
+ <exclude>com.google.android:annotations:jar:</exclude>
+ <exclude>com.google.api.grpc:proto-google-common-protos:jar:</exclude>
+ </excludes>
+ </artifactSet>
+ <relocations>
+ <relocation>
+ <pattern>${shade.com.google.source}</pattern>
+ <shadedPattern>${shade.com.google.target}</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>${shade.io.grpc.source}</pattern>
+ <shadedPattern>${shade.io.grpc.target}</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>${shade.io.netty.source}</pattern>
+ <shadedPattern>${shade.io.netty.target}</shadedPattern>
+ </relocation>
+ </relocations>
+ <filters>
+ <filter>
+ <artifact>com.google.protobuf:protobuf-java</artifact>
+ <excludes>
+ <exclude>google/protobuf/*.proto</exclude>
+ <exclude>google/protobuf/compiler/*.proto</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <transformers>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
Review comment:
I think you don't have service resource to transfer?
Try this? https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (e01cd3c) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `11.45%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.20% 39.74% -11.46%
+ Complexity 3544 2791 -753
=============================================
Files 943 914 -29
Lines 23398 22537 -861
Branches 2270 2203 -67
=============================================
- Hits 11980 8957 -3023
- Misses 10405 12800 +2395
+ Partials 1013 780 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [218 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `1.40%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 49.79% -1.41%
+ Complexity 3544 3468 -76
============================================
Files 943 948 +5
Lines 23398 23448 +50
Branches 2270 2278 +8
============================================
- Hits 11980 11675 -305
- Misses 10405 10767 +362
+ Partials 1013 1006 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (f9d4c6e) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `16.60%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 35.87% -16.61%
+ Complexity 3739 2413 -1326
=============================================
Files 1721 943 -778
Lines 36530 23066 -13464
Branches 4029 2270 -1759
=============================================
- Hits 19168 8274 -10894
+ Misses 16414 14135 -2279
+ Partials 948 657 -291
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1320 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `17.27%`.
> The diff coverage is `23.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 34.05% -17.28%
+ Complexity 3535 2376 -1159
=============================================
Files 1700 942 -758
Lines 35972 23288 -12684
Branches 3975 2277 -1698
=============================================
- Hits 18465 7931 -10534
+ Misses 16562 14747 -1815
+ Partials 945 610 -335
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `18.83%`.
> The diff coverage is `23.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 32.49% -18.84%
+ Complexity 3535 2261 -1274
=============================================
Files 1700 942 -758
Lines 35972 23288 -12684
Branches 3975 2277 -1698
=============================================
- Hits 18465 7568 -10897
+ Misses 16562 15142 -1420
+ Partials 945 578 -367
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1373 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (0e72394) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `13.94%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 38.52% -13.95%
+ Complexity 3739 2622 -1117
=============================================
Files 1721 939 -782
Lines 36530 23170 -13360
Branches 4029 2256 -1773
=============================================
- Hits 19168 8926 -10242
+ Misses 16414 13531 -2883
+ Partials 948 713 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1298 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...741517c](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559048595
##########
File path: apm-application-toolkit/apm-toolkit-log4j-2.x/src/main/java/org/apache/skywalking/apm/toolkit/log/log4j/v2/x/log/GRPCLogClientAppender.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.log.log4j.v2.x.log;
+
+import org.apache.logging.log4j.core.Filter;
+import org.apache.logging.log4j.core.LogEvent;
+import org.apache.logging.log4j.core.appender.AbstractAppender;
+import org.apache.logging.log4j.core.config.Configuration;
+import org.apache.logging.log4j.core.config.plugins.Plugin;
+import org.apache.logging.log4j.core.config.plugins.PluginAttribute;
+import org.apache.logging.log4j.core.config.plugins.PluginConfiguration;
+import org.apache.logging.log4j.core.config.plugins.PluginElement;
+import org.apache.logging.log4j.core.config.plugins.PluginFactory;
+
+@Plugin(name = "GRPCLogClientAppender", category = "Core", elementType = "appender")
+public class GRPCLogClientAppender extends AbstractAppender {
+
+ private GRPCLogClientAppender(final String name, final Filter filter, final boolean ignoreExceptions) {
+ super(name, filter, null, ignoreExceptions);
+ }
+
+ @Override
+ public void append(LogEvent logEvent) {
+
+ }
+
+ @PluginFactory
+ public static GRPCLogClientAppender createAppender(@PluginAttribute("name") final String name,
+ @PluginElement("Filter") final Filter filter,
+ @PluginConfiguration final Configuration config,
+ @PluginAttribute("ignoreExceptions") final String ignore) {
+
+ String appenderName = (name == null) ? "gRPCLogClientAppender" : name;
+
+ final boolean ignoreExceptions = "true".equalsIgnoreCase(ignore) || (!"false".equalsIgnoreCase(ignore));
Review comment:
*UnnecessaryParentheses:* Unnecessary use of grouping parentheses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (1137970) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `14.12%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 38.34% -14.13%
+ Complexity 3739 2607 -1132
=============================================
Files 1721 967 -754
Lines 36530 23738 -12792
Branches 4029 2322 -1707
=============================================
- Hits 19168 9102 -10066
+ Misses 16414 13961 -2453
+ Partials 948 675 -273
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.15%`.
> The diff coverage is `49.72%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 39.17% -12.16%
+ Complexity 3535 2642 -893
=============================================
Files 1700 945 -755
Lines 35972 23322 -12650
Branches 3975 2277 -1698
=============================================
- Hits 18465 9137 -9328
+ Misses 16562 13473 -3089
+ Partials 945 712 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (44a6ef8) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `42.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 42.57% 0.00% -42.58%
============================================
Files 944 178 -766
Lines 23262 4341 -18921
Branches 2256 509 -1747
============================================
- Hits 9903 0 -9903
+ Misses 12493 4341 -8152
+ Partials 866 0 -866
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [907 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `51.33%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 0.00% -51.34%
============================================
Files 1700 184 -1516
Lines 35972 4400 -31572
Branches 3975 513 -3462
============================================
- Hits 18465 0 -18465
+ Misses 16562 4400 -12162
+ Partials 945 0 -945
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1631 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **increase** coverage by `1.86%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 52.58% 54.44% +1.86%
+ Complexity 3740 3708 -32
============================================
Files 1718 944 -774
Lines 36447 23349 -13098
Branches 4035 2295 -1740
============================================
- Hits 19164 12713 -6451
+ Misses 16336 9565 -6771
- Partials 947 1071 +124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-16.24%)` | `25.00 <0.00> (ø)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1202 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...215aded](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `1.85%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 49.34% -1.86%
+ Complexity 3544 3485 -59
============================================
Files 943 967 +24
Lines 23398 23816 +418
Branches 2270 2343 +73
============================================
- Hits 11980 11752 -228
- Misses 10405 11049 +644
- Partials 1013 1015 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [100 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (741517c) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `8.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 43.91% -8.56%
+ Complexity 3739 2542 -1197
============================================
Files 1721 784 -937
Lines 36530 19566 -16964
Branches 4029 1847 -2182
============================================
- Hits 19168 8593 -10575
+ Misses 16414 10283 -6131
+ Partials 948 690 -258
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1323 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...741517c](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.36%`.
> The diff coverage is `23.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 38.96% -12.37%
+ Complexity 3535 2746 -789
=============================================
Files 1700 918 -782
Lines 35972 22626 -13346
Branches 3975 2197 -1778
=============================================
- Hits 18465 8817 -9648
+ Misses 16562 13031 -3531
+ Partials 945 778 -167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `20.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `22.60%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 29.97% -22.61%
+ Complexity 3740 2059 -1681
=============================================
Files 1718 924 -794
Lines 36447 22674 -13773
Branches 4035 2225 -1810
=============================================
- Hits 19164 6797 -12367
+ Misses 16336 15361 -975
+ Partials 947 516 -431
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `20.63%`.
> The diff coverage is `22.74%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 30.69% -20.64%
+ Complexity 3535 1762 -1773
=============================================
Files 1700 768 -932
Lines 35972 18954 -17018
Branches 3975 1765 -2210
=============================================
- Hits 18465 5818 -12647
+ Misses 16562 12718 -3844
+ Partials 945 418 -527
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `20.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [1417 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (88c9dda) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `8.57%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 43.89% -8.58%
+ Complexity 3739 3053 -686
============================================
Files 1721 918 -803
Lines 36530 22607 -13923
Branches 4029 2212 -1817
============================================
- Hits 19168 9923 -9245
+ Misses 16414 11847 -4567
+ Partials 948 837 -111
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559509594
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logging-common/src/main/resources/META-INF/services/org.apache.skywalking.apm.agent.core.boot.BootService
##########
@@ -0,0 +1,22 @@
+#
+# Copyright (C) 2021 Baidu, Inc. All Rights Reserved.
Review comment:
please remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `1.86%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.58% 50.71% -1.87%
+ Complexity 3740 3504 -236
============================================
Files 1718 944 -774
Lines 36447 23321 -13126
Branches 4035 2290 -1745
============================================
- Hits 19164 11828 -7336
+ Misses 16336 10490 -5846
- Partials 947 1003 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-16.13%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <0.00%> (-21.15%)` | `23.00 <0.00> (-2.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1227 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (1137970) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 162 -1559
Lines 36530 3979 -32551
Branches 4029 467 -3562
============================================
- Hits 19168 0 -19168
+ Misses 16414 3979 -12435
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1701 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] elk-g commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
elk-g commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559190331
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -159,6 +159,10 @@ property key | Description | Default |
`plugin.kafka.topic_profilings` | Specify which Kafka topic name for Thread Profiling snapshot to report to. | `skywalking_profilings` |
`plugin.kafka.topic_management` | Specify which Kafka topic name for the register or heartbeat data of Service Instance to report to. | `skywalking_managements` |
`plugin.springannotation.classname_match_regex` | Match spring beans with regular expression for the class name. Multiple expressions could be separated by a comma. This only works when `Spring annotation plugin` has been activated. | `All the spring beans tagged with @Bean,@Service,@Dao, or @Repository.` |
+`plugin.grpclog.service_host` | Specify which grpc server's host for log data to report to. | `127.0.0.1` |
+`plugin.grpclog.service_port` | Specify which grpc server's port for log data to report to. | `11800` |
+`plugin.grpclog.max_message_size` | Specify the maximum size of log data for grpc client to report to. | `10485760` |
+`plugin.grpclog.upstream_timeout` | How long grpc client will timeout in sending data to upstream. Unit is second.|`30` seconds|
Review comment:
Using `@PluginConfig` to set config, isn't the prefix of key fixed to `plugin.classname`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (44a6ef8) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `11.36%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
+ Coverage 42.57% 53.93% +11.36%
- Complexity 3012 3702 +690
=============================================
Files 944 950 +6
Lines 23262 23529 +267
Branches 2256 2311 +55
=============================================
+ Hits 9903 12690 +2787
+ Misses 12493 9739 -2754
- Partials 866 1100 +234
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...server/storage/plugin/influxdb/query/LogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Mb2dRdWVyeS5qYXZh) | `5.00% <0.00%> (-0.07%)` | `2.00% <0.00%> (ø%)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (88c9dda) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `2.57%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 49.89% -2.58%
+ Complexity 3739 3486 -253
============================================
Files 1721 939 -782
Lines 36530 23220 -13310
Branches 4029 2277 -1752
============================================
- Hits 19168 11586 -7582
+ Misses 16414 10630 -5784
- Partials 948 1004 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1219 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559117522
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logging-common/pom.xml
##########
@@ -0,0 +1,100 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>apm-toolkit-activation</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.4.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>apm-toolkit-logging-common</artifactId>
+
+ <properties>
+ <shade.com.google.source>com.google</shade.com.google.source>
+ <shade.com.google.target>${shade.package}.${shade.com.google.source}</shade.com.google.target>
+ <shade.io.grpc.source>io.grpc</shade.io.grpc.source>
+ <shade.io.grpc.target>${shade.package}.${shade.io.grpc.source}</shade.io.grpc.target>
+ <shade.io.netty.source>io.netty</shade.io.netty.source>
+ <shade.io.netty.target>${shade.package}.${shade.io.netty.source}</shade.io.netty.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>apm-network</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <artifactSet>
+ <excludes>
+ <exclude>com.google.errorprone:error_prone_annotations:jar:</exclude>
+ <exclude>com.google.code.findbugs:jsr305:jar:</exclude>
+ <exclude>com.google.android:annotations:jar:</exclude>
+ <exclude>com.google.api.grpc:proto-google-common-protos:jar:</exclude>
+ </excludes>
+ </artifactSet>
+ <relocations>
+ <relocation>
+ <pattern>${shade.com.google.source}</pattern>
+ <shadedPattern>${shade.com.google.target}</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>${shade.io.grpc.source}</pattern>
+ <shadedPattern>${shade.io.grpc.target}</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>${shade.io.netty.source}</pattern>
+ <shadedPattern>${shade.io.netty.target}</shadedPattern>
+ </relocation>
+ </relocations>
+ <filters>
+ <filter>
+ <artifact>com.google.protobuf:protobuf-java</artifact>
+ <excludes>
+ <exclude>google/protobuf/*.proto</exclude>
+ <exclude>google/protobuf/compiler/*.proto</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <transformers>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
Review comment:
Do you choose the right transformer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `3.55%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 47.64% -3.56%
+ Complexity 3544 3305 -239
============================================
Files 943 942 -1
Lines 23398 23273 -125
Branches 2270 2261 -9
============================================
- Hits 11980 11089 -891
- Misses 10405 11209 +804
+ Partials 1013 975 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [130 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (986f606) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `18.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 34.25% -18.22%
+ Complexity 3739 2444 -1295
=============================================
Files 1721 967 -754
Lines 36530 23705 -12825
Branches 4029 2322 -1707
=============================================
- Hits 19168 8121 -11047
+ Misses 16414 14915 -1499
+ Partials 948 669 -279
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1314 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...986f606](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-761542231
You still have UT failure, please fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (fa69253) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `22.61%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 29.85% -22.62%
+ Complexity 3739 2087 -1652
=============================================
Files 1721 950 -771
Lines 36530 23143 -13387
Branches 4029 2266 -1763
=============================================
- Hits 19168 6910 -12258
+ Misses 16414 15712 -702
+ Partials 948 521 -427
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `2.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 50.24% -2.23%
+ Complexity 3739 3553 -186
============================================
Files 1721 1720 -1
Lines 36530 36451 -79
Branches 4029 4041 +12
============================================
- Hits 19168 18314 -854
- Misses 16414 17183 +769
- Partials 948 954 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-82.61%)` | `0.00% <0.00%> (-5.00%)` | |
| [...rver/core/profile/ProfileThreadSnapshotRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGhyZWFkU25hcHNob3RSZWNvcmQuamF2YQ==) | `4.34% <0.00%> (-78.27%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [59 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `13.24%`.
> The diff coverage is `23.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 38.08% -13.25%
+ Complexity 3535 2746 -789
=============================================
Files 1700 943 -757
Lines 35972 23148 -12824
Branches 3975 2266 -1709
=============================================
- Hits 18465 8817 -9648
+ Misses 16562 13553 -3009
+ Partials 945 778 -167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `20.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (215aded) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `17.29%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 35.28% -17.30%
+ Complexity 3740 2430 -1310
=============================================
Files 1718 947 -771
Lines 36447 23069 -13378
Branches 4035 2255 -1780
=============================================
- Hits 19164 8141 -11023
+ Misses 16336 14294 -2042
+ Partials 947 634 -313
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1312 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...215aded](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 49.39% -3.08%
+ Complexity 3739 3434 -305
============================================
Files 1721 1720 -1
Lines 36530 36448 -82
Branches 4029 4041 +12
============================================
- Hits 19168 18003 -1165
- Misses 16414 17490 +1076
- Partials 948 955 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `21.21%`.
> The diff coverage is `24.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 30.11% -21.22%
+ Complexity 3535 2065 -1470
=============================================
Files 1700 915 -785
Lines 35972 22611 -13361
Branches 3975 2209 -1766
=============================================
- Hits 18465 6809 -11656
+ Misses 16562 15279 -1283
+ Partials 945 523 -422
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1389 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (1137970) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 181 -1540
Lines 36530 4316 -32214
Branches 4029 496 -3533
============================================
- Hits 19168 0 -19168
+ Misses 16414 4316 -12098
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1692 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **increase** coverage by `1.86%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 52.58% 54.44% +1.86%
+ Complexity 3740 3708 -32
============================================
Files 1718 944 -774
Lines 36447 23349 -13098
Branches 4035 2295 -1740
============================================
- Hits 19164 12713 -6451
+ Misses 16336 9565 -6771
- Partials 947 1071 +124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-16.24%)` | `25.00 <0.00> (ø)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1202 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `1.16%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 50.03% -1.17%
+ Complexity 3544 3460 -84
============================================
Files 943 942 -1
Lines 23398 23329 -69
Branches 2270 2267 -3
============================================
- Hits 11980 11672 -308
- Misses 10405 10658 +253
+ Partials 1013 999 -14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...nual/errorlog/BrowserErrorLogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvZXJyb3Jsb2cvQnJvd3NlckVycm9yTG9nUmVjb3JkRGlzcGF0Y2hlci5qYXZh) | `7.69% <0.00%> (-92.31%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [114 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `2.99%`.
> The diff coverage is `53.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 48.34% -3.00%
+ Complexity 3535 3391 -144
============================================
Files 1700 968 -732
Lines 35972 23750 -12222
Branches 3975 2337 -1638
============================================
- Hits 18465 11481 -6984
+ Misses 16562 11291 -5271
- Partials 945 978 +33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `2.63% <0.00%> (-1.54%)` | `1.00 <0.00> (ø)` | |
| ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (88c9dda) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `6.74%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 45.73% -6.75%
+ Complexity 3739 3177 -562
============================================
Files 1721 922 -799
Lines 36530 22678 -13852
Branches 4029 2221 -1808
============================================
- Hits 19168 10371 -8797
+ Misses 16414 11431 -4983
+ Partials 948 876 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1265 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (0e72394) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `13.94%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 38.52% -13.95%
+ Complexity 3739 2622 -1117
=============================================
Files 1721 939 -782
Lines 36530 23170 -13360
Branches 4029 2256 -1773
=============================================
- Hits 19168 8926 -10242
+ Misses 16414 13531 -2883
+ Partials 948 713 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1298 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r558286647
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-1.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.log4j.v1.x.log;
+
+import java.lang.reflect.Method;
+import java.util.Objects;
+import java.util.Optional;
+
+import org.apache.skywalking.apm.agent.core.boot.ServiceManager;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair;
+import org.apache.skywalking.apm.network.logging.v3.JSONLog;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogDataBody;
+import org.apache.skywalking.apm.network.logging.v3.TextLog;
+import org.apache.skywalking.apm.network.logging.v3.TraceContext;
+import org.apache.skywalking.apm.network.logging.v3.YAMLLog;
+import org.apache.skywalking.apm.toolkit.common.log.GRPCLogConfig;
+import org.apache.skywalking.apm.toolkit.common.log.LogReportServiceClient;
+import org.slf4j.event.LoggingEvent;
+
+public class GRPCLogAppenderInterceptor implements InstanceMethodsAroundInterceptor {
+
+ private LogReportServiceClient client;
+
+ @Override
+ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+ if (Objects.isNull(client)) {
+ client = ServiceManager.INSTANCE.findService(LogReportServiceClient.class);
+ if (Objects.isNull(client)) {
+ return;
+ }
+ }
+ LoggingEvent event = (LoggingEvent) allArguments[0];
+ if (event != null) {
+ LogData logData = transform(event);
+ if (Objects.nonNull(logData)) {
+ client.produce(logData);
+ }
+ }
+ }
+
+ @Override
+ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ Object ret) throws Throwable {
+ return ret;
+ }
+
+ @Override
+ public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments,
+ Class<?>[] argumentsTypes, Throwable t) {
+
+ }
+
+ private LogData transform(LoggingEvent event) {
+ if (Objects.isNull(event)) {
+ return null;
+ }
+ LogData.Builder logBuilder = LogData.newBuilder()
+ .setTimestamp(event.getTimeStamp())
+ .setService(Config.Agent.SERVICE_NAME)
+ .setServiceInstance(Config.Agent.INSTANCE_NAME)
+ .setTraceContext(TraceContext.newBuilder()
+ .setTraceId(ContextManager.getGlobalTraceId()).build())
Review comment:
waiting https://github.com/apache/skywalking/pull/6213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **increase** coverage by `1.52%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 52.58% 54.10% +1.52%
+ Complexity 3740 3690 -50
============================================
Files 1718 944 -774
Lines 36447 23349 -13098
Branches 4035 2295 -1740
============================================
- Hits 19164 12633 -6531
+ Misses 16336 9655 -6681
- Partials 947 1061 +114
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-16.13%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <0.00%> (-21.15%)` | `23.00 <0.00> (-2.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `21.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 31.46% -21.01%
+ Complexity 3739 2195 -1544
=============================================
Files 1721 949 -772
Lines 36530 23286 -13244
Branches 4029 2259 -1770
=============================================
- Hits 19168 7328 -11840
+ Misses 16414 15390 -1024
+ Partials 948 568 -380
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1329 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `8.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 48.06% 56.23% +8.16%
+ Complexity 3383 744 -2639
============================================
Files 944 161 -783
Lines 23421 3898 -19523
Branches 2301 459 -1842
============================================
- Hits 11258 2192 -9066
+ Misses 11172 1428 -9744
+ Partials 991 278 -713
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `53.57% <0.00%> (-7.15%)` | `5.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [.../commons/datacarrier/consumer/BulkConsumePool.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0J1bGtDb25zdW1lUG9vbC5qYXZh) | | | |
| [...rage/plugin/jdbc/h2/dao/H2AggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWdncmVnYXRpb25RdWVyeURBTy5qYXZh) | | | |
| [...orage/plugin/elasticsearch7/dao/StorageEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vU3RvcmFnZUVzN0RBTy5qYXZh) | | | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | | | |
| [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | | | |
| [.../server/core/alarm/provider/grpc/GRPCCallback.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9ncnBjL0dSUENDYWxsYmFjay5qYXZh) | | | |
| ... and [779 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (1137970) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `19.34%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 33.12% -19.35%
+ Complexity 3739 2278 -1461
=============================================
Files 1721 950 -771
Lines 36530 23183 -13347
Branches 4029 2267 -1762
=============================================
- Hits 19168 7680 -11488
+ Misses 16414 14930 -1484
+ Partials 948 573 -375
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1331 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (986f606) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `23.17%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 29.29% -23.18%
+ Complexity 3739 2062 -1677
=============================================
Files 1721 950 -771
Lines 36530 23054 -13476
Branches 4029 2238 -1791
=============================================
- Hits 19168 6753 -12415
+ Misses 16414 15749 -665
+ Partials 948 552 -396
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...986f606](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `23.10%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 29.36% -23.11%
+ Complexity 3739 2022 -1717
=============================================
Files 1721 932 -789
Lines 36530 22776 -13754
Branches 4029 2205 -1824
=============================================
- Hits 19168 6688 -12480
+ Misses 16414 15585 -829
+ Partials 948 503 -445
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `51.33%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 0.00% -51.34%
============================================
Files 1700 185 -1515
Lines 35972 4404 -31568
Branches 3975 513 -3462
============================================
- Hits 18465 0 -18465
+ Misses 16562 4404 -12158
+ Partials 945 0 -945
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1631 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5e27cbd) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `16.59%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.19% 34.60% -16.60%
+ Complexity 2900 2367 -533
=============================================
Files 1700 919 -781
Lines 35973 22748 -13225
Branches 4141 2198 -1943
=============================================
- Hits 18417 7871 -10546
+ Misses 16605 14277 -2328
+ Partials 951 600 -351
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (986f606) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `30.63%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 21.83% -30.64%
+ Complexity 3739 1614 -2125
=============================================
Files 1721 950 -771
Lines 36530 23031 -13499
Branches 4029 2236 -1793
=============================================
- Hits 19168 5029 -14139
- Misses 16414 17632 +1218
+ Partials 948 370 -578
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1391 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...986f606](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559088297
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -159,6 +159,10 @@ property key | Description | Default |
`plugin.kafka.topic_profilings` | Specify which Kafka topic name for Thread Profiling snapshot to report to. | `skywalking_profilings` |
`plugin.kafka.topic_management` | Specify which Kafka topic name for the register or heartbeat data of Service Instance to report to. | `skywalking_managements` |
`plugin.springannotation.classname_match_regex` | Match spring beans with regular expression for the class name. Multiple expressions could be separated by a comma. This only works when `Spring annotation plugin` has been activated. | `All the spring beans tagged with @Bean,@Service,@Dao, or @Repository.` |
+`plugin.grpclog.service_host` | Specify which grpc server's host for log data to report to. | `127.0.0.1` |
+`plugin.grpclog.service_port` | Specify which grpc server's port for traces data to report to. | `8000` |
+`plugin.grpclog.max_message_size` | Specify the maximum size of log data for grpc client to report to. | `10MB` |
+`plugin.grpclog.upstream_timeout` | How long grpc client will timeout in sending data to upstream. Unit is second.|`30` seconds|
Review comment:
Above are still missing. @elk-g
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `22.48%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 30.09% -22.49%
+ Complexity 3740 2055 -1685
=============================================
Files 1718 919 -799
Lines 36447 22561 -13886
Branches 4035 2204 -1831
=============================================
- Hits 19164 6789 -12375
+ Misses 16336 15252 -1084
+ Partials 947 520 -427
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **increase** coverage by `0.60%`.
> The diff coverage is `26.90%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.33% 51.93% +0.60%
- Complexity 3535 3705 +170
============================================
Files 1700 1720 +20
Lines 35972 36474 +502
Branches 3975 4041 +66
============================================
+ Hits 18465 18944 +479
- Misses 16562 16581 +19
- Partials 945 949 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `57.95% <0.00%> (-1.35%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `69.56% <0.00%> (-0.22%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [...toolkit/activation/trace/SegmentIDInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvU2VnbWVudElESW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pm/toolkit/activation/trace/SpanIDInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvU3BhbklESW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...olkit/activation/trace/TraceContextActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvVHJhY2VDb250ZXh0QWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...m/toolkit/activation/trace/TraceIDInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvVHJhY2VJREludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| ... and [153 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `7.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 49.19% 56.31% +7.12%
+ Complexity 3448 747 -2701
============================================
Files 944 161 -783
Lines 23421 3898 -19523
Branches 2301 459 -1842
============================================
- Hits 11521 2195 -9326
+ Misses 10890 1425 -9465
+ Partials 1010 278 -732
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `46.29% <0.00%> (-29.63%)` | `8.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `75.00% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...ing/apm/agent/core/context/trace/TraceSegment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnQuamF2YQ==) | `65.00% <0.00%> (-12.50%)` | `8.00% <0.00%> (-2.00%)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `66.66% <0.00%> (-11.12%)` | `3.00% <0.00%> (-1.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `53.57% <0.00%> (-7.15%)` | `5.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-6.82%)` | `18.00% <0.00%> (ø%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `39.81% <0.00%> (-6.49%)` | `13.00% <0.00%> (-3.00%)` | |
| ... and [789 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.27%`.
> The diff coverage is `26.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 39.05% -12.28%
+ Complexity 3535 2815 -720
=============================================
Files 1700 947 -753
Lines 35972 23215 -12757
Branches 3975 2285 -1690
=============================================
- Hits 18465 9067 -9398
+ Misses 16562 13364 -3198
+ Partials 945 784 -161
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `51.20%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 943 169 -774
Lines 23398 4100 -19298
Branches 2270 476 -1794
============================================
- Hits 11980 0 -11980
+ Misses 10405 4100 -6305
+ Partials 1013 0 -1013
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [917 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r556279434
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/log/LogReportServiceClient.java
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.log;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.skywalking.apm.agent.core.boot.BootService;
+import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.remote.GRPCStreamServiceStatus;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.commons.datacarrier.DataCarrier;
+import org.apache.skywalking.apm.commons.datacarrier.buffer.BufferStrategy;
+import org.apache.skywalking.apm.commons.datacarrier.consumer.IConsumer;
+import org.apache.skywalking.apm.network.common.v3.Commands;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogReportServiceGrpc;
+
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.StatusRuntimeException;
+import io.grpc.stub.StreamObserver;
+
+@DefaultImplementor
+public class LogReportServiceClient implements BootService, IConsumer<LogData> {
Review comment:
There is a core problem is gRPC lib would be shaded in the core. when having gRPC reference in optional plugins, the exception call `class not found ` would be occurring. @wu-sheng Do you have any good ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (0e72394) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `15.89%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 36.57% -15.90%
+ Complexity 3739 2476 -1263
=============================================
Files 1721 939 -782
Lines 36530 23143 -13387
Branches 4029 2255 -1774
=============================================
- Hits 19168 8465 -10703
+ Misses 16414 14022 -2392
+ Partials 948 656 -292
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (af63aae) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `42.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 42.57% 0.00% -42.58%
============================================
Files 944 198 -746
Lines 23262 4663 -18599
Branches 2256 546 -1710
============================================
- Hits 9903 0 -9903
+ Misses 12493 4663 -7830
+ Partials 866 0 -866
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [927 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r558932388
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logback-1.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/logback/v1/x/log/GRPCLogAppenderInterceptor.java
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.logback.v1.x.log;
+
+import java.lang.reflect.Method;
+import java.util.Objects;
+
+import org.apache.skywalking.apm.agent.core.boot.ServiceManager;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.remote.LogReportServiceClient;
+import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogDataBody;
+import org.apache.skywalking.apm.network.logging.v3.LogTags;
+import org.apache.skywalking.apm.network.logging.v3.TextLog;
+import org.apache.skywalking.apm.network.logging.v3.TraceContext;
+
+import ch.qos.logback.classic.spi.ILoggingEvent;
+
+public class GRPCLogAppenderInterceptor implements InstanceMethodsAroundInterceptor {
+
+ private LogReportServiceClient client;
+
+ @Override
+ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+ if (Objects.isNull(client)) {
+ client = ServiceManager.INSTANCE.findService(LogReportServiceClient.class);
+ if (Objects.isNull(client)) {
+ return;
+ }
+ }
+ ILoggingEvent event = (ILoggingEvent) allArguments[0];
+ if (Objects.nonNull(event)) {
+ client.produce(transform(event));
+ }
+ }
+
+ @Override
+ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ Object ret) throws Throwable {
+ return ret;
+ }
+
+ @Override
+ public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments,
+ Class<?>[] argumentsTypes, Throwable t) {
+
+ }
+
+ private LogData transform(ILoggingEvent event) {
+ return LogData.newBuilder()
+ .setTimestamp(event.getTimeStamp())
+ .setService(Config.Agent.SERVICE_NAME)
+ .setServiceInstance(Config.Agent.INSTANCE_NAME)
+ .setTraceContext(TraceContext.newBuilder()
+ .setTraceId(ContextManager.getGlobalTraceId())
+ .setSpanId(ContextManager.getSpanId())
+ .setTraceSegmentId(ContextManager.getSegmentId())
Review comment:
https://github.com/apache/skywalking/blob/9021e6791229e8dd81ffaf7b77cb9f567723d0b6/oap-server/analyzer/log-analyzer/src/main/java/org/apache/skywalking/oap/log/analyzer/provider/log/listener/RecordAnalysisListener.java#L85-L92
Now `N/A` is not filtered, I will submit a PR fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559295473
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logging-common/src/main/java/org/apache/skywalking/apm/toolkit/logging/common/log/GRPCLogReportServiceClient.java
##########
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.logging.common.log;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.remote.GRPCStreamServiceStatus;
+import org.apache.skywalking.apm.agent.core.remote.LogReportServiceClient;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.commons.datacarrier.DataCarrier;
+import org.apache.skywalking.apm.commons.datacarrier.buffer.BufferStrategy;
+import org.apache.skywalking.apm.network.common.v3.Commands;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogReportServiceGrpc;
+
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.StatusRuntimeException;
+import io.grpc.stub.StreamObserver;
+
+/**
+ * Report log to server by grpc
+ */
+@OverrideImplementor(LogReportServiceClient.class)
+public class GRPCLogReportServiceClient extends LogReportServiceClient {
+
+ private static final ILog LOGGER = LogManager.getLogger(GRPCLogReportServiceClient.class);
+
+ private volatile DataCarrier<LogData> carrier;
+
+ private LogReportServiceGrpc.LogReportServiceStub asyncStub;
+
+ private ManagedChannel channel;
+
+ private AtomicBoolean disconnected = new AtomicBoolean(false);
+
+ @Override
+ public void boot() throws Throwable {
+ carrier = new DataCarrier<>("gRPC-log", "gRPC-log", Config.Buffer.CHANNEL_SIZE, Config.Buffer.BUFFER_SIZE,
+ BufferStrategy.IF_POSSIBLE);
+ carrier.consume(this, 1);
+ channel = ManagedChannelBuilder
+ .forAddress(ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_HOST,
+ ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_PORT).usePlaintext().build();
+ asyncStub = LogReportServiceGrpc.newStub(channel)
+ .withMaxOutboundMessageSize(ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.MAX_MESSAGE_SIZE);
+ }
+
+ @Override
+ public void shutdown() {
+ try {
+ if (channel != null) {
+ channel.shutdownNow();
+ }
+ carrier.shutdownConsumers();
+ } catch (Throwable t) {
+ LOGGER.error(t.getMessage(), t);
+ }
+ }
+
+ @Override
+ public void produce(LogData logData) {
+ if (Objects.nonNull(logData) && !carrier.produce(logData)) {
+ if (LOGGER.isDebugEnable()) {
+ LOGGER.debug("One log has been abandoned, cause by buffer is full.");
+ }
+ }
+ }
+
+ @Override
+ public void consume(final List<LogData> dataList) {
+ if (CollectionUtil.isEmpty(dataList)) {
+ return;
+ }
+ StreamObserver<LogData> reportStreamObserver = null;
+ final GRPCStreamServiceStatus waitStatus = new GRPCStreamServiceStatus(false);
+ try {
+ reportStreamObserver = asyncStub.withDeadlineAfter(
+ ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.UPSTREAM_TIMEOUT, TimeUnit.SECONDS
+ ).collect(new StreamObserver<Commands>() {
+ @Override
+ public void onNext(Commands commands) {
+ }
+
+ @Override
+ public void onError(Throwable t) {
+ waitStatus.finished();
+ if (!disconnected.get()) {
+ LOGGER.error("Send log to gRPC server fail with an internal exception.", t);
+ disconnected.set(true);
+ }
Review comment:
`disconnected` may be unnecessary, but if it's really needed, it should be
```suggestion
if (disconnected.compareAndSet(false, true)) {
LOGGER.error("Send log to gRPC server fail with an internal exception.", t);
}
```
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logging-common/src/main/java/org/apache/skywalking/apm/toolkit/logging/common/log/GRPCLogReportServiceClient.java
##########
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.logging.common.log;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.remote.GRPCStreamServiceStatus;
+import org.apache.skywalking.apm.agent.core.remote.LogReportServiceClient;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.commons.datacarrier.DataCarrier;
+import org.apache.skywalking.apm.commons.datacarrier.buffer.BufferStrategy;
+import org.apache.skywalking.apm.network.common.v3.Commands;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogReportServiceGrpc;
+
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.StatusRuntimeException;
+import io.grpc.stub.StreamObserver;
+
+/**
+ * Report log to server by grpc
+ */
+@OverrideImplementor(LogReportServiceClient.class)
+public class GRPCLogReportServiceClient extends LogReportServiceClient {
+
+ private static final ILog LOGGER = LogManager.getLogger(GRPCLogReportServiceClient.class);
+
+ private volatile DataCarrier<LogData> carrier;
+
+ private LogReportServiceGrpc.LogReportServiceStub asyncStub;
+
+ private ManagedChannel channel;
+
+ private AtomicBoolean disconnected = new AtomicBoolean(false);
+
+ @Override
+ public void boot() throws Throwable {
+ carrier = new DataCarrier<>("gRPC-log", "gRPC-log", Config.Buffer.CHANNEL_SIZE, Config.Buffer.BUFFER_SIZE,
+ BufferStrategy.IF_POSSIBLE);
+ carrier.consume(this, 1);
+ channel = ManagedChannelBuilder
+ .forAddress(ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_HOST,
+ ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_PORT).usePlaintext().build();
+ asyncStub = LogReportServiceGrpc.newStub(channel)
+ .withMaxOutboundMessageSize(ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.MAX_MESSAGE_SIZE);
+ }
+
+ @Override
+ public void shutdown() {
+ try {
+ if (channel != null) {
+ channel.shutdownNow();
+ }
+ carrier.shutdownConsumers();
+ } catch (Throwable t) {
+ LOGGER.error(t.getMessage(), t);
+ }
+ }
+
+ @Override
+ public void produce(LogData logData) {
+ if (Objects.nonNull(logData) && !carrier.produce(logData)) {
+ if (LOGGER.isDebugEnable()) {
+ LOGGER.debug("One log has been abandoned, cause by buffer is full.");
+ }
+ }
+ }
+
+ @Override
+ public void consume(final List<LogData> dataList) {
+ if (CollectionUtil.isEmpty(dataList)) {
+ return;
+ }
+ StreamObserver<LogData> reportStreamObserver = null;
+ final GRPCStreamServiceStatus waitStatus = new GRPCStreamServiceStatus(false);
+ try {
+ reportStreamObserver = asyncStub.withDeadlineAfter(
+ ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.UPSTREAM_TIMEOUT, TimeUnit.SECONDS
+ ).collect(new StreamObserver<Commands>() {
+ @Override
+ public void onNext(Commands commands) {
+ }
+
+ @Override
+ public void onError(Throwable t) {
+ waitStatus.finished();
+ if (!disconnected.get()) {
+ LOGGER.error("Send log to gRPC server fail with an internal exception.", t);
+ disconnected.set(true);
+ }
+
+ LOGGER.error(t, "Try to send {} log data to collector, with unexpected exception.",
+ dataList.size());
+ }
+
+ @Override
+ public void onCompleted() {
+ if (disconnected.get()) {
+ disconnected.set(false);
+ }
Review comment:
ditto
```suggestion
disconnected.compareAndSet(true, false)
```
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logging-common/src/main/java/org/apache/skywalking/apm/toolkit/logging/common/log/GRPCLogReportServiceClient.java
##########
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.logging.common.log;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.remote.GRPCStreamServiceStatus;
+import org.apache.skywalking.apm.agent.core.remote.LogReportServiceClient;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.commons.datacarrier.DataCarrier;
+import org.apache.skywalking.apm.commons.datacarrier.buffer.BufferStrategy;
+import org.apache.skywalking.apm.network.common.v3.Commands;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogReportServiceGrpc;
+
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.StatusRuntimeException;
+import io.grpc.stub.StreamObserver;
+
+/**
+ * Report log to server by grpc
+ */
+@OverrideImplementor(LogReportServiceClient.class)
+public class GRPCLogReportServiceClient extends LogReportServiceClient {
+
+ private static final ILog LOGGER = LogManager.getLogger(GRPCLogReportServiceClient.class);
+
+ private volatile DataCarrier<LogData> carrier;
+
+ private LogReportServiceGrpc.LogReportServiceStub asyncStub;
+
+ private ManagedChannel channel;
+
+ private AtomicBoolean disconnected = new AtomicBoolean(false);
+
+ @Override
+ public void boot() throws Throwable {
+ carrier = new DataCarrier<>("gRPC-log", "gRPC-log", Config.Buffer.CHANNEL_SIZE, Config.Buffer.BUFFER_SIZE,
+ BufferStrategy.IF_POSSIBLE);
+ carrier.consume(this, 1);
+ channel = ManagedChannelBuilder
+ .forAddress(ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_HOST,
+ ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.SERVER_PORT).usePlaintext().build();
+ asyncStub = LogReportServiceGrpc.newStub(channel)
+ .withMaxOutboundMessageSize(ToolkitConfig.Plugin.Toolkit.Log.GRPC.Reporter.MAX_MESSAGE_SIZE);
+ }
+
+ @Override
+ public void shutdown() {
+ try {
+ if (channel != null) {
+ channel.shutdownNow();
+ }
+ carrier.shutdownConsumers();
Review comment:
Should shut down consumers first
```suggestion
carrier.shutdownConsumers();
if (channel != null) {
channel.shutdownNow();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `6.63%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 44.57% -6.64%
+ Complexity 3544 3096 -448
============================================
Files 943 948 +5
Lines 23398 23289 -109
Branches 2270 2247 -23
============================================
- Hits 11980 10380 -1600
- Misses 10405 12066 +1661
+ Partials 1013 843 -170
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [133 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (f9d4c6e) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `6.02%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 46.44% -6.03%
+ Complexity 3739 3221 -518
============================================
Files 1721 945 -776
Lines 36530 23108 -13422
Branches 4029 2274 -1755
============================================
- Hits 19168 10732 -8436
+ Misses 16414 11443 -4971
+ Partials 948 933 -15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1251 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (fa69253) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 196 -1525
Lines 36530 4537 -31993
Branches 4029 534 -3495
============================================
- Hits 19168 0 -19168
+ Misses 16414 4537 -11877
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1695 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `0.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 51.50% -0.97%
+ Complexity 3739 3670 -69
============================================
Files 1721 1720 -1
Lines 36530 36463 -67
Branches 4029 4041 +12
============================================
- Hits 19168 18781 -387
- Misses 16414 16731 +317
- Partials 948 951 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-82.61%)` | `0.00% <0.00%> (-5.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `16.12% <0.00%> (-77.42%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-76.48%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-3.00%)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `5.82% <0.00%> (-67.97%)` | `1.00% <0.00%> (-8.00%)` | |
| [.../analyzer/provider/log/LogAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `5.76%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 42.57% 48.34% +5.76%
- Complexity 3012 3391 +379
============================================
Files 944 968 +24
Lines 23262 23750 +488
Branches 2256 2337 +81
============================================
+ Hits 9903 11481 +1578
+ Misses 12493 11291 -1202
- Partials 866 978 +112
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...nual/errorlog/BrowserErrorLogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvZXJyb3Jsb2cvQnJvd3NlckVycm9yTG9nUmVjb3JkRGlzcGF0Y2hlci5qYXZh) | `7.69% <0.00%> (-92.31%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [217 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1ed6e80](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `0.85%`.
> The diff coverage is `51.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 50.47% -0.86%
+ Complexity 3535 3469 -66
============================================
Files 1700 946 -754
Lines 35972 23409 -12563
Branches 3975 2295 -1680
============================================
- Hits 18465 11815 -6650
+ Misses 16562 10576 -5986
- Partials 945 1018 +73
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| ... and [1277 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (215aded) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `14.34%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 38.23% -14.35%
+ Complexity 3740 2675 -1065
=============================================
Files 1718 964 -754
Lines 36447 23636 -12811
Branches 4035 2331 -1704
=============================================
- Hits 19164 9038 -10126
+ Misses 16336 13900 -2436
+ Partials 947 698 -249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1283 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...215aded](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r558879841
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-common/src/main/java/org/apache/skywalking/apm/toolkit/common/log/GRPCLogReportServiceClient.java
##########
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.common.log;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.skywalking.apm.agent.core.boot.OverrideImplementor;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.remote.GRPCStreamServiceStatus;
+import org.apache.skywalking.apm.agent.core.remote.LogReportServiceClient;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.commons.datacarrier.DataCarrier;
+import org.apache.skywalking.apm.commons.datacarrier.buffer.BufferStrategy;
+import org.apache.skywalking.apm.network.common.v3.Commands;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogReportServiceGrpc;
+
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.StatusRuntimeException;
+import io.grpc.stub.StreamObserver;
+
+/**
+ * Report log to server by grpc
+ */
+@OverrideImplementor(LogReportServiceClient.class)
+public class GRPCLogReportServiceClient extends LogReportServiceClient {
+
+ private static final ILog LOGGER = LogManager.getLogger(GRPCLogReportServiceClient.class);
+
+ private volatile DataCarrier<LogData> carrier;
+
+ private LogReportServiceGrpc.LogReportServiceStub asyncStub;
+
+ private ManagedChannel channel;
+
+ private AtomicBoolean disconnected = new AtomicBoolean(false);
+
+ @Override
+ public void boot() throws Throwable {
+ carrier = new DataCarrier<>("gRPC-log", "gRPC-log", Config.Buffer.CHANNEL_SIZE, Config.Buffer.BUFFER_SIZE,
+ BufferStrategy.IF_POSSIBLE);
+ carrier.consume(this, 1);
+ channel = ManagedChannelBuilder
+ .forAddress(GRPCLogConfig.Plugin.GRPCLog.SERVER_HOST, GRPCLogConfig.Plugin.GRPCLog.SERVER_PORT)
+ .usePlaintext().build();
+ asyncStub = LogReportServiceGrpc.newStub(channel)
+ .withMaxOutboundMessageSize(GRPCLogConfig.Plugin.GRPCLog.MAX_MESSAGE_SIZE);
+ }
+
+ @Override
+ public void shutdown() {
+ try {
+ if (channel != null) {
+ channel.shutdownNow();
+ }
+ carrier.shutdownConsumers();
+ } catch (Throwable t) {
+ LOGGER.error(t.getMessage(), t);
+ }
+ }
+
+ @Override
+ public void produce(LogData logData) {
+ if (Objects.nonNull(logData)) {
+ if (!carrier.produce(logData)) {
Review comment:
`!carrier.produce(logData)` is not a warning, it is only considered a warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `21.11%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 31.35% -21.12%
+ Complexity 3739 2145 -1594
=============================================
Files 1721 932 -789
Lines 36530 22776 -13754
Branches 4029 2205 -1824
=============================================
- Hits 19168 7141 -12027
+ Misses 16414 15078 -1336
+ Partials 948 557 -391
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1339 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (017fff5) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `21.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.19% 29.98% -21.22%
+ Complexity 2900 2030 -870
=============================================
Files 1700 908 -792
Lines 35973 22365 -13608
Branches 4141 2174 -1967
=============================================
- Hits 18417 6706 -11711
+ Misses 16605 15144 -1461
+ Partials 951 515 -436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1313 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `1.17%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 52.47% 53.64% +1.17%
+ Complexity 3739 3688 -51
============================================
Files 1721 949 -772
Lines 36530 23520 -13010
Branches 4029 2311 -1718
============================================
- Hits 19168 12617 -6551
+ Misses 16414 9806 -6608
- Partials 948 1097 +149
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/oap/server/core/cluster/OAPNodeChecker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9PQVBOb2RlQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (-93.75%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1196 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `29.55%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 55.07% 25.52% -29.56%
+ Complexity 3739 1760 -1979
=============================================
Files 944 932 -12
Lines 23462 22738 -724
Branches 2307 2202 -105
=============================================
- Hits 12922 5804 -7118
- Misses 9433 16518 +7085
+ Partials 1107 416 -691
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [435 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.66%`.
> The diff coverage is `23.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 38.66% -12.67%
+ Complexity 3535 2746 -789
=============================================
Files 1700 926 -774
Lines 35972 22801 -13171
Branches 3975 2216 -1759
=============================================
- Hits 18465 8817 -9648
+ Misses 16562 13206 -3356
+ Partials 945 778 -167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `20.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **increase** coverage by `1.85%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 52.58% 54.43% +1.85%
+ Complexity 3740 3707 -33
============================================
Files 1718 944 -774
Lines 36447 23349 -13098
Branches 4035 2295 -1740
============================================
- Hits 19164 12709 -6455
+ Misses 16336 9569 -6767
- Partials 947 1071 +124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-16.24%)` | `25.00 <0.00> (ø)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1202 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (fa69253) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `21.25%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 31.21% -21.26%
+ Complexity 3739 2159 -1580
=============================================
Files 1721 950 -771
Lines 36530 23153 -13377
Branches 4029 2267 -1762
=============================================
- Hits 19168 7227 -11941
+ Misses 16414 15397 -1017
+ Partials 948 529 -419
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1339 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.27%`.
> The diff coverage is `26.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 39.05% -12.28%
+ Complexity 3535 2816 -719
=============================================
Files 1700 948 -752
Lines 35972 23220 -12752
Branches 3975 2285 -1690
=============================================
- Hits 18465 9069 -9396
+ Misses 16562 13368 -3194
+ Partials 945 783 -162
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5e27cbd) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `13.29%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.19% 37.90% -13.30%
+ Complexity 2900 2509 -391
=============================================
Files 1700 919 -781
Lines 35973 22762 -13211
Branches 4141 2199 -1942
=============================================
- Hits 18417 8628 -9789
+ Misses 16605 13477 -3128
+ Partials 951 657 -294
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.54%`.
> The diff coverage is `23.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 38.78% -12.55%
+ Complexity 3535 2746 -789
=============================================
Files 1700 923 -777
Lines 35972 22731 -13241
Branches 3975 2209 -1766
=============================================
- Hits 18465 8817 -9648
+ Misses 16562 13136 -3426
+ Partials 945 778 -167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `20.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559271269
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-logback-1.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/logback/v1/x/log/GRPCLogAppenderInterceptor.java
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.logback.v1.x.log;
+
+import java.lang.reflect.Method;
+import java.util.Objects;
+
+import org.apache.skywalking.apm.agent.core.boot.ServiceManager;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.remote.LogReportServiceClient;
+import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogDataBody;
+import org.apache.skywalking.apm.network.logging.v3.LogTags;
+import org.apache.skywalking.apm.network.logging.v3.TextLog;
+import org.apache.skywalking.apm.network.logging.v3.TraceContext;
+
+import ch.qos.logback.classic.spi.ILoggingEvent;
+
+public class GRPCLogAppenderInterceptor implements InstanceMethodsAroundInterceptor {
+
+ private LogReportServiceClient client;
+
+ @Override
+ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+ if (Objects.isNull(client)) {
+ client = ServiceManager.INSTANCE.findService(LogReportServiceClient.class);
+ if (Objects.isNull(client)) {
+ return;
+ }
+ }
+ ILoggingEvent event = (ILoggingEvent) allArguments[0];
+ if (Objects.nonNull(event)) {
+ client.produce(transform(event));
+ }
+ }
+
+ @Override
+ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ Object ret) throws Throwable {
+ return ret;
+ }
+
+ @Override
+ public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments,
+ Class<?>[] argumentsTypes, Throwable t) {
+
+ }
+
+ private LogData transform(ILoggingEvent event) {
+ return LogData.newBuilder()
+ .setTimestamp(event.getTimeStamp())
+ .setService(Config.Agent.SERVICE_NAME)
+ .setServiceInstance(Config.Agent.INSTANCE_NAME)
+ .setTraceContext(TraceContext.newBuilder()
+ .setTraceId(ContextManager.getGlobalTraceId())
+ .setSpanId(ContextManager.getSpanId())
+ .setTraceSegmentId(ContextManager.getSegmentId())
Review comment:
@EvanLjp @elk-g Let's finalize this, others are good now. There are `N/A`, `Ignored_Trace`, ``(EMPTY_STRING`) as trace id and segment id. -1 as span id, which all means no available trace context. Could we filter these out? At least base on `trace_id`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `0.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 51.95% -0.53%
+ Complexity 3740 3700 -40
============================================
Files 1721 1720 -1
Lines 36530 36463 -67
Branches 4029 4041 +12
============================================
- Hits 19170 18943 -227
- Misses 16412 16571 +159
- Partials 948 949 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-82.61%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-76.48%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-3.00%)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `5.82% <0.00%> (-67.97%)` | `1.00% <0.00%> (-8.00%)` | |
| [.../analyzer/provider/log/LogAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...provider/log/listener/TrafficAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvVHJhZmZpY0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `22.85% <0.00%> (-62.86%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.42% <0.00%> (-53.58%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `1.73%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 49.46% -1.74%
+ Complexity 3544 3455 -89
============================================
Files 943 948 +5
Lines 23398 23448 +50
Branches 2270 2278 +8
============================================
- Hits 11980 11599 -381
- Misses 10405 10860 +455
+ Partials 1013 989 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [65 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `0.86%`.
> The diff coverage is `3.46%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 50.33% -0.87%
- Complexity 3544 3566 +22
============================================
Files 943 1735 +792
Lines 23398 36790 +13392
Branches 2270 4060 +1790
============================================
+ Hits 11980 18517 +6537
- Misses 10405 17319 +6914
+ Partials 1013 954 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...logging/common/log/GRPCLogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9sb2dnaW5nL2NvbW1vbi9sb2cvR1JQQ0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...c38fcdd](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `5.06%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 46.13% -5.07%
+ Complexity 3544 3220 -324
============================================
Files 943 948 +5
Lines 23398 23307 -91
Branches 2270 2248 -22
============================================
- Hits 11980 10752 -1228
- Misses 10405 11666 +1261
+ Partials 1013 889 -124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [105 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r557425692
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-1.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.log4j.v1.x.log;
+
+import java.lang.reflect.Method;
+import java.util.Objects;
+import java.util.Optional;
+
+import org.apache.skywalking.apm.agent.core.boot.ServiceManager;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair;
+import org.apache.skywalking.apm.network.logging.v3.JSONLog;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogDataBody;
+import org.apache.skywalking.apm.network.logging.v3.TextLog;
+import org.apache.skywalking.apm.network.logging.v3.TraceContext;
+import org.apache.skywalking.apm.network.logging.v3.YAMLLog;
+import org.apache.skywalking.apm.toolkit.common.log.GRPCLogConfig;
+import org.apache.skywalking.apm.toolkit.common.log.LogReportServiceClient;
+import org.slf4j.event.LoggingEvent;
+
+public class GRPCLogAppenderInterceptor implements InstanceMethodsAroundInterceptor {
+
+ private LogReportServiceClient client;
+
+ @Override
+ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+ if (Objects.isNull(client)) {
+ client = ServiceManager.INSTANCE.findService(LogReportServiceClient.class);
+ if (Objects.isNull(client)) {
+ return;
+ }
+ }
+ LoggingEvent event = (LoggingEvent) allArguments[0];
+ if (event != null) {
+ LogData logData = transform(event);
+ if (Objects.nonNull(logData)) {
+ client.produce(logData);
+ }
+ }
+ }
+
+ @Override
+ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ Object ret) throws Throwable {
+ return ret;
+ }
+
+ @Override
+ public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments,
+ Class<?>[] argumentsTypes, Throwable t) {
+
+ }
+
+ private LogData transform(LoggingEvent event) {
+ if (Objects.isNull(event)) {
+ return null;
+ }
+ LogData.Builder logBuilder = LogData.newBuilder()
+ .setTimestamp(event.getTimeStamp())
+ .setService(Config.Agent.SERVICE_NAME)
+ .setServiceInstance(Config.Agent.INSTANCE_NAME)
+ .setTraceContext(TraceContext.newBuilder()
+ .setTraceId(ContextManager.getGlobalTraceId()).build())
+ .addTags(KeyStringValuePair.newBuilder()
+ .setKey("level").setValue(event.getLevel().toString()).build())
+ .addTags(KeyStringValuePair.newBuilder()
+ .setKey("logger").setValue(event.getLoggerName()).build())
+ .addTags(KeyStringValuePair.newBuilder()
+ .setKey("thread").setValue(event.getThreadName()).build());
+
+ LogDataBody.Builder logDataBodyBuilder = LogDataBody.newBuilder();
+ LogDataBody.ContentCase contentType = Optional.ofNullable(LogDataBody.ContentCase.forNumber(
+ GRPCLogConfig.Plugin.GRPCLog.LOG_BODY_TYPE)).orElse(LogDataBody.ContentCase.TEXT);
Review comment:
Doesn't log framework provide the content format? Right now, it seems based on manual configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] elk-g commented on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
elk-g commented on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-761760457
> > 2021-01-17T09:08:19.9531484Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project apm-toolkit-logging-common: Error creating shaded jar: duplicate entry: META-INF/services/org.apache.skywalking.apm.dependencies.io.grpc.ServerProvider -> [Help 1]
>
> Seems you are facing package issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `51.20%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 943 173 -770
Lines 23398 4130 -19268
Branches 2270 480 -1790
============================================
- Hits 11980 0 -11980
+ Misses 10405 4130 -6275
+ Partials 1013 0 -1013
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [911 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (1137970) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 177 -1544
Lines 36530 4268 -32262
Branches 4029 492 -3537
============================================
- Hits 19168 0 -19168
+ Misses 16414 4268 -12146
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1694 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **increase** coverage by `3.54%`.
> The diff coverage is `53.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.33% 54.87% +3.54%
- Complexity 3535 3738 +203
============================================
Files 1700 946 -754
Lines 35972 23475 -12497
Branches 3975 2302 -1673
============================================
- Hits 18465 12882 -5583
+ Misses 16562 9506 -7056
- Partials 945 1087 +142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `2.63% <0.00%> (-1.54%)` | `1.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/TraceQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVHJhY2VRdWVyeUVzREFPLmphdmE=) | `33.33% <0.00%> (+0.83%)` | `3.00 <0.00> (ø)` | |
| ... and [1288 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559087652
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/LogReportServiceClient.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.remote;
+
+import java.util.List;
+
+import org.apache.skywalking.apm.agent.core.boot.BootService;
+import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
+import org.apache.skywalking.apm.commons.datacarrier.consumer.IConsumer;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+
+@DefaultImplementor
+public class LogReportServiceClient implements BootService, IConsumer<LogData> {
+
+ @Override
+ public void prepare() throws Throwable {
+
+ }
+
+ @Override
+ public void boot() throws Throwable {
+
+ }
+
+ @Override
+ public void onComplete() throws Throwable {
+
+ }
+
+ @Override
+ public void shutdown() throws Throwable {
+
+ }
+
+ @Override
+ public void init() {
+
+ }
+
+ public void produce(LogData logData) {
+
+ }
Review comment:
I know you need to. My question is, why need this in core default empty service?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (017fff5) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `21.68%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.19% 29.51% -21.69%
+ Complexity 2900 2034 -866
=============================================
Files 1700 926 -774
Lines 35973 22751 -13222
Branches 4141 2225 -1916
=============================================
- Hits 18417 6714 -11703
+ Misses 16605 15523 -1082
+ Partials 951 514 -437
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1317 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r556280881
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/log/LogReportServiceClient.java
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.log;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.skywalking.apm.agent.core.boot.BootService;
+import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.remote.GRPCStreamServiceStatus;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.commons.datacarrier.DataCarrier;
+import org.apache.skywalking.apm.commons.datacarrier.buffer.BufferStrategy;
+import org.apache.skywalking.apm.commons.datacarrier.consumer.IConsumer;
+import org.apache.skywalking.apm.network.common.v3.Commands;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogReportServiceGrpc;
+
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.StatusRuntimeException;
+import io.grpc.stub.StreamObserver;
+
+@DefaultImplementor
+public class LogReportServiceClient implements BootService, IConsumer<LogData> {
Review comment:
It sounds great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (f9d4c6e) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 192 -1529
Lines 36530 4489 -32041
Branches 4029 530 -3499
============================================
- Hits 19168 0 -19168
+ Misses 16414 4489 -11925
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1697 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (0e72394) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `16.05%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 36.41% -16.06%
+ Complexity 3739 2470 -1269
=============================================
Files 1721 937 -784
Lines 36530 23131 -13399
Branches 4029 2255 -1774
=============================================
- Hits 19168 8423 -10745
+ Misses 16414 14054 -2360
+ Partials 948 654 -294
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (017fff5) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `51.19%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.19% 0.00% -51.20%
============================================
Files 1700 170 -1530
Lines 35973 4182 -31791
Branches 4141 485 -3656
============================================
- Hits 18417 0 -18417
+ Misses 16605 4182 -12423
+ Partials 951 0 -951
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1680 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (342f1be) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `7.07%`.
> The diff coverage is `25.95%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 44.25% -7.08%
+ Complexity 3535 3114 -421
============================================
Files 1700 944 -756
Lines 35972 23340 -12632
Branches 3975 2283 -1692
============================================
- Hits 18465 10329 -8136
+ Misses 16562 12136 -4426
+ Partials 945 875 -70
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (741517c) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `7.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 45.12% -7.36%
+ Complexity 3739 2608 -1131
============================================
Files 1721 784 -937
Lines 36530 19585 -16945
Branches 4029 1862 -2167
============================================
- Hits 19168 8837 -10331
+ Misses 16414 10050 -6364
+ Partials 948 698 -250
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1304 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...741517c](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `0.86%`.
> The diff coverage is `3.46%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 50.33% -0.87%
- Complexity 3544 3566 +22
============================================
Files 943 1735 +792
Lines 23398 36790 +13392
Branches 2270 4060 +1790
============================================
+ Hits 11980 18517 +6537
- Misses 10405 17319 +6914
+ Partials 1013 954 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...logging/common/log/GRPCLogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9sb2dnaW5nL2NvbW1vbi9sb2cvR1JQQ0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (beb483a) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `2.78%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 42.57% 39.78% -2.79%
+ Complexity 3012 2781 -231
============================================
Files 944 913 -31
Lines 23262 22450 -812
Branches 2256 2197 -59
============================================
- Hits 9903 8931 -972
- Misses 12493 12735 +242
+ Partials 866 784 -82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [248 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `2.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 49.65% -2.83%
+ Complexity 3739 3452 -287
============================================
Files 1721 1720 -1
Lines 36530 36449 -81
Branches 4029 4041 +12
============================================
- Hits 19168 18097 -1071
- Misses 16414 17395 +981
- Partials 948 957 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| ... and [88 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **increase** coverage by `0.91%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.20% 52.11% +0.91%
- Complexity 3544 3566 +22
============================================
Files 943 943
Lines 23398 23424 +26
Branches 2270 2300 +30
============================================
+ Hits 11980 12207 +227
+ Misses 10405 10176 -229
- Partials 1013 1041 +28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...nual/errorlog/BrowserErrorLogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvZXJyb3Jsb2cvQnJvd3NlckVycm9yTG9nUmVjb3JkRGlzcGF0Y2hlci5qYXZh) | `7.69% <0.00%> (-92.31%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ser/provider/parser/errorlog/ErrorLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9FcnJvckxvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ance/BrowserAppSingleVersionTrafficDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvaW5zdGFuY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25UcmFmZmljRGlzcGF0Y2hlci5qYXZh) | `12.50% <0.00%> (-87.50%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [122 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `6.33%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.58% 46.24% -6.34%
+ Complexity 3740 3248 -492
============================================
Files 1718 942 -776
Lines 36447 23249 -13198
Branches 4035 2282 -1753
============================================
- Hits 19164 10751 -8413
+ Misses 16336 11579 -4757
+ Partials 947 919 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-16.13%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <0.00%> (-21.15%)` | `23.00 <0.00> (-2.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1259 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r558934465
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-common/pom.xml
##########
@@ -0,0 +1,102 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>apm-toolkit-activation</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.4.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>apm-toolkit-common</artifactId>
+
+ <properties>
+ <shade.com.google.source>com.google</shade.com.google.source>
+ <shade.com.google.target>${shade.package}.${shade.com.google.source}</shade.com.google.target>
+ <shade.io.grpc.source>io.grpc</shade.io.grpc.source>
+ <shade.io.grpc.target>${shade.package}.${shade.io.grpc.source}</shade.io.grpc.target>
+ <shade.io.netty.source>io.netty</shade.io.netty.source>
+ <shade.io.netty.target>${shade.package}.${shade.io.netty.source}</shade.io.netty.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>apm-network</artifactId>
+ <version>${project.version}</version>
Review comment:
https://github.com/elk-g/skywalking/blob/c6fc54a1e38adc77e5619135586644cd0f880f7a/apm-sniffer/apm-toolkit-activation/apm-toolkit-common/pom.xml#L49-L99
Is it here? I don't see the difference with [apm-agent-core](https://github.com/apache/skywalking/blob/9021e6791229e8dd81ffaf7b77cb9f567723d0b6/apm-sniffer/apm-agent-core/pom.xml#L171-L232).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (0e72394) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 170 -1551
Lines 36530 4113 -32417
Branches 4029 480 -3549
============================================
- Hits 19168 0 -19168
+ Misses 16414 4113 -12301
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1698 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r558902051
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-common/pom.xml
##########
@@ -0,0 +1,102 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>apm-toolkit-activation</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.4.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>apm-toolkit-common</artifactId>
+
+ <properties>
+ <shade.com.google.source>com.google</shade.com.google.source>
+ <shade.com.google.target>${shade.package}.${shade.com.google.source}</shade.com.google.target>
+ <shade.io.grpc.source>io.grpc</shade.io.grpc.source>
+ <shade.io.grpc.target>${shade.package}.${shade.io.grpc.source}</shade.io.grpc.target>
+ <shade.io.netty.source>io.netty</shade.io.netty.source>
+ <shade.io.netty.target>${shade.package}.${shade.io.netty.source}</shade.io.netty.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>apm-network</artifactId>
+ <version>${project.version}</version>
Review comment:
Hi @elk-g [apm-agent-core](https://github.com/apache/skywalking/blob/9021e6791229e8dd81ffaf7b77cb9f567723d0b6/apm-sniffer/apm-agent-core/pom.xml#L58-L62) already dependency on `apm-network`, is it repeated? If I miss something, please let me know :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5097ca7) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `23.24%`.
> The diff coverage is `1.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 29.22% -23.25%
=============================================
Files 1721 1641 -80
Lines 36530 34200 -2330
Branches 4029 4525 +496
=============================================
- Hits 19168 9996 -9172
- Misses 16414 23274 +6860
+ Partials 948 930 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...logging/common/log/GRPCLogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9sb2dnaW5nL2NvbW1vbi9sb2cvR1JQQ0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [811 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...986f606](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (f9d4c6e) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 193 -1528
Lines 36530 4493 -32037
Branches 4029 530 -3499
============================================
- Hits 19168 0 -19168
+ Misses 16414 4493 -11921
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1697 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] elk-g commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
elk-g commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559004662
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/LogReportServiceClient.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.remote;
+
+import java.util.List;
+
+import org.apache.skywalking.apm.agent.core.boot.BootService;
+import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
+import org.apache.skywalking.apm.commons.datacarrier.consumer.IConsumer;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+
+@DefaultImplementor
+public class LogReportServiceClient implements BootService, IConsumer<LogData> {
+
+ @Override
+ public void prepare() throws Throwable {
+
+ }
+
+ @Override
+ public void boot() throws Throwable {
+
+ }
+
+ @Override
+ public void onComplete() throws Throwable {
+
+ }
+
+ @Override
+ public void shutdown() throws Throwable {
+
+ }
+
+ @Override
+ public void init() {
+
+ }
+
+ public void produce(LogData logData) {
+
+ }
Review comment:
`GRPCLogReportServiceClient` needs to produce `LogData` to `DataCarrier` and consume it by sending it to the gRPC server. In the `apm-toolkit-activation` module, `GRPCLogClientAppender` produce `LogData` by `LogReportServiceClient`, so add this method in here and implement the interface `IConsumer<LogData>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `3.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 49.25% -3.22%
+ Complexity 3739 3426 -313
============================================
Files 1721 1720 -1
Lines 36530 36448 -82
Branches 4029 4041 +12
============================================
- Hits 19168 17954 -1214
- Misses 16414 17539 +1125
- Partials 948 955 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [102 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `29.55%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 55.07% 25.52% -29.56%
+ Complexity 3739 1760 -1979
=============================================
Files 944 932 -12
Lines 23462 22738 -724
Branches 2307 2202 -105
=============================================
- Hits 12922 5804 -7118
- Misses 9433 16518 +7085
+ Partials 1107 416 -691
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [435 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `51.20%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 943 174 -769
Lines 23398 4169 -19229
Branches 2270 481 -1789
============================================
- Hits 11980 0 -11980
+ Misses 10405 4169 -6236
+ Partials 1013 0 -1013
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [910 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (986f606) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `22.59%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 29.87% -22.60%
+ Complexity 3739 2086 -1653
=============================================
Files 1721 950 -771
Lines 36530 23054 -13476
Branches 4029 2238 -1791
=============================================
- Hits 19168 6888 -12280
+ Misses 16414 15605 -809
+ Partials 948 561 -387
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...986f606](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (fa69253) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `15.33%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 37.13% -15.34%
+ Complexity 3739 2559 -1180
=============================================
Files 1721 968 -753
Lines 36530 23714 -12816
Branches 4029 2336 -1693
=============================================
- Hits 19168 8806 -10362
+ Misses 16414 14224 -2190
+ Partials 948 684 -264
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1301 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (1137970) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 198 -1523
Lines 36530 4663 -31867
Branches 4029 546 -3483
============================================
- Hits 19168 0 -19168
+ Misses 16414 4663 -11751
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1692 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (342f1be) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `8.32%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.58% 44.25% -8.33%
+ Complexity 3740 3114 -626
============================================
Files 1718 944 -774
Lines 36447 23340 -13107
Branches 4035 2283 -1752
============================================
- Hits 19164 10329 -8835
+ Misses 16336 12136 -4200
+ Partials 947 875 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-16.24%)` | `25.00 <0.00> (ø)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1260 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...215aded](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (fa69253) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 198 -1523
Lines 36530 4581 -31949
Branches 4029 538 -3491
============================================
- Hits 19168 0 -19168
+ Misses 16414 4581 -11833
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1695 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (88c9dda) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `0.49%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 52.47% 52.96% +0.49%
+ Complexity 3739 3638 -101
============================================
Files 1721 939 -782
Lines 36530 23239 -13291
Branches 4029 2277 -1752
============================================
- Hits 19168 12308 -6860
+ Misses 16414 9862 -6552
- Partials 948 1069 +121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...alking/oap/server/core/cluster/OAPNodeChecker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9PQVBOb2RlQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (-93.75%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1210 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **increase** coverage by `0.19%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.20% 51.39% +0.19%
+ Complexity 3544 3528 -16
============================================
Files 943 942 -1
Lines 23398 23352 -46
Branches 2270 2283 +13
============================================
+ Hits 11980 12001 +21
+ Misses 10405 10325 -80
- Partials 1013 1026 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...nual/errorlog/BrowserErrorLogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvZXJyb3Jsb2cvQnJvd3NlckVycm9yTG9nUmVjb3JkRGlzcGF0Y2hlci5qYXZh) | `7.69% <0.00%> (-92.31%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ser/provider/parser/errorlog/ErrorLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9FcnJvckxvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ance/BrowserAppSingleVersionTrafficDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvaW5zdGFuY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25UcmFmZmljRGlzcGF0Y2hlci5qYXZh) | `12.50% <0.00%> (-87.50%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [118 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/ea8a4963a23464dafa03b6a7ce3e9d25e1d0e163?el=desc) (ea8a496) will **increase** coverage by `12.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
+ Coverage 39.41% 51.93% +12.52%
- Complexity 2761 3705 +944
=============================================
Files 912 1720 +808
Lines 22482 36474 +13992
Branches 2199 4041 +1842
=============================================
+ Hits 8861 18944 +10083
- Misses 12848 16581 +3733
- Partials 773 949 +176
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `25.92% <0.00%> (-67.41%)` | `3.00% <0.00%> (ø%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `32.43% <0.00%> (-59.88%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `17.85% <0.00%> (-37.70%)` | `2.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `84.61% <0.00%> (-15.39%)` | `4.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `60.00% <0.00%> (-15.00%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...server/core/analysis/worker/AlarmNotifyWorker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL0FsYXJtTm90aWZ5V29ya2VyLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `3.00% <0.00%> (ø%)` | |
| [.../server/core/analysis/data/ReadWriteSafeCache.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9SZWFkV3JpdGVTYWZlQ2FjaGUuamF2YQ==) | `68.18% <0.00%> (-10.77%)` | `3.00% <0.00%> (ø%)` | |
| [...lemetry/prometheus/PrometheusHistogramMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0hpc3RvZ3JhbU1ldHJpY3MuamF2YQ==) | `70.58% <0.00%> (-9.42%)` | `2.00% <0.00%> (ø%)` | |
| [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <0.00%> (-8.93%)` | `1.00% <0.00%> (ø%)` | |
| ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/ea8a4963a23464dafa03b6a7ce3e9d25e1d0e163?el=desc) (ea8a496) will **increase** coverage by `16.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
+ Coverage 35.63% 51.93% +16.30%
- Complexity 2062 3705 +1643
=============================================
Files 768 1720 +952
Lines 19102 36474 +17372
Branches 1810 4041 +2231
=============================================
+ Hits 6807 18944 +12137
- Misses 11776 16581 +4805
- Partials 519 949 +430
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `25.92% <0.00%> (-67.41%)` | `3.00% <0.00%> (ø%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `32.43% <0.00%> (-59.88%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `17.85% <0.00%> (-37.70%)` | `2.00% <0.00%> (ø%)` | |
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `84.61% <0.00%> (-15.39%)` | `4.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `60.00% <0.00%> (-15.00%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...server/core/analysis/worker/AlarmNotifyWorker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL0FsYXJtTm90aWZ5V29ya2VyLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `3.00% <0.00%> (ø%)` | |
| [.../server/core/analysis/data/ReadWriteSafeCache.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9SZWFkV3JpdGVTYWZlQ2FjaGUuamF2YQ==) | `68.18% <0.00%> (-10.77%)` | `3.00% <0.00%> (ø%)` | |
| [...lemetry/prometheus/PrometheusHistogramMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0hpc3RvZ3JhbU1ldHJpY3MuamF2YQ==) | `70.58% <0.00%> (-9.42%)` | `2.00% <0.00%> (ø%)` | |
| [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <0.00%> (-8.93%)` | `1.00% <0.00%> (ø%)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <0.00%> (-7.78%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1357 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `1.96%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 49.23% -1.97%
+ Complexity 3544 3447 -97
============================================
Files 943 948 +5
Lines 23398 23448 +50
Branches 2270 2278 +8
============================================
- Hits 11980 11545 -435
- Misses 10405 10928 +523
+ Partials 1013 975 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [65 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `6.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 45.89% -6.58%
+ Complexity 3739 3139 -600
============================================
Files 1721 1720 -1
Lines 36530 36444 -86
Branches 4029 4037 +8
============================================
- Hits 19168 16725 -2443
- Misses 16414 18759 +2345
- Partials 948 960 +12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `1.83%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 49.36% -1.84%
+ Complexity 3544 3485 -59
============================================
Files 943 965 +22
Lines 23398 23805 +407
Branches 2270 2343 +73
============================================
- Hits 11980 11752 -228
- Misses 10405 11038 +633
- Partials 1013 1015 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [98 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.26%`.
> The diff coverage is `26.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 39.06% -12.27%
+ Complexity 3535 2816 -719
=============================================
Files 1700 947 -753
Lines 35972 23215 -12757
Branches 3975 2285 -1690
=============================================
- Hits 18465 9069 -9396
+ Misses 16562 13363 -3199
+ Partials 945 783 -162
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (215aded) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `18.66%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 33.91% -18.67%
+ Complexity 3740 2357 -1383
=============================================
Files 1718 947 -771
Lines 36447 23066 -13381
Branches 4035 2255 -1780
=============================================
- Hits 19164 7823 -11341
+ Misses 16336 14624 -1712
+ Partials 947 619 -328
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1323 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...215aded](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `5.76%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 42.57% 48.34% +5.76%
- Complexity 3012 3391 +379
============================================
Files 944 968 +24
Lines 23262 23750 +488
Branches 2256 2337 +81
============================================
+ Hits 9903 11481 +1578
+ Misses 12493 11291 -1202
- Partials 866 978 +112
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...nual/errorlog/BrowserErrorLogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvZXJyb3Jsb2cvQnJvd3NlckVycm9yTG9nUmVjb3JkRGlzcGF0Y2hlci5qYXZh) | `7.69% <0.00%> (-92.31%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [217 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `4.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 48.21% -4.26%
+ Complexity 3739 3296 -443
============================================
Files 1721 1720 -1
Lines 36530 36444 -86
Branches 4029 4037 +8
============================================
- Hits 19168 17572 -1596
- Misses 16414 17916 +1502
- Partials 948 956 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [141 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] elk-g commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
elk-g commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r558836747
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-1.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.log4j.v1.x.log;
+
+import java.lang.reflect.Method;
+import java.util.Objects;
+import java.util.Optional;
+
+import org.apache.skywalking.apm.agent.core.boot.ServiceManager;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair;
+import org.apache.skywalking.apm.network.logging.v3.JSONLog;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogDataBody;
+import org.apache.skywalking.apm.network.logging.v3.TextLog;
+import org.apache.skywalking.apm.network.logging.v3.TraceContext;
+import org.apache.skywalking.apm.network.logging.v3.YAMLLog;
+import org.apache.skywalking.apm.toolkit.common.log.GRPCLogConfig;
+import org.apache.skywalking.apm.toolkit.common.log.LogReportServiceClient;
+import org.slf4j.event.LoggingEvent;
+
+public class GRPCLogAppenderInterceptor implements InstanceMethodsAroundInterceptor {
+
+ private LogReportServiceClient client;
+
+ @Override
+ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+ if (Objects.isNull(client)) {
+ client = ServiceManager.INSTANCE.findService(LogReportServiceClient.class);
+ if (Objects.isNull(client)) {
+ return;
+ }
+ }
+ LoggingEvent event = (LoggingEvent) allArguments[0];
+ if (event != null) {
+ LogData logData = transform(event);
+ if (Objects.nonNull(logData)) {
+ client.produce(logData);
+ }
+ }
+ }
+
+ @Override
+ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
+ Object ret) throws Throwable {
+ return ret;
+ }
+
+ @Override
+ public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments,
+ Class<?>[] argumentsTypes, Throwable t) {
+
+ }
+
+ private LogData transform(LoggingEvent event) {
+ if (Objects.isNull(event)) {
+ return null;
+ }
+ LogData.Builder logBuilder = LogData.newBuilder()
+ .setTimestamp(event.getTimeStamp())
+ .setService(Config.Agent.SERVICE_NAME)
+ .setServiceInstance(Config.Agent.INSTANCE_NAME)
+ .setTraceContext(TraceContext.newBuilder()
+ .setTraceId(ContextManager.getGlobalTraceId()).build())
+ .addTags(KeyStringValuePair.newBuilder()
+ .setKey("level").setValue(event.getLevel().toString()).build())
+ .addTags(KeyStringValuePair.newBuilder()
+ .setKey("logger").setValue(event.getLoggerName()).build())
+ .addTags(KeyStringValuePair.newBuilder()
+ .setKey("thread").setValue(event.getThreadName()).build());
+
+ LogDataBody.Builder logDataBodyBuilder = LogDataBody.newBuilder();
+ LogDataBody.ContentCase contentType = Optional.ofNullable(LogDataBody.ContentCase.forNumber(
+ GRPCLogConfig.Plugin.GRPCLog.LOG_BODY_TYPE)).orElse(LogDataBody.ContentCase.TEXT);
Review comment:
In the current position, we get the real text, and do we need to add an encoder in appender and send it with formatting log content to the client ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (beb483a) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `6.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 42.57% 35.74% -6.83%
+ Complexity 3012 2062 -950
============================================
Files 944 767 -177
Lines 23262 19014 -4248
Branches 2256 1802 -454
============================================
- Hits 9903 6797 -3106
+ Misses 12493 11696 -797
+ Partials 866 521 -345
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [385 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (44a6ef8) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `42.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 42.57% 0.00% -42.58%
============================================
Files 944 175 -769
Lines 23262 4265 -18997
Branches 2256 502 -1754
============================================
- Hits 9903 0 -9903
+ Misses 12493 4265 -8228
+ Partials 866 0 -866
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [910 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559192775
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -159,6 +159,10 @@ property key | Description | Default |
`plugin.kafka.topic_profilings` | Specify which Kafka topic name for Thread Profiling snapshot to report to. | `skywalking_profilings` |
`plugin.kafka.topic_management` | Specify which Kafka topic name for the register or heartbeat data of Service Instance to report to. | `skywalking_managements` |
`plugin.springannotation.classname_match_regex` | Match spring beans with regular expression for the class name. Multiple expressions could be separated by a comma. This only works when `Spring annotation plugin` has been activated. | `All the spring beans tagged with @Bean,@Service,@Dao, or @Repository.` |
+`plugin.grpclog.service_host` | Specify which grpc server's host for log data to report to. | `127.0.0.1` |
+`plugin.grpclog.service_port` | Specify which grpc server's port for log data to report to. | `11800` |
+`plugin.grpclog.max_message_size` | Specify the maximum size of log data for grpc client to report to. | `10485760` |
+`plugin.grpclog.upstream_timeout` | How long grpc client will timeout in sending data to upstream. Unit is second.|`30` seconds|
Review comment:
Take a look at this, https://github.com/apache/skywalking/pull/6194#discussion_r558848862. I mean, that should be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `0.53%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.58% 52.04% -0.54%
+ Complexity 3740 3590 -150
============================================
Files 1718 944 -774
Lines 36447 23349 -13098
Branches 4035 2295 -1740
============================================
- Hits 19164 12151 -7013
+ Misses 16336 10155 -6181
- Partials 947 1043 +96
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-16.13%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <0.00%> (-21.15%)` | `23.00 <0.00> (-2.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1213 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `0.86%`.
> The diff coverage is `3.46%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 50.33% -0.87%
- Complexity 3544 3566 +22
============================================
Files 943 1735 +792
Lines 23398 36790 +13392
Branches 2270 4060 +1790
============================================
+ Hits 11980 18517 +6537
- Misses 10405 17319 +6914
+ Partials 1013 954 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...logging/common/log/GRPCLogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9sb2dnaW5nL2NvbW1vbi9sb2cvR1JQQ0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (215aded) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `52.58%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.58% 0.00% -52.59%
============================================
Files 1718 195 -1523
Lines 36447 4532 -31915
Branches 4035 534 -3501
============================================
- Hits 19164 0 -19164
+ Misses 16336 4532 -11804
+ Partials 947 0 -947
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1696 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...215aded](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `0.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 51.93% -0.54%
+ Complexity 3739 3697 -42
============================================
Files 1721 1720 -1
Lines 36530 36463 -67
Branches 4029 4041 +12
============================================
- Hits 19168 18937 -231
- Misses 16414 16575 +161
- Partials 948 951 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-82.61%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-76.48%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-3.00%)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `5.82% <0.00%> (-67.97%)` | `1.00% <0.00%> (-8.00%)` | |
| [.../analyzer/provider/log/LogAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...provider/log/listener/TrafficAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvVHJhZmZpY0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `22.85% <0.00%> (-62.86%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.42% <0.00%> (-53.58%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `1.21%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 51.25% -1.22%
+ Complexity 3739 3543 -196
============================================
Files 1721 949 -772
Lines 36530 23482 -13048
Branches 4029 2305 -1724
============================================
- Hits 19168 12036 -7132
+ Misses 16414 10387 -6027
- Partials 948 1059 +111
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `40.00% <40.00%> (ø)` | `4.00 <4.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/oap/server/core/cluster/OAPNodeChecker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9PQVBOb2RlQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (-93.75%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1209 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (44a6ef8) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `42.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 42.57% 0.00% -42.58%
============================================
Files 944 174 -770
Lines 23262 4192 -19070
Branches 2256 485 -1771
============================================
- Hits 9903 0 -9903
+ Misses 12493 4192 -8301
+ Partials 866 0 -866
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [911 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **increase** coverage by `3.91%`.
> The diff coverage is `53.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.33% 55.24% +3.91%
- Complexity 3535 3752 +217
============================================
Files 1700 946 -754
Lines 35972 23475 -12497
Branches 3975 2302 -1673
============================================
- Hits 18465 12969 -5496
+ Misses 16562 9395 -7167
- Partials 945 1111 +166
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `2.63% <0.00%> (-1.54%)` | `1.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/TraceQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVHJhY2VRdWVyeUVzREFPLmphdmE=) | `33.33% <0.00%> (+0.83%)` | `3.00 <0.00> (ø)` | |
| ... and [1290 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r558928825
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-common/pom.xml
##########
@@ -0,0 +1,102 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>apm-toolkit-activation</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.4.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>apm-toolkit-common</artifactId>
+
+ <properties>
+ <shade.com.google.source>com.google</shade.com.google.source>
+ <shade.com.google.target>${shade.package}.${shade.com.google.source}</shade.com.google.target>
+ <shade.io.grpc.source>io.grpc</shade.io.grpc.source>
+ <shade.io.grpc.target>${shade.package}.${shade.io.grpc.source}</shade.io.grpc.target>
+ <shade.io.netty.source>io.netty</shade.io.netty.source>
+ <shade.io.netty.target>${shade.package}.${shade.io.netty.source}</shade.io.netty.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>apm-network</artifactId>
+ <version>${project.version}</version>
Review comment:
@elk-g tell me that the shade plugin depends on the direct reference lib. @arugal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (44a6ef8) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `9.15%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 42.57% 51.72% +9.15%
- Complexity 3012 3611 +599
============================================
Files 944 950 +6
Lines 23262 23529 +267
Branches 2256 2311 +55
============================================
+ Hits 9903 12170 +2267
+ Misses 12493 10304 -2189
- Partials 866 1055 +189
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-87.21%)` | `1.00% <0.00%> (-8.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `16.12% <0.00%> (-77.42%)` | `2.00% <0.00%> (-4.00%)` | |
| [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `41.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-1.00%)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/influxdb/query/ProfileTaskQuery.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza1F1ZXJ5LmphdmE=) | `26.53% <0.00%> (-53.07%)` | `3.00% <0.00%> (-8.00%)` | |
| ... and [204 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (af63aae) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `42.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 42.57% 0.00% -42.58%
============================================
Files 944 165 -779
Lines 23262 4055 -19207
Branches 2256 472 -1784
============================================
- Hits 9903 0 -9903
+ Misses 12493 4055 -8438
+ Partials 866 0 -866
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [919 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...44a6ef8](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (2cf0232) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `51.20%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 943 171 -772
Lines 23398 4159 -19239
Branches 2270 483 -1787
============================================
- Hits 11980 0 -11980
+ Misses 10405 4159 -6246
+ Partials 1013 0 -1013
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [919 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (986f606) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 201 -1520
Lines 36530 4679 -31851
Branches 4029 546 -3483
============================================
- Hits 19168 0 -19168
+ Misses 16414 4679 -11735
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1692 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...986f606](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `0.49%`.
> The diff coverage is `51.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 50.83% -0.50%
+ Complexity 3535 3499 -36
============================================
Files 1700 946 -754
Lines 35972 23437 -12535
Branches 3975 2300 -1675
============================================
- Hits 18465 11915 -6550
+ Misses 16562 10498 -6064
- Partials 945 1024 +79
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (1137970) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 172 -1549
Lines 36530 4125 -32405
Branches 4029 480 -3549
============================================
- Hits 19168 0 -19168
+ Misses 16414 4125 -12289
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1698 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] elk-g commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
elk-g commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559195381
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -159,6 +159,10 @@ property key | Description | Default |
`plugin.kafka.topic_profilings` | Specify which Kafka topic name for Thread Profiling snapshot to report to. | `skywalking_profilings` |
`plugin.kafka.topic_management` | Specify which Kafka topic name for the register or heartbeat data of Service Instance to report to. | `skywalking_managements` |
`plugin.springannotation.classname_match_regex` | Match spring beans with regular expression for the class name. Multiple expressions could be separated by a comma. This only works when `Spring annotation plugin` has been activated. | `All the spring beans tagged with @Bean,@Service,@Dao, or @Repository.` |
+`plugin.grpclog.service_host` | Specify which grpc server's host for log data to report to. | `127.0.0.1` |
+`plugin.grpclog.service_port` | Specify which grpc server's port for log data to report to. | `11800` |
+`plugin.grpclog.max_message_size` | Specify the maximum size of log data for grpc client to report to. | `10485760` |
+`plugin.grpclog.upstream_timeout` | How long grpc client will timeout in sending data to upstream. Unit is second.|`30` seconds|
Review comment:
I'm so sorry to miss it. Do you means using `Toolkit` as the class name and adding `log_grpc_reporter` as the prefix of the field, so the key willi like plugin.toolkit.log_grpc_reporter*? Or using a long class name? Or something else？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `0.86%`.
> The diff coverage is `3.46%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 50.33% -0.87%
- Complexity 3544 3566 +22
============================================
Files 943 1735 +792
Lines 23398 36790 +13392
Branches 2270 4060 +1790
============================================
+ Hits 11980 18517 +6537
- Misses 10405 17319 +6914
+ Partials 1013 954 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...logging/common/log/GRPCLogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9sb2dnaW5nL2NvbW1vbi9sb2cvR1JQQ0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (e01cd3c) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `11.48%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.20% 39.71% -11.49%
+ Complexity 3544 2787 -757
=============================================
Files 943 914 -29
Lines 23398 22536 -862
Branches 2270 2201 -69
=============================================
- Hits 11980 8951 -3029
- Misses 10405 12801 +2396
+ Partials 1013 784 -229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [216 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (741517c) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `8.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 43.88% -8.59%
+ Complexity 3739 2539 -1200
============================================
Files 1721 784 -937
Lines 36530 19566 -16964
Branches 4029 1847 -2182
============================================
- Hits 19168 8587 -10581
+ Misses 16414 10286 -6128
+ Partials 948 693 -255
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...741517c](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `3.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 49.15% -3.32%
+ Complexity 3739 3420 -319
============================================
Files 1721 1720 -1
Lines 36530 36448 -82
Branches 4029 4041 +12
============================================
- Hits 19168 17915 -1253
- Misses 16414 17578 +1164
- Partials 948 955 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [104 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r556281874
##########
File path: apm-application-toolkit/apm-toolkit-log4j-2.x/src/main/java/org/apache/skywalking/apm/toolkit/log/log4j/v2/x/log/GRPCLogClientAppender.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.log.log4j.v2.x.log;
+
+import java.io.Serializable;
+
+import org.apache.logging.log4j.core.Filter;
+import org.apache.logging.log4j.core.Layout;
+import org.apache.logging.log4j.core.LogEvent;
+import org.apache.logging.log4j.core.appender.AbstractAppender;
+
+public class GRPCLogClientAppender extends AbstractAppender {
+
+ protected GRPCLogClientAppender(String name, Filter filter, Layout<? extends Serializable> layout) {
+ super(name, filter, layout);
Review comment:
why add it?
##########
File path: apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/log/GRPCLogClientAppender.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.log.logback.v1.x.log;
+
+import ch.qos.logback.core.AppenderBase;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
Review comment:
please remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `22.60%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 29.97% -22.61%
+ Complexity 3740 2059 -1681
=============================================
Files 1718 924 -794
Lines 36447 22674 -13773
Branches 4035 2225 -1810
=============================================
- Hits 19164 6796 -12368
+ Misses 16336 15361 -975
+ Partials 947 517 -430
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559063700
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -159,6 +159,10 @@ property key | Description | Default |
`plugin.kafka.topic_profilings` | Specify which Kafka topic name for Thread Profiling snapshot to report to. | `skywalking_profilings` |
`plugin.kafka.topic_management` | Specify which Kafka topic name for the register or heartbeat data of Service Instance to report to. | `skywalking_managements` |
`plugin.springannotation.classname_match_regex` | Match spring beans with regular expression for the class name. Multiple expressions could be separated by a comma. This only works when `Spring annotation plugin` has been activated. | `All the spring beans tagged with @Bean,@Service,@Dao, or @Repository.` |
+`plugin.grpclog.service_host` | Specify which grpc server's host for log data to report to. | `127.0.0.1` |
+`plugin.grpclog.service_port` | Specify which grpc server's port for traces data to report to. | `8000` |
Review comment:
```suggestion
`plugin.grpclog.service_port` | Specify which grpc server's port for log data to report to. | `11800` |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (fa69253) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 193 -1528
Lines 36530 4526 -32004
Branches 4029 534 -3495
============================================
- Hits 19168 0 -19168
+ Misses 16414 4526 -11888
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1696 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.15%`.
> The diff coverage is `49.72%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 39.17% -12.16%
+ Complexity 3535 2642 -893
=============================================
Files 1700 945 -755
Lines 35972 23322 -12650
Branches 3975 2277 -1698
=============================================
- Hits 18465 9137 -9328
+ Misses 16562 13473 -3089
+ Partials 945 712 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (fa69253) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 195 -1526
Lines 36530 4532 -31998
Branches 4029 534 -3495
============================================
- Hits 19168 0 -19168
+ Misses 16414 4532 -11882
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1696 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (741517c) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `6.33%`.
> The diff coverage is `1.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 46.13% -6.34%
+ Complexity 3739 2608 -1131
============================================
Files 1721 1722 +1
Lines 36530 36365 -165
Branches 4029 4224 +195
============================================
- Hits 19168 16776 -2392
- Misses 16414 18623 +2209
- Partials 948 966 +18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apm/toolkit/logging/common/log/GRPCLogConfig.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9sb2dnaW5nL2NvbW1vbi9sb2cvR1JQQ0xvZ0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...741517c](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `51.33%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 0.00% -51.34%
============================================
Files 1700 169 -1531
Lines 35972 4086 -31886
Branches 3975 472 -3503
============================================
- Hits 18465 0 -18465
+ Misses 16562 4086 -12476
+ Partials 945 0 -945
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1631 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `3.46%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.20% 47.73% -3.47%
+ Complexity 3544 3314 -230
============================================
Files 943 942 -1
Lines 23398 23273 -125
Branches 2270 2261 -9
============================================
- Hits 11980 11110 -870
- Misses 10405 11188 +783
+ Partials 1013 975 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [123 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559067116
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-common/pom.xml
##########
@@ -0,0 +1,102 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>apm-toolkit-activation</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.4.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>apm-toolkit-common</artifactId>
+
+ <properties>
+ <shade.com.google.source>com.google</shade.com.google.source>
+ <shade.com.google.target>${shade.package}.${shade.com.google.source}</shade.com.google.target>
+ <shade.io.grpc.source>io.grpc</shade.io.grpc.source>
+ <shade.io.grpc.target>${shade.package}.${shade.io.grpc.source}</shade.io.grpc.target>
+ <shade.io.netty.source>io.netty</shade.io.netty.source>
+ <shade.io.netty.target>${shade.package}.${shade.io.netty.source}</shade.io.netty.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>apm-network</artifactId>
+ <version>${project.version}</version>
Review comment:
@elk-g I got it, maybe can move `GRPCLogReportServiceClient` to `apm-agent-core`, what do you think? @wu-sheng @EvanLjp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (215aded) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `12.43%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 40.14% -12.44%
+ Complexity 3740 2769 -971
=============================================
Files 1718 964 -754
Lines 36447 23672 -12775
Branches 4035 2332 -1703
=============================================
- Hits 19164 9504 -9660
+ Misses 16336 13437 -2899
+ Partials 947 731 -216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...215aded](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `14.67%`.
> The diff coverage is `50.95%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 36.65% -14.68%
+ Complexity 3535 2532 -1003
=============================================
Files 1700 952 -748
Lines 35972 23439 -12533
Branches 3975 2303 -1672
=============================================
- Hits 18465 8592 -9873
+ Misses 16562 14198 -2364
+ Partials 945 649 -296
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| ... and [1346 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559093028
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/LogReportServiceClient.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.remote;
+
+import java.util.List;
+
+import org.apache.skywalking.apm.agent.core.boot.BootService;
+import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
+import org.apache.skywalking.apm.commons.datacarrier.consumer.IConsumer;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+
+@DefaultImplementor
+public class LogReportServiceClient implements BootService, IConsumer<LogData> {
+
+ @Override
+ public void prepare() throws Throwable {
+
+ }
+
+ @Override
+ public void boot() throws Throwable {
+
+ }
+
+ @Override
+ public void onComplete() throws Throwable {
+
+ }
+
+ @Override
+ public void shutdown() throws Throwable {
+
+ }
+
+ @Override
+ public void init() {
+
+ }
+
+ public void produce(LogData logData) {
+
+ }
Review comment:
My thought is, you should be able to `findService` and cast to your `override` implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (741517c) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `6.33%`.
> The diff coverage is `1.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 46.13% -6.34%
+ Complexity 3739 2608 -1131
============================================
Files 1721 1722 +1
Lines 36530 36365 -165
Branches 4029 4224 +195
============================================
- Hits 19168 16776 -2392
- Misses 16414 18623 +2209
- Partials 948 966 +18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/logback/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVySW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apm/toolkit/logging/common/log/GRPCLogConfig.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9sb2dnaW5nL2NvbW1vbi9sb2cvR1JQQ0xvZ0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (017fff5) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `51.19%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.19% 0.00% -51.20%
============================================
Files 1700 176 -1524
Lines 35973 4263 -31710
Branches 4141 493 -3648
============================================
- Hits 18417 0 -18417
+ Misses 16605 4263 -12342
+ Partials 951 0 -951
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1680 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **decrease** coverage by `27.13%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.20% 24.06% -27.14%
+ Complexity 3544 1712 -1832
=============================================
Files 943 924 -19
Lines 23398 22579 -819
Branches 2270 2176 -94
=============================================
- Hits 11980 5433 -6547
- Misses 10405 16735 +6330
+ Partials 1013 411 -602
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [418 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r556277159
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -325,4 +325,32 @@
*/
public static String AUTO_TAG_KEYS = "";
}
+
+ public static class GRPCLog {
Review comment:
This doesn't belong to the core, please move to the plugin.
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/log/LogReportServiceClient.java
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.log;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.skywalking.apm.agent.core.boot.BootService;
+import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.remote.GRPCStreamServiceStatus;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.commons.datacarrier.DataCarrier;
+import org.apache.skywalking.apm.commons.datacarrier.buffer.BufferStrategy;
+import org.apache.skywalking.apm.commons.datacarrier.consumer.IConsumer;
+import org.apache.skywalking.apm.network.common.v3.Commands;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogReportServiceGrpc;
+
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.StatusRuntimeException;
+import io.grpc.stub.StreamObserver;
+
+@DefaultImplementor
+public class LogReportServiceClient implements BootService, IConsumer<LogData> {
Review comment:
Log collecting service belongs to the plugin, please move.
##########
File path: apm-sniffer/config/agent.config
##########
@@ -110,3 +110,10 @@ plugin.mount=${SW_MOUNT_FOLDERS:plugins,activations}
# Match spring bean with regex expression for classname
# plugin.springannotation.classname_match_regex=${SW_SPRINGANNOTATION_CLASSNAME_MATCH_REGEX:}
+
+#grpc-log client configuration
+grpclog.service_host=${SW_GRPC_LOG_SERVER_HOST:localhost}
+grpclog.service_port=${SW_GRPC_LOG_SERVER_PORT:8000}
+grpclog.max_message_size=${SW_GRPC_LOG_MAX_MESSAGE_SIZE:10485760}
+grpclog.log_body_type=${SW_GRPC_LOG_LOG_BODY_TYPE:2}
+grpclog.upstream_timeout=${SW_GRPC_LOG_GRPC_UPSTREAM_TIMEOUT:30}
Review comment:
All these are optional, should move to the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-762133285
Let's merge #6214 first, it waits for a little long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `0.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 51.95% -0.53%
+ Complexity 3740 3700 -40
============================================
Files 1721 1720 -1
Lines 36530 36463 -67
Branches 4029 4041 +12
============================================
- Hits 19170 18943 -227
- Misses 16412 16571 +159
- Partials 948 949 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-82.61%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-76.48%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-3.00%)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `5.82% <0.00%> (-67.97%)` | `1.00% <0.00%> (-8.00%)` | |
| [.../analyzer/provider/log/LogAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...provider/log/listener/TrafficAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvVHJhZmZpY0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `22.85% <0.00%> (-62.86%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.42% <0.00%> (-53.58%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...1137970](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (36437dc) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `0.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 51.92% -0.55%
+ Complexity 3739 3695 -44
============================================
Files 1721 1720 -1
Lines 36530 36463 -67
Branches 4029 4041 +12
============================================
- Hits 19168 18935 -233
- Misses 16414 16577 +163
- Partials 948 951 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/manual/log/LogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.26% <0.00%> (-94.74%)` | `1.00% <0.00%> (-1.00%)` | |
| [...alysis/manual/endpoint/EndpointMetaDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50TWV0YURpc3BhdGNoZXIuamF2YQ==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-82.61%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-76.48%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/server/core/storage/query/ILogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-3.00%)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `5.82% <0.00%> (-67.97%)` | `1.00% <0.00%> (-8.00%)` | |
| [.../analyzer/provider/log/LogAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...provider/log/listener/TrafficAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvVHJhZmZpY0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `22.85% <0.00%> (-62.86%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.42% <0.00%> (-53.58%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (f9d4c6e) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `52.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.47% 0.00% -52.48%
============================================
Files 1721 191 -1530
Lines 36530 4484 -32046
Branches 4029 530 -3499
============================================
- Hits 19168 0 -19168
+ Misses 16414 4484 -11930
+ Partials 948 0 -948
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1698 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...f9d4c6e](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `14.91%`.
> The diff coverage is `46.80%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 36.41% -14.92%
+ Complexity 3535 2511 -1024
=============================================
Files 1700 945 -755
Lines 35972 23303 -12669
Branches 3975 2277 -1698
=============================================
- Hits 18465 8486 -9979
+ Misses 16562 14166 -2396
+ Partials 945 651 -294
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (017fff5) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `21.26%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.19% 29.93% -21.27%
+ Complexity 2900 2030 -870
=============================================
Files 1700 909 -791
Lines 35973 22404 -13569
Branches 4141 2175 -1966
=============================================
- Hits 18417 6706 -11711
+ Misses 16605 15183 -1422
+ Partials 951 515 -436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1314 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `1.48%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 52.47% 53.95% +1.48%
+ Complexity 3739 3704 -35
============================================
Files 1721 949 -772
Lines 36530 23520 -13010
Branches 4029 2311 -1718
============================================
- Hits 19168 12690 -6478
+ Misses 16414 9733 -6681
- Partials 948 1097 +149
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/oap/server/core/cluster/OAPNodeChecker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9PQVBOb2RlQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (-93.75%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1196 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **increase** coverage by `0.07%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 52.47% 52.54% +0.07%
+ Complexity 3739 3621 -118
============================================
Files 1721 949 -772
Lines 36530 23520 -13010
Branches 4029 2311 -1718
============================================
- Hits 19168 12358 -6810
+ Misses 16414 10077 -6337
- Partials 948 1085 +137
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...alking/oap/server/core/cluster/OAPNodeChecker.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9PQVBOb2RlQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (-93.75%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1204 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `6.07%`.
> The diff coverage is `52.54%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 45.25% -6.08%
+ Complexity 3535 3255 -280
============================================
Files 1700 968 -732
Lines 35972 23714 -12258
Branches 3975 2336 -1639
============================================
- Hits 18465 10732 -7733
+ Misses 16562 12068 -4494
+ Partials 945 914 -31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `2.63% <0.00%> (-1.54%)` | `1.00 <0.00> (ø)` | |
| ... and [1292 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (c6fc54a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `14.84%`.
> The diff coverage is `54.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 36.48% -14.85%
+ Complexity 3535 2469 -1066
=============================================
Files 1700 935 -765
Lines 35972 22929 -13043
Branches 3975 2249 -1726
=============================================
- Hits 18465 8365 -10100
+ Misses 16562 13923 -2639
+ Partials 945 641 -304
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-69.79%)` | `0.00 <0.00> (-23.00)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-48.24%)` | `0.00 <0.00> (-15.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `46.42% <0.00%> (-21.43%)` | `4.00 <0.00> (-1.00)` | |
| ... and [1352 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...c6fc54a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (ab8a315) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `5.04%`.
> The diff coverage is `27.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 52.58% 47.53% -5.05%
+ Complexity 3740 3306 -434
============================================
Files 1718 944 -774
Lines 36447 23286 -13161
Branches 4035 2288 -1747
============================================
- Hits 19164 11070 -8094
+ Misses 16336 11278 -5058
+ Partials 947 938 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `43.18% <0.00%> (-16.13%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.18% <0.00%> (-21.15%)` | `23.00 <0.00> (-2.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1255 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...ab8a315](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r557424740
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-common/src/main/java/org/apache/skywalking/apm/toolkit/common/log/GRPCLogConfig.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.common.log;
+
+import org.apache.skywalking.apm.agent.core.boot.PluginConfig;
+
+public class GRPCLogConfig {
+
+ public static class Plugin {
+ @PluginConfig(root = GRPCLogConfig.class)
+ public static class GRPCLog {
+ /**
+ * The host of gRPC log server.
+ */
+ public static String SERVER_HOST = "127.0.0.1";
+
+ /**
+ * The port of gRPC log server.
+ */
+ public static int SERVER_PORT = 8000;
+
+ /**
+ * The max size of message to send to server.Default is 10 MB
+ */
+ public static int MAX_MESSAGE_SIZE = 10 * 1024 * 1024;
+
+ /**
+ * The log body type to send to the server, includes text(2),json(3),yaml(4).Default is text.
+ */
+ public static int LOG_BODY_TYPE = 2;
Review comment:
Why use `int` rather than `Enum`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (017fff5) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `4.47%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.19% 46.72% -4.48%
- Complexity 2900 3250 +350
============================================
Files 1700 943 -757
Lines 35973 23298 -12675
Branches 4141 2276 -1865
============================================
- Hits 18417 10885 -7532
+ Misses 16605 11495 -5110
+ Partials 951 918 -33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `42.85% <42.85%> (ø)` | `8.00 <8.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.88% <83.33%> (+0.23%)` | `0.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1208 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/4e43f227b4a579b7bd48996974b5872d30c191f1?el=desc) (4e43f22) will **increase** coverage by `0.76%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.20% 51.96% +0.76%
- Complexity 3544 3551 +7
============================================
Files 943 942 -1
Lines 23398 23352 -46
Branches 2270 2283 +13
============================================
+ Hits 11980 12135 +155
+ Misses 10405 10180 -225
- Partials 1013 1037 +24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <50.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...nual/errorlog/BrowserErrorLogRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvZXJyb3Jsb2cvQnJvd3NlckVycm9yTG9nUmVjb3JkRGlzcGF0Y2hlci5qYXZh) | `7.69% <0.00%> (-92.31%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ser/provider/parser/errorlog/ErrorLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9FcnJvckxvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ance/BrowserAppSingleVersionTrafficDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvaW5zdGFuY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25UcmFmZmljRGlzcGF0Y2hlci5qYXZh) | `12.50% <0.00%> (-87.50%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [120 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [4e43f22...2cf0232](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (a09df8b) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `13.48%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 38.98% -13.49%
+ Complexity 3739 2595 -1144
=============================================
Files 1721 949 -772
Lines 36530 23332 -13198
Branches 4029 2260 -1769
=============================================
- Hits 19168 9097 -10071
+ Misses 16414 13534 -2880
+ Partials 948 701 -247
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...a09df8b](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (215aded) into [master](https://codecov.io/gh/apache/skywalking/commit/98d0430b91e09a80214379a06aba26e5e16de438?el=desc) (98d0430) will **decrease** coverage by `14.84%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.58% 37.73% -14.85%
+ Complexity 3740 2634 -1106
=============================================
Files 1718 964 -754
Lines 36447 23608 -12839
Branches 4035 2326 -1709
=============================================
- Hits 19164 8908 -10256
+ Misses 16336 14007 -2329
+ Partials 947 693 -254
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-59.31%)` | `0.00 <0.00> (-18.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-70.33%)` | `0.00 <0.00> (-25.00)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1286 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [98d0430...215aded](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] elk-g commented on a change in pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
elk-g commented on a change in pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#discussion_r559097897
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/LogReportServiceClient.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.remote;
+
+import java.util.List;
+
+import org.apache.skywalking.apm.agent.core.boot.BootService;
+import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
+import org.apache.skywalking.apm.commons.datacarrier.consumer.IConsumer;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+
+@DefaultImplementor
+public class LogReportServiceClient implements BootService, IConsumer<LogData> {
+
+ @Override
+ public void prepare() throws Throwable {
+
+ }
+
+ @Override
+ public void boot() throws Throwable {
+
+ }
+
+ @Override
+ public void onComplete() throws Throwable {
+
+ }
+
+ @Override
+ public void shutdown() throws Throwable {
+
+ }
+
+ @Override
+ public void init() {
+
+ }
+
+ public void produce(LogData logData) {
+
+ }
Review comment:
I tried it by using `findService(LogReportServiceClient.class)` to obtain the client and then cast it to `GRPCLogReportServiceClient`, but it occurs an error like `GRPCLogReportServiceClient cannot be cast to GRPCLogReportServiceClient`. The way doesn't seem to work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5e27cbd) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `14.38%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.19% 36.80% -14.39%
+ Complexity 2900 2460 -440
=============================================
Files 1700 919 -781
Lines 35973 22748 -13225
Branches 4141 2198 -1943
=============================================
- Hits 18417 8373 -10044
+ Misses 16605 13733 -2872
+ Partials 951 642 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5e27cbd) into [master](https://codecov.io/gh/apache/skywalking/commit/50c74a6bc5689a0a5e3e0e956ccae477cd62965b?el=desc) (50c74a6) will **decrease** coverage by `22.85%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.19% 28.33% -22.86%
+ Complexity 2900 1972 -928
=============================================
Files 1700 895 -805
Lines 35973 22135 -13838
Branches 4141 2140 -2001
=============================================
- Hits 18417 6273 -12144
+ Misses 16605 15370 -1235
+ Partials 951 492 -459
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/log/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1330 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [50c74a6...017fff5](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (fa69253) into [master](https://codecov.io/gh/apache/skywalking/commit/9021e6791229e8dd81ffaf7b77cb9f567723d0b6?el=desc) (9021e67) will **decrease** coverage by `18.30%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 52.47% 34.16% -18.31%
+ Complexity 3739 2344 -1395
=============================================
Files 1721 950 -771
Lines 36530 23153 -13377
Branches 4029 2267 -1762
=============================================
- Hits 19168 7911 -11257
+ Misses 16414 14637 -1777
+ Partials 948 605 -343
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1322 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [9021e67...fa69253](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (6d0f48a) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `12.27%`.
> The diff coverage is `26.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
=============================================
- Coverage 51.33% 39.05% -12.28%
+ Complexity 3535 2816 -719
=============================================
Files 1700 948 -752
Lines 35972 23220 -12752
Branches 3975 2285 -1690
=============================================
- Hits 18465 9069 -9396
+ Misses 16562 13368 -3194
+ Partials 945 783 -162
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-11.58%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `60.00% <0.00%> (-37.44%)` | `6.00 <0.00> (-5.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `2.63% <0.00%> (-0.71%)` | `0.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `6.97% <ø> (-46.52%)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (5c07e49) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **increase** coverage by `3.92%`.
> The diff coverage is `53.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
+ Coverage 51.33% 55.25% +3.92%
- Complexity 3535 3754 +219
============================================
Files 1700 946 -754
Lines 35972 23475 -12497
Branches 3975 2302 -1673
============================================
- Hits 18465 12972 -5493
+ Misses 16562 9392 -7170
- Partials 945 1111 +166
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `50.00% <0.00%> (-9.31%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.09% <0.00%> (-15.69%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `53.48% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `60.00% <ø> (ø)` | `21.00 <0.00> (ø)` | |
| [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | `75.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...nt/kafka/provider/handler/TraceSegmentHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1RyYWNlU2VnbWVudEhhbmRsZXIuamF2YQ==) | `67.85% <0.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...dler/v8/grpc/TraceSegmentReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9ncnBjL1RyYWNlU2VnbWVudFJlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `48.78% <0.00%> (+1.16%)` | `3.00 <0.00> (ø)` | |
| [...rage/plugin/elasticsearch/query/LogQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTG9nUXVlcnlFc0RBTy5qYXZh) | `2.63% <0.00%> (-1.54%)` | `1.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/TraceQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVHJhY2VRdWVyeUVzREFPLmphdmE=) | `33.33% <0.00%> (+0.83%)` | `3.00 <0.00> (ø)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6194: Collect Log with java agent (#6127)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6194:
URL: https://github.com/apache/skywalking/pull/6194#issuecomment-759238947
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=h1) Report
> Merging [#6194](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=desc) (55a8c69) into [master](https://codecov.io/gh/apache/skywalking/commit/0fe0a338ae021b0ae4e74450d1e92416eb73ea88?el=desc) (0fe0a33) will **decrease** coverage by `0.99%`.
> The diff coverage is `44.54%`.
[](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6194 +/- ##
============================================
- Coverage 51.33% 50.33% -1.00%
- Complexity 3535 3566 +31
============================================
Files 1700 1735 +35
Lines 35972 36790 +818
Branches 3975 4060 +85
============================================
+ Hits 18465 18517 +52
- Misses 16562 17319 +757
- Partials 945 954 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...it/log/logback/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0NsaWVudEFwcGVuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `57.95% <0.00%> (-1.35%)` | `18.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `69.56% <0.00%> (-0.22%)` | `25.00 <0.00> (+2.00)` | :arrow_down: |
| [.../log/log4j/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v1/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0xLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../log/log4j/v2/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/log4j/v2/x/log/GRPCLogAppenderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQXBwZW5kZXJJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...og/logback/v1/x/log/GRPCLogAppenderActivation.java](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2cvR1JQQ0xvZ0FwcGVuZGVyQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [169 more](https://codecov.io/gh/apache/skywalking/pull/6194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=footer). Last update [ea8a496...6d0f48a](https://codecov.io/gh/apache/skywalking/pull/6194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org