[GitHub] [airflow] potiuk edited a comment on pull request #12850: Add missing crypto and s3 extras

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739497061


   > The cryptography package should now be required by the core, so I don't know if we need to repost the required versions for it.
   
   I believe it is needed because of fernet encryption which is part of the core. And I prefer to copy the exact requirement there from setup.cfg to avoid any risks with current or future versions of PIP. So core absolutely need this package. The '[crypto]" extra I added is only there for the backwards-compatibility. I just want to avoid the situations where our users get random failures when they try to install Airflow the same way they did before. 
   
   See https://github.com/apache/airflow/issues/12824 - the user wanted to install airflow with
   
   `[async,crypto,celery,jdbc,password,postgres,s3]'
   
   And when they tried to do it with Airflow 2.0 (I did) they would get a "missing extras" warning. Maybe that is enough in many cases but I would like to limit the number of issues people open "Hey it does not work in Airflow 2.0" and we agreed before that we do not remove but deprecate everything we can. 
   
   Let's discuss ideas on how to do it in #12851, but i think we cannot simply just "drop" an extra without any explanation or earlier warning.
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org