You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by bc...@apache.org on 2017/05/10 12:52:07 UTC

[trafficserver] branch master updated: coverity 1021754: Uninitialized pointer field

This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  111bdab   coverity 1021754: Uninitialized pointer field
111bdab is described below

commit 111bdab9abea58cab377aaf4b030f87d701fbbd8
Author: Bryan Call <bc...@apache.org>
AuthorDate: Tue May 9 22:25:42 2017 -0400

    coverity 1021754: Uninitialized pointer field
---
 iocore/dns/P_DNSProcessor.h | 46 +++++++++++++++------------------------------
 1 file changed, 15 insertions(+), 31 deletions(-)

diff --git a/iocore/dns/P_DNSProcessor.h b/iocore/dns/P_DNSProcessor.h
index 8fead49..f51b743 100644
--- a/iocore/dns/P_DNSProcessor.h
+++ b/iocore/dns/P_DNSProcessor.h
@@ -137,24 +137,24 @@ extern RecRawStatBlock *dns_rsb;
 */
 struct DNSEntry : public Continuation {
   int id[MAX_DNS_RETRIES];
-  int qtype;                   ///< Type of query to send.
-  HostResStyle host_res_style; ///< Preferred IP address family.
-  int retries;
-  int which_ns;
-  ink_hrtime submit_time;
-  ink_hrtime send_time;
+  int qtype                   = 0;             ///< Type of query to send.
+  HostResStyle host_res_style = HOST_RES_NONE; ///< Preferred IP address family.
+  int retries                 = DEFAULT_DNS_RETRIES;
+  int which_ns                = NO_NAMESERVER_SELECTED;
+  ink_hrtime submit_time      = 0;
+  ink_hrtime send_time        = 0;
   char qname[MAXDNAME];
-  int qname_len;
-  int orig_qname_len;
-  char **domains;
-  EThread *submit_thread;
+  int qname_len          = 0;
+  int orig_qname_len     = 0;
+  char **domains         = nullptr;
+  EThread *submit_thread = nullptr;
   Action action;
-  Event *timeout;
+  Event *timeout = nullptr;
   Ptr<HostEnt> result_ent;
-  DNSHandler *dnsH;
-  bool written_flag;
-  bool once_written_flag;
-  bool last;
+  DNSHandler *dnsH       = nullptr;
+  bool written_flag      = false;
+  bool once_written_flag = false;
+  bool last              = false;
   LINK(DNSEntry, dup_link);
   Que(DNSEntry, dup_link) dups;
 
@@ -165,22 +165,6 @@ struct DNSEntry : public Continuation {
   void init(const char *x, int len, int qtype_arg, Continuation *acont, DNSProcessor::Options const &opt);
 
   DNSEntry()
-    : Continuation(nullptr),
-      qtype(0),
-      host_res_style(HOST_RES_NONE),
-      retries(DEFAULT_DNS_RETRIES),
-      which_ns(NO_NAMESERVER_SELECTED),
-      submit_time(0),
-      send_time(0),
-      qname_len(0),
-      orig_qname_len(0),
-      domains(0),
-      timeout(0),
-      result_ent(0),
-      dnsH(0),
-      written_flag(false),
-      once_written_flag(false),
-      last(false)
   {
     for (int i = 0; i < MAX_DNS_RETRIES; i++)
       id[i]    = -1;

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].