You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org> on 2007/03/02 21:58:50 UTC
[jira] Created: (TOMAHAWK-915) Base default event used by
submitOnEvent on enclosing component type
Base default event used by submitOnEvent on enclosing component type
--------------------------------------------------------------------
Key: TOMAHAWK-915
URL: https://issues.apache.org/jira/browse/TOMAHAWK-915
Project: MyFaces Tomahawk
Issue Type: Improvement
Components: submitOnEvent
Affects Versions: 1.1.5-SNAPSHOT
Reporter: Mike Kienenberger
Priority: Minor
One thing that I had issues with for submitOnEvent is that the default
event is keyPress. I didn't realize that the default event wouldn't work for a selectOneUI.
Let's add intelligent default event values.
"keyPress" for a UIInput, "change" for a UISelectOne, and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-915) Base default event used by
submitOnEvent on enclosing component type
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478299 ]
Mario Ivankovits commented on TOMAHAWK-915:
-------------------------------------------
Thanks for fixing it!
> Base default event used by submitOnEvent on enclosing component type
> --------------------------------------------------------------------
>
> Key: TOMAHAWK-915
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-915
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: submitOnEvent
> Affects Versions: 1.1.5-SNAPSHOT
> Reporter: Mike Kienenberger
> Priority: Minor
> Fix For: 1.1.6-SNAPSHOT
>
>
> One thing that I had issues with for submitOnEvent is that the default
> event is keyPress. I didn't realize that the default event wouldn't work for a selectOneUI.
> Let's add intelligent default event values.
> "keyPress" for a UIInput, "change" for a UISelectOne, and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-915) Base default event used by
submitOnEvent on enclosing component type
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477449 ]
Mario Ivankovits commented on TOMAHAWK-915:
-------------------------------------------
Mike,
I've committed something which should do the trick, though, I've no time to try it yet.
If you find some time could you please do it? Else I'll do it in the next few days.
Thanks!
Good night :)
Mario
> Base default event used by submitOnEvent on enclosing component type
> --------------------------------------------------------------------
>
> Key: TOMAHAWK-915
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-915
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: submitOnEvent
> Affects Versions: 1.1.5-SNAPSHOT
> Reporter: Mike Kienenberger
> Priority: Minor
>
> One thing that I had issues with for submitOnEvent is that the default
> event is keyPress. I didn't realize that the default event wouldn't work for a selectOneUI.
> Let's add intelligent default event values.
> "keyPress" for a UIInput, "change" for a UISelectOne, and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOMAHAWK-915) Base default event used by
submitOnEvent on enclosing component type
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Kienenberger resolved TOMAHAWK-915.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.6-SNAPSHOT
I think this takes care of it.
> Base default event used by submitOnEvent on enclosing component type
> --------------------------------------------------------------------
>
> Key: TOMAHAWK-915
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-915
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: submitOnEvent
> Affects Versions: 1.1.5-SNAPSHOT
> Reporter: Mike Kienenberger
> Priority: Minor
> Fix For: 1.1.6-SNAPSHOT
>
>
> One thing that I had issues with for submitOnEvent is that the default
> event is keyPress. I didn't realize that the default event wouldn't work for a selectOneUI.
> Let's add intelligent default event values.
> "keyPress" for a UIInput, "change" for a UISelectOne, and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-915) Base default event used by
submitOnEvent on enclosing component type
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478102 ]
Mike Kienenberger commented on TOMAHAWK-915:
--------------------------------------------
Close, but not correct.
You need to use triggerComponent instead of forComponent.
- if (forComponent != null
- && forComponent.getFamily() != null
- && ON_CHANGE_FAMILY.contains(forComponent.getFamily()))
+ if (triggerComponent != null
+ && triggerComponent .getFamily() != null
+ && ON_CHANGE_FAMILY.contains(triggerComponent .getFamily()))
I tested this change and it works on my local copy.
> Base default event used by submitOnEvent on enclosing component type
> --------------------------------------------------------------------
>
> Key: TOMAHAWK-915
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-915
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: submitOnEvent
> Affects Versions: 1.1.5-SNAPSHOT
> Reporter: Mike Kienenberger
> Priority: Minor
>
> One thing that I had issues with for submitOnEvent is that the default
> event is keyPress. I didn't realize that the default event wouldn't work for a selectOneUI.
> Let's add intelligent default event values.
> "keyPress" for a UIInput, "change" for a UISelectOne, and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.