You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/10 05:32:16 UTC
[GitHub] [spark] shivusondur commented on a change in pull request #24026:
[SPARK-27090][CORE] Removing old LEGACY_DRIVER_IDENTIFIER ("")
shivusondur commented on a change in pull request #24026: [SPARK-27090][CORE] Removing old LEGACY_DRIVER_IDENTIFIER ("<driver>")
URL: https://github.com/apache/spark/pull/24026#discussion_r264024208
##########
File path: core/src/test/scala/org/apache/spark/ui/UIUtilsSuite.scala
##########
@@ -122,8 +122,8 @@ class UIUtilsSuite extends SparkFunSuite {
test("decodeURLParameter (SPARK-12708: Sorting task error in Stages Page when yarn mode.)") {
val encoded1 = "%252F"
val decoded1 = "/"
- val encoded2 = "%253Cdriver%253E"
- val decoded2 = "<driver>"
+ val encoded2 = "driver"
Review comment:
done.
Removed unnecessary encode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org