(superset) branch fix-full-csv created (now ba26de24ab6)

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

betodealmeida pushed a change to branch fix-full-csv
in repository https://gitbox.apache.org/repos/asf/superset.git


      at ba26de24ab6 fix: full CSV download in AgGrid

This branch includes the following new commits:

     new ba26de24ab6 fix: full CSV download in AgGrid

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(superset) 01/01: fix: full CSV download in AgGrid

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

betodealmeida pushed a commit to branch fix-full-csv
in repository https://gitbox.apache.org/repos/asf/superset.git

commit ba26de24ab63c361780372c60ebb686b93eb063e
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Thu Jul 2 12:25:11 2026 -0400

    fix: full CSV download in AgGrid
---
 .../SliceHeaderControls.test.tsx                   | 28 ++++++++++++++++++++++
 .../components/SliceHeaderControls/index.tsx       |  3 ++-
 2 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx b/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
index 571f0f695e1..46f7ea0217e 100644
--- a/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
+++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
@@ -237,6 +237,20 @@ test('Should "export full CSV"', async () => {
   expect(props.exportFullCSV).toHaveBeenCalledWith(371);
 });
 
+test('Should "export full CSV" for ag-grid table', async () => {
+  (global as any).featureFlags = {
+    [FeatureFlag.AllowFullCsvExport]: true,
+  };
+  const props = createProps(VizType.TableAgGrid);
+  renderWrapper(props);
+  openMenu();
+  expect(props.exportFullCSV).toHaveBeenCalledTimes(0);
+  userEvent.hover(screen.getByText('Download'));
+  userEvent.click(await screen.findByText('Export to full .CSV'));
+  expect(props.exportFullCSV).toHaveBeenCalledTimes(1);
+  expect(props.exportFullCSV).toHaveBeenCalledWith(371);
+});
+
 test('Should not show export full CSV if report is not table', async () => {
   (global as any).featureFlags = {
     [FeatureFlag.AllowFullCsvExport]: true,
@@ -274,6 +288,20 @@ test('Should "export full Excel"', async () => {
   expect(props.exportFullXLSX).toHaveBeenCalledWith(371);
 });
 
+test('Should "export full Excel" for ag-grid table', async () => {
+  (global as any).featureFlags = {
+    [FeatureFlag.AllowFullCsvExport]: true,
+  };
+  const props = createProps(VizType.TableAgGrid);
+  renderWrapper(props);
+  openMenu();
+  expect(props.exportFullXLSX).toHaveBeenCalledTimes(0);
+  userEvent.hover(screen.getByText('Download'));
+  userEvent.click(await screen.findByText('Export to full Excel'));
+  expect(props.exportFullXLSX).toHaveBeenCalledTimes(1);
+  expect(props.exportFullXLSX).toHaveBeenCalledWith(371);
+});
+
 test('Should not show export full Excel if report is not table', async () => {
   (global as any).featureFlags = {
     [FeatureFlag.AllowFullCsvExport]: true,
diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
index a903787e215..d765e6b1a65 100644
--- a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
+++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
@@ -372,7 +372,8 @@ const SliceHeaderControls = (
     supersetCanShare = false,
     isCached = [],
   } = props;
-  const isTable = slice.viz_type === VizType.Table;
+  const isTable =
+    slice.viz_type === VizType.Table || slice.viz_type === VizType.TableAgGrid;
   const isPivotTable = slice.viz_type === VizType.PivotTable;
   const cachedWhen = (cachedDttm || []).map(itemCachedDttm =>
     (extendedDayjs.utc(itemCachedDttm) as any).fromNow(),