You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/12/18 22:13:21 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1455: [SYSTEMDS-3203] Remove empty columns frame out of bounds

mboehm7 commented on pull request #1455:
URL: https://github.com/apache/systemds/pull/1455#issuecomment-997291960


   LGTM - thanks for the improvements @OlgaOvcharenko and @Baunsgaard. During the merge I made the following changes for performance / correctness:
   * rmEmpty rows (select all) returns shallow copy of frame block (due to copy on write semantics)
   * rmEmpty rows allocates the temporary object array just once outside the loops
   * rmEmpty cols use shallow copies of columns instead of cloned columns (due to copy on write semantics)
   * `DataConverter.convertVectorToIndexList` now copies a range of the physical array in order to guarantee correctness (the physical index/value arrays might be larger than the number of indexes, in which case we would have mistakenly appended column 0 one or multiple times)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org