[GitHub] [arrow-datafusion] alamb edited a comment on pull request #1712: generalize table provider df impl

[GitBox <gi...@apache.org>]

alamb edited a comment on pull request #1712:
URL: https://github.com/apache/arrow-datafusion/pull/1712#issuecomment-1026237402


   > do you think it makes sense to just replace DataFrameImpl with Dataframe now and get rid of all the trait object overheads?
   
   It seems to make sense to me -- it seems to me if someone wanted a different dataframe implementation they would probably just implement it themselves rather than trying to conform to an interface defined by DataFusion.  However, I may not be a good arbiter of what is useful and what is not as I don't use the DataFrame impl much
   
   I can't seem to find where the `DataFrame` trait was defined now (the history gets murky for me when the code got moved around)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org