You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/07/14 11:51:29 UTC
[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2491
[ZEPPELIN-2777] Unit test for configuration module (zeppelin-web)
### What is this PR for?
Added few test cases for the configuration module under `zeppelin-web/`
Additionally, I modified `configuration.html` to add the missing `tbody`.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2777](https://issues.apache.org/jira/browse/ZEPPELIN-2777)
### How should this be tested?
1. cd `zeppelin-web`
2. `yarn install` (or `npm install`)
3. `yarn run test` (or `npm run test`)
The test should pass.
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin add-tests-for-zeppelin-web
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2491.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2491
----
commit 7acf42e795389fd5b4b8e6e415eae15d47f5567b
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-13T15:39:32Z
fix: Remove unused variables
commit d6456266216cfc1ceef8699dde7b67a425d17665
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-13T15:39:53Z
fix: Add missing tbody
commit 4c2d1b5961df06b061a296aa9ae74c349945a205
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-13T15:40:05Z
fix: Add test for configuration
commit bf7a70ff6b47585a7f1125695162a6820ab1b00d
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-14T11:34:05Z
fix: Add more test suite for configuration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2491: [ZEPPELIN-2777] Unit test for configuration module (ze...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2491
Thanks for the reiview @sravan-s @tinkoff-dwh
Merge if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2491: [ZEPPELIN-2777] Unit test for configuration module (ze...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2491
I think `npm test` is enough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2491: [ZEPPELIN-2777] Unit test for configuration module (ze...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2491
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2491
[ZEPPELIN-2777] Unit test for configuration module (zeppelin-web)
### What is this PR for?
Added few test cases for the configuration module under `zeppelin-web/`
Additionally, I modified `configuration.html` to add the missing `tbody`.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2777](https://issues.apache.org/jira/browse/ZEPPELIN-2777)
### How should this be tested?
1. cd `zeppelin-web`
2. `yarn install` (or `npm install`)
3. `yarn run test` (or `npm run test`)
The test should pass.
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin add-tests-for-zeppelin-web
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2491.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2491
----
commit 7acf42e795389fd5b4b8e6e415eae15d47f5567b
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-13T15:39:32Z
fix: Remove unused variables
commit d6456266216cfc1ceef8699dde7b67a425d17665
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-13T15:39:53Z
fix: Add missing tbody
commit 4c2d1b5961df06b061a296aa9ae74c349945a205
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-13T15:40:05Z
fix: Add test for configuration
commit bf7a70ff6b47585a7f1125695162a6820ab1b00d
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-14T11:34:05Z
fix: Add more test suite for configuration
commit af0ba99d869c2d4280ce301def274c0ba7125d62
Author: 1ambda <1a...@gmail.com>
Date: 2017-07-14T12:08:23Z
fix: eslint errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---