You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/15 01:45:19 UTC

[GitHub] [apisix-ingress-controller] lingsamuel opened a new pull request, #967: feat: support ApisixTls v2

lingsamuel opened a new pull request, #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967

   Signed-off-by: Ling Samuel <li...@gmail.com>
   
   ### Type of change:
   
   - [x] New feature provided
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #967: feat: support ApisixTls v2

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967#discussion_r861021525


##########
pkg/ingress/controller.go:
##########
@@ -259,6 +263,17 @@ func (c *Controller) initWhenStartLeading() {
 		apisixRouteInformer = apisixFactory.Apisix().V2beta3().ApisixRoutes().Informer()
 	case config.ApisixRouteV2:
 		apisixRouteInformer = apisixFactory.Apisix().V2().ApisixRoutes().Informer()
+	default:
+		panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixTlsVersion))

Review Comment:
   ```suggestion
   		panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixRouteVersion))
   ```
   ```suggestion
   		panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixTlsVersion))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel merged pull request #967: feat: support ApisixTls v2

Posted by GitBox <gi...@apache.org>.
lingsamuel merged PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #967: feat: support ApisixTls v2

Posted by GitBox <gi...@apache.org>.
lingsamuel commented on code in PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967#discussion_r857082894


##########
pkg/ingress/compare.go:
##########
@@ -107,14 +107,14 @@ func (c *Controller) CompareResources(ctx context.Context) error {
 			// todo ApisixUpstream and ApisixPluginConfig
 			// ApisixUpstream and ApisixPluginConfig should be synced with ApisixRoute resource
 
-			// ApisixSSL
+			// ApisixSSL TODO: Support v2?

Review Comment:
   Maybe in the next PR, this file also contains ApisixRoute needs to be changed. I'd like to change them together.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #967: feat: support ApisixTls v2

Posted by GitBox <gi...@apache.org>.
lingsamuel commented on code in PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967#discussion_r857082624


##########
tools.go:
##########
@@ -1,3 +1,4 @@
+//go:build tools

Review Comment:
   yes



##########
tools.go:
##########
@@ -1,3 +1,4 @@
+//go:build tools

Review Comment:
   yes, i deleted this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #967: feat: support ApisixTls v2

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967#discussion_r855293350


##########
pkg/ingress/controller.go:
##########
@@ -259,6 +263,17 @@ func (c *Controller) initWhenStartLeading() {
 		apisixRouteInformer = apisixFactory.Apisix().V2beta3().ApisixRoutes().Informer()
 	case config.ApisixRouteV2:
 		apisixRouteInformer = apisixFactory.Apisix().V2().ApisixRoutes().Informer()
+	default:
+		panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixTlsVersion))
+	}
+
+	switch c.cfg.Kubernetes.ApisixTlsVersion {
+	case config.ApisixRouteV2beta3:
+		apisixTlsInformer = apisixFactory.Apisix().V2beta3().ApisixTlses().Informer()
+	case config.ApisixRouteV2:

Review Comment:
   ```suggestion
   	case config.ApisixTlsV2:
   ```



##########
Makefile:
##########
@@ -84,6 +84,14 @@ ifeq ("$(wildcard $(GINKGO))", "")
 	exit 1
 endif
 
+
+### push-ingress-images:  Build and push Ingress image used in e2e test suites to kind or custom registry.
+.PHONY: push-ingress-images
+push-ingress-images:
+	docker build -t apache/apisix-ingress-controller:$(IMAGE_TAG) --build-arg ENABLE_PROXY=$(ENABLE_PROXY) .

Review Comment:
   we can reuse `build-image` rule, right?



##########
pkg/ingress/compare.go:
##########
@@ -107,14 +107,14 @@ func (c *Controller) CompareResources(ctx context.Context) error {
 			// todo ApisixUpstream and ApisixPluginConfig
 			// ApisixUpstream and ApisixPluginConfig should be synced with ApisixRoute resource
 
-			// ApisixSSL
+			// ApisixSSL TODO: Support v2?

Review Comment:
   Will v2 support be put in the next PR? Or is it done in this PR?



##########
tools.go:
##########
@@ -1,3 +1,4 @@
+//go:build tools

Review Comment:
   Have you upgraded golang to v1.17+ locally?



##########
pkg/kube/apisix_tls.go:
##########
@@ -0,0 +1,167 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package kube
+
+import (
+	"fmt"
+
+	"github.com/apache/apisix-ingress-controller/pkg/config"
+	configv2 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2"
+	configv2beta3 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+	listersv2 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2"
+	listersv2beta3 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2beta3"
+)
+
+// ApisixTlsLister is an encapsulation for the lister of ApisixTls,
+// it aims at to be compatible with different ApisixTls versions.
+type ApisixTlsLister interface {
+	// V2beta3 gets the ApisixTls in apisix.apache.org/v2beta3.
+	V2beta3(string, string) (ApisixTls, error)
+	// V2 gets the ApisixTls in apisix.apache.org/v2.
+	V2(string, string) (ApisixTls, error)
+}
+
+// ApisixTlsInformer is an encapsulation for the informer of ApisixTls,
+// it aims at to be compatible with different ApisixTls versions.
+type ApisixTlsInformer interface {
+	Run(chan struct{})
+}
+
+// ApisixTls is an encapsulation for ApisixTls resource with different
+// versions, for now, they are apisix.apache.org/v1 and apisix.apache.org/v2alpha1
+type ApisixTls interface {
+	// GroupVersion returns the api group version of the
+	// real ApisixTls.
+	GroupVersion() string
+	// V2beta3 returns the ApisixTls in apisix.apache.org/v2beta3, the real
+	// ApisixTls must be in this group version, otherwise will panic.
+	V2beta3() *configv2beta3.ApisixTls
+	// V2 returns the ApisixTls in apisix.apache.org/v2, the real
+	// ApisixTls must be in this group version, otherwise will panic.
+	V2() *configv2.ApisixTls
+	// ResourceVersion returns the the resource version field inside
+	// the real ApisixTls.
+	ResourceVersion() string
+}
+
+// ApisixTlsEvent contains the ApisixTls key (namespace/name)
+// and the group version message.
+type ApisixTlsEvent struct {
+	Key          string
+	OldObject    ApisixTls
+	GroupVersion string
+}
+
+type apisixTls struct {
+	groupVersion string
+	v2beta3      *configv2beta3.ApisixTls
+	v2           *configv2.ApisixTls
+}
+
+func (ar *apisixTls) V2beta3() *configv2beta3.ApisixTls {
+	if ar.groupVersion != config.ApisixTlsV2beta3 {
+		panic("not a apisix.apache.org/v2beta3 route")

Review Comment:
   ```suggestion
   		panic("not a apisix.apache.org/v2beta3 Tls")
   ```



##########
pkg/kube/apisix_tls.go:
##########
@@ -0,0 +1,167 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package kube
+
+import (
+	"fmt"
+
+	"github.com/apache/apisix-ingress-controller/pkg/config"
+	configv2 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2"
+	configv2beta3 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+	listersv2 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2"
+	listersv2beta3 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2beta3"
+)
+
+// ApisixTlsLister is an encapsulation for the lister of ApisixTls,
+// it aims at to be compatible with different ApisixTls versions.
+type ApisixTlsLister interface {
+	// V2beta3 gets the ApisixTls in apisix.apache.org/v2beta3.
+	V2beta3(string, string) (ApisixTls, error)
+	// V2 gets the ApisixTls in apisix.apache.org/v2.
+	V2(string, string) (ApisixTls, error)
+}
+
+// ApisixTlsInformer is an encapsulation for the informer of ApisixTls,
+// it aims at to be compatible with different ApisixTls versions.
+type ApisixTlsInformer interface {
+	Run(chan struct{})
+}
+
+// ApisixTls is an encapsulation for ApisixTls resource with different
+// versions, for now, they are apisix.apache.org/v1 and apisix.apache.org/v2alpha1
+type ApisixTls interface {
+	// GroupVersion returns the api group version of the
+	// real ApisixTls.
+	GroupVersion() string
+	// V2beta3 returns the ApisixTls in apisix.apache.org/v2beta3, the real
+	// ApisixTls must be in this group version, otherwise will panic.
+	V2beta3() *configv2beta3.ApisixTls
+	// V2 returns the ApisixTls in apisix.apache.org/v2, the real
+	// ApisixTls must be in this group version, otherwise will panic.
+	V2() *configv2.ApisixTls
+	// ResourceVersion returns the the resource version field inside
+	// the real ApisixTls.
+	ResourceVersion() string
+}
+
+// ApisixTlsEvent contains the ApisixTls key (namespace/name)
+// and the group version message.
+type ApisixTlsEvent struct {
+	Key          string
+	OldObject    ApisixTls
+	GroupVersion string
+}
+
+type apisixTls struct {
+	groupVersion string
+	v2beta3      *configv2beta3.ApisixTls
+	v2           *configv2.ApisixTls
+}
+
+func (ar *apisixTls) V2beta3() *configv2beta3.ApisixTls {

Review Comment:
   If the meaning of `ar` is `APISIX resource` , then we can go ahead and use it. 
   Otherwise a clearer name should be used, right?



##########
pkg/kube/apisix_tls.go:
##########
@@ -0,0 +1,167 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package kube
+
+import (
+	"fmt"
+
+	"github.com/apache/apisix-ingress-controller/pkg/config"
+	configv2 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2"
+	configv2beta3 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+	listersv2 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2"
+	listersv2beta3 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2beta3"
+)
+
+// ApisixTlsLister is an encapsulation for the lister of ApisixTls,
+// it aims at to be compatible with different ApisixTls versions.
+type ApisixTlsLister interface {
+	// V2beta3 gets the ApisixTls in apisix.apache.org/v2beta3.
+	V2beta3(string, string) (ApisixTls, error)
+	// V2 gets the ApisixTls in apisix.apache.org/v2.
+	V2(string, string) (ApisixTls, error)
+}
+
+// ApisixTlsInformer is an encapsulation for the informer of ApisixTls,
+// it aims at to be compatible with different ApisixTls versions.
+type ApisixTlsInformer interface {
+	Run(chan struct{})
+}
+
+// ApisixTls is an encapsulation for ApisixTls resource with different
+// versions, for now, they are apisix.apache.org/v1 and apisix.apache.org/v2alpha1
+type ApisixTls interface {
+	// GroupVersion returns the api group version of the
+	// real ApisixTls.
+	GroupVersion() string
+	// V2beta3 returns the ApisixTls in apisix.apache.org/v2beta3, the real
+	// ApisixTls must be in this group version, otherwise will panic.
+	V2beta3() *configv2beta3.ApisixTls
+	// V2 returns the ApisixTls in apisix.apache.org/v2, the real
+	// ApisixTls must be in this group version, otherwise will panic.
+	V2() *configv2.ApisixTls
+	// ResourceVersion returns the the resource version field inside
+	// the real ApisixTls.
+	ResourceVersion() string
+}
+
+// ApisixTlsEvent contains the ApisixTls key (namespace/name)
+// and the group version message.
+type ApisixTlsEvent struct {
+	Key          string
+	OldObject    ApisixTls
+	GroupVersion string
+}
+
+type apisixTls struct {
+	groupVersion string
+	v2beta3      *configv2beta3.ApisixTls
+	v2           *configv2.ApisixTls
+}
+
+func (ar *apisixTls) V2beta3() *configv2beta3.ApisixTls {
+	if ar.groupVersion != config.ApisixTlsV2beta3 {
+		panic("not a apisix.apache.org/v2beta3 route")
+	}
+	return ar.v2beta3
+}
+func (ar *apisixTls) V2() *configv2.ApisixTls {
+	if ar.groupVersion != config.ApisixTlsV2 {
+		panic("not a apisix.apache.org/v2 route")

Review Comment:
   ```suggestion
   		panic("not a apisix.apache.org/v2 Tls")
   ```



##########
pkg/ingress/controller.go:
##########
@@ -259,6 +263,17 @@ func (c *Controller) initWhenStartLeading() {
 		apisixRouteInformer = apisixFactory.Apisix().V2beta3().ApisixRoutes().Informer()
 	case config.ApisixRouteV2:
 		apisixRouteInformer = apisixFactory.Apisix().V2().ApisixRoutes().Informer()
+	default:
+		panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixTlsVersion))
+	}
+
+	switch c.cfg.Kubernetes.ApisixTlsVersion {
+	case config.ApisixRouteV2beta3:

Review Comment:
   ```suggestion
   	case config.ApisixTlsV2beta3:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #967: feat: support ApisixTls v2

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967#issuecomment-1100072042

   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#967](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c15e867) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/aee6e7893a731b623fd3bf4f0c1f7bd8d35efae1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aee6e78) will **decrease** coverage by `0.62%`.
   > The diff coverage is `0.36%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #967      +/-   ##
   ==========================================
   - Coverage   31.75%   31.13%   -0.63%     
   ==========================================
     Files          72       73       +1     
     Lines        7935     8156     +221     
   ==========================================
   + Hits         2520     2539      +19     
   - Misses       5139     5341     +202     
     Partials      276      276              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `64.64% <ø> (ø)` | |
   | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/compare.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29tcGFyZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.92% <0.00%> (-0.02%)` | :arrow_down: |
   | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `77.81% <0.00%> (ø)` | |
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `46.07% <ø> (ø)` | |
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `78.64% <100.00%> (+0.20%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aee6e78...c15e867](https://codecov.io/gh/apache/apisix-ingress-controller/pull/967?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #967: feat: support ApisixTls v2

Posted by GitBox <gi...@apache.org>.
lingsamuel commented on code in PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967#discussion_r857082518


##########
Makefile:
##########
@@ -84,6 +84,14 @@ ifeq ("$(wildcard $(GINKGO))", "")
 	exit 1
 endif
 
+
+### push-ingress-images:  Build and push Ingress image used in e2e test suites to kind or custom registry.
+.PHONY: push-ingress-images
+push-ingress-images:
+	docker build -t apache/apisix-ingress-controller:$(IMAGE_TAG) --build-arg ENABLE_PROXY=$(ENABLE_PROXY) .

Review Comment:
   `build-image` uses `ENABLE_PROXY=true`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #967: feat: support ApisixTls v2

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967#discussion_r861021526


##########
pkg/ingress/controller.go:
##########
@@ -259,6 +263,17 @@ func (c *Controller) initWhenStartLeading() {
 		apisixRouteInformer = apisixFactory.Apisix().V2beta3().ApisixRoutes().Informer()
 	case config.ApisixRouteV2:
 		apisixRouteInformer = apisixFactory.Apisix().V2().ApisixRoutes().Informer()
+	default:
+		panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixTlsVersion))

Review Comment:
   ```suggestion
   		panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixRouteVersion))
   ```
   ```suggestion
   		panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixTlsVersion))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org