You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/06/18 22:50:12 UTC

Review Request: Fix locks in linux/fs.cpp

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5403/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Jie Yu.


Description
-------

linux/fs.cpp calls the Lock constructor (which actually acquires the lock) from a static initializer and fails to properly initialize the pthread_mutex_t (as with PTHREAD_*_INITIALIZER or pthread_mutex_init()). This patch uses static pthread_mutex_t's and uses RAII-style locks instead.


Diffs
-----

  src/linux/fs.cpp 296990b 

Diff: https://reviews.apache.org/r/5403/diff/


Testing
-------


Thanks,

Charles Reiss

Re: Review Request: Fix locks in linux/fs.cpp

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5403/#review8359
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On June 18, 2012, 8:50 p.m., Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5403/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 8:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Description
> -------
> 
> linux/fs.cpp calls the Lock constructor (which actually acquires the lock) from a static initializer and fails to properly initialize the pthread_mutex_t (as with PTHREAD_*_INITIALIZER or pthread_mutex_init()). This patch uses static pthread_mutex_t's and uses RAII-style locks instead.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 296990b 
> 
> Diff: https://reviews.apache.org/r/5403/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles Reiss
> 
>